From: Matthias Brugger <matthias.bgg@gmail.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
matthias.bgg@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
Chen-Yu Tsai <wenst@chromium.org>
Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 4/4] Revert "arm64: dts: mt8173: add mmsel clocks for 4K support"
Date: Thu, 2 Mar 2023 12:03:16 +0100 [thread overview]
Message-ID: <dcd653a3-3f7c-7bfb-f096-033f62cb9074@gmail.com> (raw)
In-Reply-To: <3db45ca3-9104-826c-9f92-549e07471296@collabora.com>
On 10/02/2023 12:59, AngeloGioacchino Del Regno wrote:
> Il 09/02/23 17:03, matthias.bgg@kernel.org ha scritto:
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> This reverts commit fc6634ac0e5380aeb1063275a2e9a583d41b2306.
>>
>> The mmsys is a clock provider but does not have any clocks connected to
>> it. Therefore assigned-clock properties should be applied to the users of mmsys.
>>
>> This fixes the DT schema check:
>> mediatek/mt8173-elm.dtb: syscon@14000000: 'assigned-clock-rates',
>> 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> About solving schema checks: agreed.
>
> Since this is impacting on multiple subsystems (display, vdec, venc), can we
> instead move this to the topckgen node?
> I didn't check if that would trigger another schema check, but I remember
> doing that on Qualcomm DTs a bit of time ago.
>
> The alternative would be to copy that over more than 10 nodes, which would
> be a bit ... ugly.
>
Thanks Angelo and Chen-Yu for your feedback. I'm not able to reproduce that
problem right now, so I'll drop this patch from the series.
Regards,
Matthias
next prev parent reply other threads:[~2023-03-02 11:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 16:03 [PATCH v1 1/4] arm64: dts: mt8195: Update vdosys compatible matthias.bgg
2023-02-09 16:03 ` [PATCH v1 2/4] arm64: dts: mt8167: Align mmsys node name with dtschema matthias.bgg
2023-02-10 2:42 ` Chen-Yu Tsai
2023-02-10 11:59 ` AngeloGioacchino Del Regno
2023-02-09 16:03 ` [PATCH v1 3/4] arm64: dts: mt8195: Align vppsys node to dtschema matthias.bgg
2023-02-10 2:42 ` Chen-Yu Tsai
2023-02-10 11:59 ` AngeloGioacchino Del Regno
2023-03-02 11:07 ` Matthias Brugger
2023-02-09 16:03 ` [PATCH v1 4/4] Revert "arm64: dts: mt8173: add mmsel clocks for 4K support" matthias.bgg
2023-02-10 2:44 ` Chen-Yu Tsai
2023-02-10 11:59 ` AngeloGioacchino Del Regno
2023-03-02 11:03 ` Matthias Brugger [this message]
2023-02-10 2:41 ` [PATCH v1 1/4] arm64: dts: mt8195: Update vdosys compatible Chen-Yu Tsai
2023-02-10 11:59 ` AngeloGioacchino Del Regno
2023-03-02 11:26 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcd653a3-3f7c-7bfb-f096-033f62cb9074@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).