From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Ioana Ciornei <ioana.ciornei@nxp.com>,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next] dt-bindings: net: convert sff,sfp to dtschema
Date: Thu, 31 Mar 2022 22:45:51 +0200 [thread overview]
Message-ID: <dce02cb9-c173-f1c5-a645-461d314e467a@linaro.org> (raw)
In-Reply-To: <259ac0f4-50e9-291b-9ed3-91b52840fb9e@linaro.org>
On 30/03/2022 18:51, Krzysztof Kozlowski wrote:
> On 30/03/2022 17:40, Russell King (Oracle) wrote:
>>
>>>> +
>>>> + - | # Serdes to PHY to SFP connection
>>>> + #include <dt-bindings/gpio/gpio.h>
>>>
>>> Are you sure it works fine? Double define?
>>
>> Err what? Sorry, I don't understand what you're saying here, please
>> explain what the issue is.
>
> Including the same header twice causes duplicate defines, which should
> be visible when testing the binding.
I don't see such errors now, so either something changed or I confused
with something else. It should work, so let's skip my comment here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-31 20:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 12:33 [PATCH net-next] dt-bindings: net: convert sff,sfp to dtschema Ioana Ciornei
2022-03-15 18:21 ` Krzysztof Kozlowski
2022-03-15 19:07 ` Ioana Ciornei
2022-03-16 8:23 ` Krzysztof Kozlowski
2022-03-16 10:18 ` Ioana Ciornei
2022-03-16 12:04 ` Krzysztof Kozlowski
2022-03-30 15:54 ` Russell King (Oracle)
2022-03-30 15:56 ` Russell King (Oracle)
2022-03-30 16:44 ` Krzysztof Kozlowski
2022-03-30 15:52 ` Russell King (Oracle)
2022-03-30 16:09 ` Rob Herring
2022-03-30 16:35 ` Russell King (Oracle)
2022-03-30 15:40 ` Russell King (Oracle)
2022-03-30 16:51 ` Krzysztof Kozlowski
2022-03-30 16:59 ` Krzysztof Kozlowski
2022-03-31 20:45 ` Krzysztof Kozlowski [this message]
2022-06-10 22:31 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dce02cb9-c173-f1c5-a645-461d314e467a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).