From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B8920B29 for ; Mon, 19 Feb 2024 07:38:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708328300; cv=none; b=sXaQdw/oe9MVXKX9gO+I4XCo8jhrNB5YX/5umhQqPOV7mOOv5vfDl8WMuRww6zomB8E7lAvjiC5+NdgrTmKIXG4QVaGslGXtngoD7YcZ8oKzNGWxjkBD4gd7KrWJxM0YzkZfrrk/A3Kj2yKQIci1bLSuH2opt+JqWqHhD47TL0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708328300; c=relaxed/simple; bh=sEpRq9avJFC2ktUz56c7VohDfJ6P5s2iicug6CLi7mQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k+NF1H+BxjEY6xoJ6/Bxpcwftm6MSdfDKJ903gFiM8vcNJD+FTurQ0iDVeVrA47pANPsPP3Ie9wXua4lL44YDVxq0UCH0fi3le2GszRO7hsBeQVrw5pOQV+4t4O+6iyZMPMgSFooSYSnFfO8uHNS27KEOP/IFTZsZQRkXg44+c4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dIabnhJU; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dIabnhJU" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-40fb3b5893eso19467355e9.0 for ; Sun, 18 Feb 2024 23:38:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708328297; x=1708933097; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+92+e6nKOYqvLoeXiLnezh7dMajbd0mDjTA//vjxt8w=; b=dIabnhJU4nasSnYdydwqS1uzmL/TpBLSGhZojnb+h+9EwC9RiHc6djAmWcLVJdvXbS SxOI0shglkMAtj8rQRHECMajkjLJENXmZnPTSk3wyIAJqRRGlyQpDoL9b5WhUjLk3MLD LZr1qpvoJx1/m20y51QHxJT+3dNcGLtiPM1sfY60jfXp2Sr/0BSN+gqBt47WeNHd7Ams BClUqGFvF9PFJeYxPiPxt/sX4KEeG4IdYU0sxFcFFdAU68S7eUaB4LyOobTjl4oMweBK HPY8GO178MfSIRcaFi5HhnOxxK2H1Y/cxYYGghvR494Y3TjWv8paS1BGqE32KPk43zmf NFow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708328297; x=1708933097; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+92+e6nKOYqvLoeXiLnezh7dMajbd0mDjTA//vjxt8w=; b=TzEnAh473uq6TFGn1wnl31NGoas08riQSdoWB4Gc2br+tPD5IFN/D9KAoOuQtW2aKF jo+q62x01ZkEdn03YwToQQhwBX5beW5kwG9dNbXALdWmbTcKklPQIBecu0oVbpCfk+z+ 2NCjwVexniOLJHQtmvkpy+f+uYAb1hif9qxp7IgtRYe0MZmt7nlIyqrdrItwtwTK15LT BGPXY9UE3loc253HXJjDtcOVQ7+IeD4k4G9R51/6vNiD/CTUYo2GUdfMI+QSOjz+U2ya EevPL4tVE4VMCVelFD/cep8rESkKLX09WIWe/8S1O49FpcQGSXHxuY+5YstnYO/471bo NZPw== X-Forwarded-Encrypted: i=1; AJvYcCWhDBYKM2Nn4kmEG6FwBka0NMEJD1xweWd8BwmJxMJqHh0XLznApEMjJE9ftQOd9Ibxr86SxWtKYoksD3ck9/tODSMpOa/MdKpP9A== X-Gm-Message-State: AOJu0Yz+rHETkD+7nG1VzcktRJkskQIB/+dnxIcLGTcBtOdWxMpktt6l Jw9mr07PzBmJhJf+1DwEF30d/yXUJ0HvMNxzMKAxl/HwnlMOfqkFteGzV9Das0w= X-Google-Smtp-Source: AGHT+IFHwh5BE/Abo7HfIokCLkBltQEQil9O9xuVzVqPQoF/TwU6Yzym4Un11vYNW0fWxXFJ9L97LA== X-Received: by 2002:a05:6000:144:b0:33b:279a:5cb1 with SMTP id r4-20020a056000014400b0033b279a5cb1mr7391045wrx.11.1708328296838; Sun, 18 Feb 2024 23:38:16 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.116]) by smtp.gmail.com with ESMTPSA id k3-20020a056000004300b0033b79d385f6sm9450013wrx.47.2024.02.18.23.38.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Feb 2024 23:38:16 -0800 (PST) Message-ID: Date: Mon, 19 Feb 2024 08:38:12 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 06/18] dt-bindings: new: wireless: describe the ath12k PCI module Content-Language: en-US To: Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kalle Valo , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Catalin Marinas , Will Deacon , Bjorn Helgaas , Saravana Kannan , Geert Uytterhoeven , Arnd Bergmann , Neil Armstrong , Marek Szyprowski , Alex Elder , Srini Kandagatla , Greg Kroah-Hartman , Abel Vesa , Manivannan Sadhasivam , Lukas Wunner , Dmitry Baryshkov Cc: linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Bartosz Golaszewski References: <20240216203215.40870-1-brgl@bgdev.pl> <20240216203215.40870-7-brgl@bgdev.pl> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240216203215.40870-7-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/02/2024 21:32, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add device-tree bindings for the ATH12K module found in the WCN7850 > package. > > Signed-off-by: Bartosz Golaszewski > --- > .../net/wireless/qcom,ath12k-pci.yaml | 103 ++++++++++++++++++ > 1 file changed, 103 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > new file mode 100644 > index 000000000000..063c576b99a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml This means there can be ath12k over AHB or some other bus, which would be quite different and not fit together in one schema file. It's that the case? > @@ -0,0 +1,103 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2024 Linaro Limited > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-pci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies ath12k wireless devices (PCIe) > + > +maintainers: > + - Bartosz Golaszewski > + > +description: | Do not need '|' unless you need to preserve formatting. > + Qualcomm Technologies IEEE 802.11ax PCIe devices > + > +properties: > + compatible: > + enum: > + - pci17cb,1107 # WCN7850 > + > + reg: > + maxItems: 1 > + > + enable-gpios: > + maxItems: 1 > + description: GPIO line enabling the WLAN module > + > + vdd-supply: > + description: VDD supply regulator handle > + > + vddio-supply: > + description: VDD_IO supply regulator handle > + > + vddio1p2-supply: > + description: VDD_IO_1P2 supply regulator handle > + > + vddaon-supply: > + description: VDD_AON supply regulator handle > + > + vdddig-supply: > + description: VDD_DIG supply regulator handle > + > + vddrfa1p2-supply: > + description: VDD_RFA_1P2 supply regulator handle > + > + vddrfa1p8-supply: > + description: VDD_PCIE_1P8 supply regulator handle > + > + clocks: > + maxItems: 1 > + description: > + Reference clock phandle These three could be just: items: - description: Reference clock (phandle is redundant in this context) Best regards, Krzysztof