From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE9D641C91; Wed, 7 Feb 2024 18:41:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707331269; cv=none; b=HBUKsfMdIoP9xp9/JVqV4bkz/CNPR5uL+KmcddW+Qs0i0sqg7ayepAlDA3x0/cMolNt7bh2rDxnHGP//EDNPQ98qRyg+DKuquuKbSXGv5o1HgqkZECFDWgj4QWDPm+9If6ToprNA0ZzmEmT0aFla6VO/JZjhmqOcApgcPPy4oPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707331269; c=relaxed/simple; bh=0Bcre0rC2pTtwW82tC2xqrqvK6yDzJC3IMXWhaGhheA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fy1P3paC4b5w4JoWEQFUoGBUL4utJxMFVGbaIJt/7aB3OolDaEF1MjojOOB/b1pocwa5FEbrIKi8ckcQJsUOq4hTIrOP3NSRe2iDK4kuswAcFHEV9HF43KnsVpdMl1Cjluj3oWweYJVFj19n+7Iok9ghjLlbhfWIPRKGaXa5Y9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=OSa5Fmkr; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="OSa5Fmkr" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=NM96PRgp7Go5/u5ErschDZoCtLvUhRM5ifc/fsNb7PY=; b=OSa5FmkrdKlgn3giyTHmOti/ER oz0XB0MPja3MiuiEIGEGolz1YVKiNpeQ0jBICRFEznTxklusZOcJ10QRnaUDZYO6JOrSUe7AxE4G7 FEDJeMOjohRUEkAhpbLzJSEKvFqazNq2kx8vqrKU6iE3VCss23XJ25+HyPWbDaY9w65M=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rXmqo-007FCD-Hj; Wed, 07 Feb 2024 19:40:50 +0100 Date: Wed, 7 Feb 2024 19:40:50 +0100 From: Andrew Lunn To: Eric Woudstra Cc: Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , Russell King , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , Daniel Golle , Lucien Jheng , Zhi-Jun You , netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next 1/2] dt-bindings: net: airoha,en8811h: Add en8811h serdes polarity Message-ID: References: <20240206194751.1901802-1-ericwouds@gmail.com> <20240206194751.1901802-2-ericwouds@gmail.com> <76f9aeed-9c8c-4bbf-98b5-98e9ee7dfff8@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > As for the compatible string, the PHY reports it's c45-id okay and > phylink can find the driver with this id. Therefore I have left the > compatible string out of the devicetree node of the phy and not > specified it in the binding (also same as realtek,rtl82xx.yaml). As you pointed out, the kernel does not require a compatible. So in your board DT blob, you don't need it. In the binding document, you can indicate a compatible can optionally be used, and in the example its a good idea it actually use it, so that the example gets checked by the tools. Andrew