From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Yang <mmyangfl@gmail.com>, linux-clk@vger.kernel.org
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: clock: Add simple-clock-controller
Date: Mon, 17 Apr 2023 08:28:50 +0200 [thread overview]
Message-ID: <dd3efedd-54b8-5d10-397f-4c7c2a62d3a2@linaro.org> (raw)
In-Reply-To: <20230416194624.1258860-2-mmyangfl@gmail.com>
On 16/04/2023 21:46, David Yang wrote:
> Add DT bindings documentation for simple clock controller, just a
> contiguous region of multiple clock registers.
>
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
> .../clock/simple-clock-controller.yaml | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/simple-clock-controller.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/simple-clock-controller.yaml b/Documentation/devicetree/bindings/clock/simple-clock-controller.yaml
> new file mode 100644
> index 000000000000..3d9b436b0ef9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/simple-clock-controller.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/simple-clock-controller.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Simple clock controller
> +
> +maintainers:
> + - David Yang <mmyangfl@gmail.com>
> +
> +description: |
> + A contiguous register region of multiple different clocks. No operations are
> + required to enable or disable the clock controller.
> +
> +properties:
> + compatible:
> + const: simple-clock-controller
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + '.*clock.*':
> + type: object
> + description: Clock devices.
I don't know what improved here... this is still without any refs.
It looks like you ignored my feedback from v1 and maybe v2, so respond
to each of it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-17 6:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 19:46 [PATCH v3 0/4] clk: Add basic register clock controller David Yang
2023-04-16 19:46 ` [PATCH v3 1/4] dt-bindings: clock: Add simple-clock-controller David Yang
2023-04-17 6:28 ` Krzysztof Kozlowski [this message]
2023-04-17 6:30 ` Krzysztof Kozlowski
2023-04-16 19:46 ` [PATCH v3 2/4] clk: Add simple clock controller David Yang
2023-04-18 19:12 ` kernel test robot
2023-04-16 19:46 ` [PATCH v3 3/4] dt-bindings: clock: Add gate-clock David Yang
2023-04-18 0:12 ` Stephen Boyd
2023-04-16 19:46 ` [PATCH v3 4/4] clk: gate: Add DT binding David Yang
2023-04-17 6:27 ` [PATCH v3 0/4] clk: Add basic register clock controller Krzysztof Kozlowski
2023-04-17 18:16 ` Yangfl
2023-04-18 22:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd3efedd-54b8-5d10-397f-4c7c2a62d3a2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).