Re: [PATCH v3 3/4] dt-bindings: trivial-devices: Document max31785 sensors

[Eddie James <eajames@linux.ibm.com>]

On 8/6/25 5:59 PM, Rob Herring wrote:
> On Wed, Aug 6, 2025 at 5:04 PM Rob Herring <robh@kernel.org> wrote:
>> On Wed, Aug 6, 2025 at 1:47 PM Eddie James <eajames@linux.ibm.com> wrote:
>>> Remove the old .txt max31785 documentation and add the compatibles
>>> to trivial-devices.yaml.
>>>
>>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
>>> ---
>>>   .../devicetree/bindings/hwmon/max31785.txt    | 22 -------------------
>>>   .../devicetree/bindings/trivial-devices.yaml  |  4 ++++
>>>   2 files changed, 4 insertions(+), 22 deletions(-)
>>>   delete mode 100644 Documentation/devicetree/bindings/hwmon/max31785.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/max31785.txt b/Documentation/devicetree/bindings/hwmon/max31785.txt
>>> deleted file mode 100644
>>> index 106e08c56aaa..000000000000
>>> --- a/Documentation/devicetree/bindings/hwmon/max31785.txt
>>> +++ /dev/null
>>> @@ -1,22 +0,0 @@
>>> -Bindings for the Maxim MAX31785 Intelligent Fan Controller
>>> -==========================================================
>>> -
>>> -Reference:
>>> -
>>> -https://datasheets.maximintegrated.com/en/ds/MAX31785.pdf
>>> -
>>> -The Maxim MAX31785 is a PMBus device providing closed-loop, multi-channel fan
>>> -management with temperature and remote voltage sensing. Various fan control
>>> -features are provided, including PWM frequency control, temperature hysteresis,
>>> -dual tachometer measurements, and fan health monitoring.
>> While technically the binding is trivial, I don't think this device
>> really is. It has got 6 PWMs and 6 tach inputs, a reset line, 2
>> interrupts (alert and fault?), and an I2C master. Not really trivial.
>>
>> However, better to have this documented as a schema than not, so I'll apply it.
> I take that back. You already have 'fan' child nodes, so this isn't a
> trivial device/binding.


That's true, I will add a proper binding.


Thanks,

Eddie


>
> Rob