From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kanak Shilledar <kanakshilledar@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kanak Shilledar <kanakshilledar111@protonmail.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: serial: vt8500-uart: convert to json-schema
Date: Wed, 12 Jun 2024 17:07:27 +0200 [thread overview]
Message-ID: <dd529de8-07b0-444d-83c3-4b8c3424a7ef@kernel.org> (raw)
In-Reply-To: <20240612142951.37259-1-kanakshilledar@gmail.com>
On 12/06/2024 16:29, Kanak Shilledar wrote:
> Convert the VIA VT8500 and WonderMedia WM8xxx UART Controller to
> newer DT schema. Created DT schema based on the .txt file which had
> `compatible`, `reg`, `interrupts` and `clocks` as required properties.
>
> Additions to the original binding
> - changed the file name from vt8500-uart to via,vt8500-uart.yaml
> - removed unnecessary alias from the example.
> - added Greg and Jiri as maintainers (referred MAINTAINERS file).
?
>
> Signed-off-by: Kanak Shilledar <kanakshilledar@gmail.com>
> ---
> Changes in v2:
> - Rebased changes
> - Changed maintainers to have Rob. VT8500 is orphaned according
> to the maintainers file.
> - Replaced `compatible` property description with comments.
> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/serial/via,vt8500-uart.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: VIA VT8500 and WonderMedia WM8xxx UART Controller
> +
> +maintainers:
> + - Rob Herring <robh@kernel.org>
Not Rob.
> + - Kanak Shilledar <kanakshilledar111@protonmail.com>
I doubt you care about this device. This could be most recent
contributor, so: Alexey Charkov <alchark@gmail.com>
> +
> +allOf:
> + - $ref: serial.yaml
> +
> +properties:
> + compatible:
> + enum:
> + - via,vt8500-uart # up to WM8850/WM8950
> + - wm,wm8880-uart # for WM8880 and later
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-12 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 14:29 [PATCH v2] dt-bindings: serial: vt8500-uart: convert to json-schema Kanak Shilledar
2024-06-12 14:54 ` Greg Kroah-Hartman
2024-06-12 15:07 ` Krzysztof Kozlowski [this message]
2024-06-12 15:32 ` Kanak Shilledar
2024-06-12 16:25 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd529de8-07b0-444d-83c3-4b8c3424a7ef@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kanakshilledar111@protonmail.com \
--cc=kanakshilledar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox