From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123AFEB64DC for ; Tue, 18 Jul 2023 08:03:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230192AbjGRIDm (ORCPT ); Tue, 18 Jul 2023 04:03:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232001AbjGRICy (ORCPT ); Tue, 18 Jul 2023 04:02:54 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 852791984 for ; Tue, 18 Jul 2023 01:02:11 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5216f713f8bso5256438a12.2 for ; Tue, 18 Jul 2023 01:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689667323; x=1692259323; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QsIxNK0J5zdm7hoTGkqELX9EdWQda/w8CE55dNKdQBI=; b=KdKmYaQBSFl0lVylZviXy1L8wRpdutlz6y72k+fhKifuidOimyIzONwkAlJbbhNg2t c309jLRA4Gz0xvuIe5hAvQ5u3av8x+NIxbiDYlcj15j33wCU8fmcDvTVoP+G7sn6dFRe OrZsPE6+5bCs5lTumVNLsZ2fhSyz7ea2Zdx2nf9YyQaPcK/f6rBEWvraSSJfbQrMmfbd RAOPRMzYs3epeWJIUYd96XrCUsPPOhYlx7eRprG7Vf0f+JmMoCtMDPNGWTnM6F6qScL7 0pMeFnnOv8lEmoaMNA93mHM6GCZKDsvDxvjbOysnhP5nGgHUKz95LCy1K6n7iEKTSseW VOEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689667323; x=1692259323; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QsIxNK0J5zdm7hoTGkqELX9EdWQda/w8CE55dNKdQBI=; b=YE5OFHvE0Mc/9M5JrmDBXNDKrpvLv4uwHXbUnf4GrgH1e60F/hzw/7pQCs0iauZzDH aBLqgM2gyp14WfcE+dLp7algKAYznn82zkN7Cqog816mR4G+M4FHTAL8TkXGkhj3lBjB zZPDQ6wSCfMKbKkfUIcukUxOsUmml/kClg4mcFouyiQ8YGRJpZlBRc4S0ad7q4ap8iq2 syk4yamgpwBEooSuNgxtrlwTqOoTQ1GbfPpytSWf8O7j0o7/j8KUaD0fwxuF+IuMoe3F h+ssBJM0Vu4j/iAR2CbgXPBYW4fLvrMWauZcY7yZ0QU9kMdCkNLBCh28LhYkqCPR+65k ojYw== X-Gm-Message-State: ABy/qLYbW6tVWjfml4kdWO/3wJtaaI/d63O1a+F5+N9QMC61H73YUNiq CCHQM+o8LFlANTDObX6setfCxQ== X-Google-Smtp-Source: APBJJlFW9DT9BZsr+XSPA2vB4OYCmyLRfrxqABO39xqF1LRjNNFkSnkQk8GPqJZQvi8LFGtx8O/ekQ== X-Received: by 2002:a05:6402:68b:b0:521:94f0:9987 with SMTP id f11-20020a056402068b00b0052194f09987mr4209464edy.37.1689667323562; Tue, 18 Jul 2023 01:02:03 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id u25-20020aa7d899000000b0051e19bf66a4sm804060edq.83.2023.07.18.01.02.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 01:02:03 -0700 (PDT) Message-ID: Date: Tue, 18 Jul 2023 10:02:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support Content-Language: en-US To: Fenglin Wu , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , linux-input@vger.kernel.org, devicetree@vger.kernel.org Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com, quic_kamalw@quicinc.com, jestar@qti.qualcomm.com, quic_huliu@quicinc.com References: <20230718062639.2339589-1-quic_fenglinw@quicinc.com> <20230718062639.2339589-2-quic_fenglinw@quicinc.com> <4cb9f443-bdea-695a-f1b7-3963747e9a17@quicinc.com> <5b7e624b-5d06-826d-92d1-2a721b7c83b7@quicinc.com> <4210b137-2d5d-a467-ea8c-d047701fdcc2@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <4210b137-2d5d-a467-ea8c-d047701fdcc2@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/07/2023 09:59, Fenglin Wu wrote: >>> Just FYI,the change log was updated in the cover letter here: >>> https://lore.kernel.org/linux-arm-msm/20230718062639.2339589-1-quic_fenglinw@quicinc.com/T/#m3819b50503ef19e0933a10bf797351a4af35537f >>> >>> Also the commit text and the driver change were also updated accordingly >>> to address your review comment by removing 'pm7550ba-vib' compatible string. >> >> Removing compatible was never my feedback. Did you read: >> https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 >> ? >> > Okay, so do you want me to add 'pm7550ba-vib' as a fallback compatible > like this? > > properties: > compatible: > - enum: > - - qcom,pm8058-vib > - - qcom,pm8916-vib > - - qcom,pm8921-vib > - - qcom,pmi632-vib > - - qcom,pm7250b-vib > - - qcom,pm7325b-vib > + oneOf: > + - enum: > + - qcom,pm8058-vib > + - qcom,pm8916-vib > + - qcom,pm8921-vib > + - qcom,pmi632-vib > + - qcom,pm7250b-vib > + - qcom,pm7325b-vib > + - items: > + - enum: > + - qcom,pm7550ba-vib > + - const: qcom,pm7325b-vib > Yes Best regards, Krzysztof