Devicetree
 help / color / mirror / Atom feed
From: Petar Stepanovic <pstepanovic@axiado.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Akhila Kavi" <akavi@axiado.com>,
	"Prasad Bolisetty" <pbolisetty@axiado.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Harshit Shah" <hshah@axiado.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: add Axiado SARADC driver
Date: Tue, 16 Jun 2026 10:47:29 +0200	[thread overview]
Message-ID: <dd632be7-d5e3-4568-a3a7-d9e9c75de472@axiado.com> (raw)
In-Reply-To: <aisPbXOB6cofF4_r@ashevche-desk.local>


On 6/11/2026 9:41 PM, Andy Shevchenko wrote:
>> +struct axiado_saradc {
>> +     void __iomem *regs;
>> +     struct clk *clk;
>> +     unsigned long clk_rate;
>> +     int vref_uV;
>> +     struct mutex lock; /* Serializes ADC conversions. */
>> +};
> Is `pahole` satisfied with the chosen layout?

Thanks, Andy.

I checked it and found that the current layout can be improved. I will rearrange the structure members in v3 to avoid the layout issue.

I will also address the other comments in v3.

Regards,
Petar


      reply	other threads:[~2026-06-16  8:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11  9:37 [PATCH v2 0/2] iio: adc: Add Axiado SARADC driver Petar Stepanovic
2026-06-11  9:37 ` [PATCH v2 1/2] dt-bindings: iio: adc: add Axiado AX3000/AX3005 SARADC Petar Stepanovic
2026-06-11  9:37 ` [PATCH v2 2/2] iio: adc: add Axiado SARADC driver Petar Stepanovic
2026-06-11 10:09   ` Jonathan Cameron
2026-06-16  8:45     ` Petar Stepanovic
2026-06-11 19:41   ` Andy Shevchenko
2026-06-16  8:47     ` Petar Stepanovic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd632be7-d5e3-4568-a3a7-d9e9c75de472@axiado.com \
    --to=pstepanovic@axiado.com \
    --cc=akavi@axiado.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=hshah@axiado.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=pbolisetty@axiado.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox