From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shradha Todi <shradha.t@samsung.com>,
bhelgaas@google.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, kishon@ti.com,
vkoul@kernel.org, lpieralisi@kernel.org, kw@linux.com,
mani@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org,
alim.akhtar@samsung.com, ajaykumar.rs@samsung.com,
rcsekar@samsung.com, sriranjani.p@samsung.com,
bharat.uppal@samsung.com, s.prashar@samsung.com,
aswani.reddy@samsung.com, pankaj.dubey@samsung.com,
p.rajanbabu@samsung.com, niyas.ahmed@samsung.com,
chanho61.park@samsung.com
Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH 4/6] phy: tesla-pcie: Add PCIe PHY driver support for FSD
Date: Mon, 21 Nov 2022 13:08:27 +0100 [thread overview]
Message-ID: <dd6acba0-fa3a-1dae-b383-d70cc08dd114@linaro.org> (raw)
In-Reply-To: <20221121105210.68596-5-shradha.t@samsung.com>
On 21/11/2022 11:52, Shradha Todi wrote:
> This patch adds PHY driver support for PCIe controller
> found in Tesla FSD SoC.
>
> Signed-off-by: Niyas Ahmed S T <niyas.ahmed@samsung.com>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Shradha Todi <shradha.t@samsung.com>
> Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com>
> ---
> drivers/phy/samsung/Kconfig | 10 +
> drivers/phy/samsung/Makefile | 1 +
> drivers/phy/samsung/phy-tesla-pcie.c | 397 +++++++++++++++++++++++++++
> 3 files changed, 408 insertions(+)
> create mode 100644 drivers/phy/samsung/phy-tesla-pcie.c
>
Same comment as for PCI. It's the third driver for Samsung Exynos PCIe
PHY and every time you will say "but it is different".
No, work on unified approach not 3 different drivers.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-21 12:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221121104714epcas5p27508b91010c72117dd7116fc387b382f@epcas5p2.samsung.com>
2022-11-21 10:52 ` [PATCH 0/6] Add PCIe support for Tesla FSD SoC Shradha Todi
[not found] ` <CGME20221121104719epcas5p2f87febfba74a4ca6807b3095acf507d0@epcas5p2.samsung.com>
2022-11-21 10:52 ` [PATCH 1/6] dt-bindings: phy: Add PCIe PHY bindings for FSD Shradha Todi
2022-11-21 11:59 ` Krzysztof Kozlowski
[not found] ` <CGME20221121104725epcas5p3af00b0c717f2132f5c1ba7fd4e903e26@epcas5p3.samsung.com>
2022-11-21 10:52 ` [PATCH 2/6] dt-bindings: PCI: Add PCIe controller " Shradha Todi
2022-11-21 12:05 ` Krzysztof Kozlowski
[not found] ` <CGME20221121104731epcas5p48f96c92e5bfb4ede56ce74a78887a2f3@epcas5p4.samsung.com>
2022-11-21 10:52 ` [PATCH 3/6] PCI: dwc: fsd: Add FSD PCIe Controller driver support Shradha Todi
2022-11-21 12:07 ` Krzysztof Kozlowski
2022-11-21 23:18 ` Bjorn Helgaas
2022-11-30 18:44 ` Rob Herring
[not found] ` <CGME20221121104736epcas5p36c12ff0b575af77f8cf99811b055b339@epcas5p3.samsung.com>
2022-11-21 10:52 ` [PATCH 4/6] phy: tesla-pcie: Add PCIe PHY driver support for FSD Shradha Todi
2022-11-21 12:08 ` Krzysztof Kozlowski [this message]
[not found] ` <CGME20221121104741epcas5p31e1320bc4c0912485c1fabe52ea19988@epcas5p3.samsung.com>
2022-11-21 10:52 ` [PATCH 5/6] arm64: dts: fsd: Add PCIe support for Tesla FSD SoC Shradha Todi
2022-11-21 12:11 ` Krzysztof Kozlowski
2022-12-03 9:55 ` kernel test robot
[not found] ` <CGME20221121104746epcas5p109c7bb299cf19070a9237c00c162ed8f@epcas5p1.samsung.com>
2022-11-21 10:52 ` [PATCH 6/6] misc: pci_endpoint_test: Add driver data for FSD PCIe controllers Shradha Todi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd6acba0-fa3a-1dae-b383-d70cc08dd114@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ajaykumar.rs@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=aswani.reddy@samsung.com \
--cc=bharat.uppal@samsung.com \
--cc=bhelgaas@google.com \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=niyas.ahmed@samsung.com \
--cc=p.rajanbabu@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.prashar@samsung.com \
--cc=shradha.t@samsung.com \
--cc=sriranjani.p@samsung.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).