From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E92EC433FE for ; Mon, 21 Nov 2022 12:08:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230043AbiKUMId (ORCPT ); Mon, 21 Nov 2022 07:08:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229953AbiKUMIc (ORCPT ); Mon, 21 Nov 2022 07:08:32 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C57148754 for ; Mon, 21 Nov 2022 04:08:31 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id r8so3667163ljn.8 for ; Mon, 21 Nov 2022 04:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Mp/Wf7Ihyn7IRm224a6elGwJlmdiu5nLebRBT6EL2QY=; b=YtArTj74J8IWD8ozryoyr8jgBtCtYTisL83R4ZTuWeI4lKKYPZWjpNHRgmVCqmHEU8 p/S6DnN82lh6h9zMitXTzE6sz7RqV9bREiwkZ/AjGuyseg1VyPDdf6s0vnri41vWzwU+ 6A9shmNbl00ggyoXbkvzTVcgESEmHFSvzWc1c8/j7FdJqvoK+qwNKPa0xUBgObbJT8mI YzndDbvMZGWpeuGtPUnptnefQgoJc2iyMwCc49WAjKDtUTdtbK5JgwHX8I8kWVXN16VU hCsWQ1NPfKmjjUyVN585BSWARIbiHJBJbuypt7k2RJZDS6TNB7x6z1/SYOasdF7aaogu To1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mp/Wf7Ihyn7IRm224a6elGwJlmdiu5nLebRBT6EL2QY=; b=sXxPey/VkcRBvQfRuGBnQBWa2Gb+z99ziB5kLhFdzUyBgrduZCv6NvYHBsST28vgFk 0KJMW+lBBPX0M/bfA1gjNjrihktT3rAbPhYs10rrbI9j3znV6ih++FrzWM1+4cYux3cC TVHlMw1CCrwlLE+Ic22KRpaIrucPdi/kdIC/w6yrl5X56pZ2GswWxS+E6lIbd6f3pB0c BRujyZL/evQSZx19hrxTglucfe8HCctB6qMbYkH4EN0t9o/bBUCld3XDdATx/rq3+nPs tod/0fF9sP6QpNyLN0kbiJ96I9u6i2gyJgDNoF1/TFEu5bLMOFahTzJqM5uwuSF89iUm lIrg== X-Gm-Message-State: ANoB5pnY/AjnVr2acP1+XOXF4JdRY3JjDOamqmVvQ2gGo8ZxUDjORlb0 ejcWkIw7jjEovhhNOOBpGR3xeA== X-Google-Smtp-Source: AA0mqf7nzlJ13PlkibFVu8sbGpZadx0YW7VJA9cwKVJLyjBcjoYZRkY5LsNsaHcWs6OROfJdyXkxKw== X-Received: by 2002:a2e:a911:0:b0:277:44b2:6b9c with SMTP id j17-20020a2ea911000000b0027744b26b9cmr5272068ljq.26.1669032509403; Mon, 21 Nov 2022 04:08:29 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id h7-20020a056512220700b0049ae3ed42e8sm1992278lfu.180.2022.11.21.04.08.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 04:08:28 -0800 (PST) Message-ID: Date: Mon, 21 Nov 2022 13:08:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 4/6] phy: tesla-pcie: Add PCIe PHY driver support for FSD Content-Language: en-US To: Shradha Todi , bhelgaas@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, kishon@ti.com, vkoul@kernel.org, lpieralisi@kernel.org, kw@linux.com, mani@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, alim.akhtar@samsung.com, ajaykumar.rs@samsung.com, rcsekar@samsung.com, sriranjani.p@samsung.com, bharat.uppal@samsung.com, s.prashar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, p.rajanbabu@samsung.com, niyas.ahmed@samsung.com, chanho61.park@samsung.com Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20221121105210.68596-1-shradha.t@samsung.com> <20221121105210.68596-5-shradha.t@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20221121105210.68596-5-shradha.t@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/11/2022 11:52, Shradha Todi wrote: > This patch adds PHY driver support for PCIe controller > found in Tesla FSD SoC. > > Signed-off-by: Niyas Ahmed S T > Signed-off-by: Pankaj Dubey > Signed-off-by: Shradha Todi > Signed-off-by: Padmanabhan Rajanbabu > --- > drivers/phy/samsung/Kconfig | 10 + > drivers/phy/samsung/Makefile | 1 + > drivers/phy/samsung/phy-tesla-pcie.c | 397 +++++++++++++++++++++++++++ > 3 files changed, 408 insertions(+) > create mode 100644 drivers/phy/samsung/phy-tesla-pcie.c > Same comment as for PCI. It's the third driver for Samsung Exynos PCIe PHY and every time you will say "but it is different". No, work on unified approach not 3 different drivers. Best regards, Krzysztof