From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CDC0C6FD1D for ; Tue, 4 Apr 2023 06:18:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233397AbjDDGSO (ORCPT ); Tue, 4 Apr 2023 02:18:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233413AbjDDGSN (ORCPT ); Tue, 4 Apr 2023 02:18:13 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 534F530FD for ; Mon, 3 Apr 2023 23:17:44 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id i5so126341990eda.0 for ; Mon, 03 Apr 2023 23:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680589062; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iDjaU2rar9tWF1A9zRNafmNtWp0F/aW8MT9UYDo8+8s=; b=ER/Gjr8X3DKa1om2wxA8O4xQ/E+zMFEI/9rl+Lx047ZntTFt4fEiUvmpOwEs6vQWTD 3P9RIpT0v1Od8EmCfSbASaXuWCKTWn0m6XN/nGaABvumC0ywdZn6Bj0PAfh3tL+cDCz2 RXMnBE7s2gbQF9r+89T4JsG/JO2b9SIoQBdwFsIotIaa+ArG7i2+07TLJ9aN6Wcn10e+ BwP07mCUULfB7dJEH3o2Nu6WdrXboJE/vtJxSOYt41cXSaRU5yd6WAAIdZiH5h/mo2Ow P2YU7V/EVlsY4xzOjcYhXMyymt1t1hngBK+2K1dZwylyAxa6xH7TqhihGUx4841mXHiv /FRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680589062; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iDjaU2rar9tWF1A9zRNafmNtWp0F/aW8MT9UYDo8+8s=; b=TLadZMac9LHM2dTplMEmPKnbetVrta2mqvmBV6DZJE++/ylogpwwdO7IMKoAJyw+Tk G7eszIdJeqmAVb/oUHmaevz/isQztw9dfp2jjXARw3Eelyu6RHGXoVDlHv3qLV2I7VNz ufLGtRDoOX9LoxSUVWja47MOZzwd6EvdI/KNNFBXXJY7eiBrZohhNqtJlFQ5uF2F+eJC +WH1VCPUJsGFXLrLbJaxgDMTqGQkPnS9fFTaGycIkobgHP8RHaqQh5sWF2zia4vDF+EC 6N4kLB9Rl7Dpnp/UyTyndenUEg0dmeWVr5IuujWaw6Vm1Tv+lyuuyfwoO9uFJZOh21Cn RxVg== X-Gm-Message-State: AAQBX9fWOunZTPYkndbQhwn9q0sPcs0GR/2d6kTGmtQhnl+Bc3l9+lGw RzWNwTW95U8z+XmRQYbxrsQ5Hg== X-Google-Smtp-Source: AKy350acMPUvg8FQaSMcxpUkt8euvDaA6UhTGNL2AIK9rmdVQWP6apDq0xztamPFlkojeWn2icK9vQ== X-Received: by 2002:a17:906:668c:b0:924:7f98:7c55 with SMTP id z12-20020a170906668c00b009247f987c55mr1131637ejo.48.1680589062126; Mon, 03 Apr 2023 23:17:42 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:233a:5c18:b527:381e? ([2a02:810d:15c0:828:233a:5c18:b527:381e]) by smtp.gmail.com with ESMTPSA id i12-20020a170906a28c00b00946e6dd887csm5414775ejz.126.2023.04.03.23.17.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 23:17:41 -0700 (PDT) Message-ID: Date: Tue, 4 Apr 2023 08:17:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs Content-Language: en-US To: Ibrahim Tilki , a.zummo@towertech.it, alexandre.belloni@bootlin.com, jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, Zeynep Arslanbenzer References: <20230403154342.3108-1-Ibrahim.Tilki@analog.com> <20230403154342.3108-3-Ibrahim.Tilki@analog.com> From: Krzysztof Kozlowski In-Reply-To: <20230403154342.3108-3-Ibrahim.Tilki@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/04/2023 17:43, Ibrahim Tilki wrote: > Devicetree binding documentation for Analog Devices MAX313XX RTCs > > Signed-off-by: Ibrahim Tilki > Signed-off-by: Zeynep Arslanbenzer > --- > .../devicetree/bindings/rtc/adi,max313xx.yaml | 144 ++++++++++++++++++ > 1 file changed, 144 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/adi,max313xx.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml > new file mode 100644 > index 000000000..0c17a395e > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml > @@ -0,0 +1,144 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2022 Analog Devices Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/adi,max313xx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices MAX313XX series I2C RTCs > + > +maintainers: > + - Ibrahim Tilki > + - Zeynep Arslanbenzer > + > +description: Analog Devices MAX313XX series I2C RTCs. > + > +properties: > + compatible: > + enum: > + - adi,max31328 > + - adi,max31329 > + - adi,max31331 > + - adi,max31334 > + - adi,max31341 > + - adi,max31342 > + - adi,max31343 > + > + reg: > + description: I2C address of the RTC > + items: > + - enum: [0x68, 0x69] > + > + interrupts: > + description: | Do not need '|'. > + Alarm1 interrupt line of the RTC. Some of the RTCs have two interrupt > + lines and alarm1 interrupt muxing depends on the clockin/clockout > + configuration. > + maxItems: 1 > + > + "#clock-cells": > + description: | Do not need '|'. > + RTC can be used as a clock source through its clock output pin when > + supplied. > + const: 0 > + > + clocks: > + description: | Do not need '|'. > + RTC uses this clock for clock input when supplied. Clock has to provide > + one of these four frequencies: 1Hz, 50Hz, 60Hz or 32.768kHz. > + maxItems: 1 > + > + aux-voltage-chargeable: > + enum: [0, 1, 2] > + description: | > + Enables trickle charger. > + 0: Charger is disabled (default) > + 1: Charger is enabled > + 2: Charger is enabled with a diode 2 is not an allowed value. I asked to drop this property. It is coming from rtc.yaml. I also do not understand "with a diode". So otherwise it is charging with, I don't know, FET? > + > + trickle-resistor-ohms: > + description: Selected resistor for trickle charger. > + enum: [3000, 6000, 11000] > + > +required: > + - compatible > + - reg > + Best regards, Krzysztof