From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dinh Nguyen <dinguyen@kernel.org>, jh80.chung@samsung.com
Cc: ulf.hansson@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCHv4 1/3] dt-bindings: mmc: synopsys-dw-mshc: document "altr,sysmgr-syscon"
Date: Thu, 29 Sep 2022 08:49:51 +0200 [thread overview]
Message-ID: <dd887ce0-df72-2818-ecaf-1fcdcc0dfb42@linaro.org> (raw)
In-Reply-To: <02967018-8a04-bd82-49e6-1ee475916ebb@kernel.org>
On 28/09/2022 20:37, Dinh Nguyen wrote:
> Hi,
>
> On 9/28/22 12:15, Krzysztof Kozlowski wrote:
>> On 28/09/2022 18:54, Dinh Nguyen wrote:
>>> Document the optional "altr,sysmgr-syscon" binding that is used to
>>> access the System Manager register that controls the SDMMC clock
>>> phase.
>>>
>>> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
>>> ---
>>
>> Thank you for your patch. There is something to discuss/improve.
>>
>>> +
>>> +allOf:
>>> + - $ref: "synopsys-dw-mshc-common.yaml#"
>>> +
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const:
>>> + - altr,socfpga-dw-mshc
>>
>> It still should not be an array, even if there is no warning.
>>
>
> I apologize, but I'm confused with the message. Do you mean it should
> not be a "const"?
No, it should not be a const. Open any other schema and check how const
is done there.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-29 6:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 16:54 [PATCHv4 1/3] dt-bindings: mmc: synopsys-dw-mshc: document "altr,sysmgr-syscon" Dinh Nguyen
2022-09-28 16:54 ` [PATCHv4 2/3] arm64: dts: socfpga: Add clk-phase-sd-hs property to the sdmmc node Dinh Nguyen
2022-09-28 16:54 ` [PATCHv4 3/3] mmc: dw_mmc-pltfm: socfpga: add method to configure clk-phase Dinh Nguyen
2022-09-29 11:20 ` Ulf Hansson
2022-09-28 17:15 ` [PATCHv4 1/3] dt-bindings: mmc: synopsys-dw-mshc: document "altr,sysmgr-syscon" Krzysztof Kozlowski
2022-09-28 18:37 ` Dinh Nguyen
2022-09-29 6:49 ` Krzysztof Kozlowski [this message]
2022-09-28 22:37 ` Rob Herring
2022-09-29 9:24 ` Ulf Hansson
2022-09-29 9:38 ` Krzysztof Kozlowski
2022-09-29 11:04 ` Ulf Hansson
2022-09-29 11:13 ` Krzysztof Kozlowski
2022-09-29 14:20 ` Dinh Nguyen
2022-09-29 14:38 ` Krzysztof Kozlowski
2022-09-29 15:18 ` Dinh Nguyen
2022-10-01 10:06 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd887ce0-df72-2818-ecaf-1fcdcc0dfb42@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).