From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 053B214A4E2; Wed, 16 Oct 2024 14:49:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729090150; cv=none; b=fk25z8kpq1upflF6OBvqQ0rLSj310gvZxwm+vZGMtIruVrWu/sl3P8REhbpouzc089XxXqqB2bT/dgT/KanSYMqg/r0ux7e1X4XDd3Jc6SZQ7ER8kE/Vrekzu9IwuBul7lvz+mfH1a1RAA/mE/po2a/gY5cD/41U36N/gdNKFwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729090150; c=relaxed/simple; bh=CVh4kVqJP96yDVDboc5wGXuEQ3NbJsRI1MWw3xjjsNM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bCn9NcU+6j64PeZexRLv//Ss8YKQ9DyVebrKVad9BlL4Htx7Cn5yV0QegUxFiQqaDTeQi9FG5pBhIaOemndfmXX4qzfPgRIP3WZA34ilS8Hik2G117PyILe5vDCY+a0yZNTtF//EMqukyfj+QUEjLroLUauTCBgLmIpfR/yXv0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iCN2Ct1z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iCN2Ct1z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAA77C4CEC7; Wed, 16 Oct 2024 14:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729090149; bh=CVh4kVqJP96yDVDboc5wGXuEQ3NbJsRI1MWw3xjjsNM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iCN2Ct1zxdMavGiVcAM7Mctxc+bm6snRZj7cClFFHuktPxyfvTIoJT2lAnYYF4PNp p2Q2s9VsHHqRntoiCVEndCNAV0shVYCDTGtF2iuv/44aHHt5PClX5BaKA8CBB642Kt L6uROtNaJdo4nYfiNW4PaVJ7cMCOss7vyNwnJuil8Hc+QUln7NrEfEDtQi7tkkFOtF EUUmxkmW+Xh+E0QrRj41tPxir+vk4LatGGa8EVVn+p7ZBLQGWmM+fetXUwho5gmSAB 2pl9rAzq50P3c+MKozfwUZWDyudcljvmnI/FC0/7MQnhSwwz2x3r5mpvxI/mbS5xTJ yWG4NVfsl3TEw== Message-ID: Date: Wed, 16 Oct 2024 16:49:02 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] Add Exynos990 pinctrl and chipid drivers To: Igor Belwon Cc: alim.akhtar@samsung.com, conor+dt@kernel.org, devicetree@vger.kernel.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, robh@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com References: <795657e1-5232-494c-9ac5-a62455b0f6f9@kernel.org> <20241016144112.17588-1-igor.belwon@mentallysanemainliners.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20241016144112.17588-1-igor.belwon@mentallysanemainliners.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/10/2024 16:41, Igor Belwon wrote: > On Wed, 16 Oct 2024 09:19:58 +0200, Krzysztof Kozlowski wrote: >> On 16/10/2024 09:06, Krzysztof Kozlowski wrote: >>> On Tue, Oct 15, 2024 at 11:04:45PM +0200, Igor Belwon wrote: >>>> Hi folks, >>>> >>>> This series adds support for the drivers for the Exynos 990 SoC. It >>>> consists of the pinctrl driver and the chipid driver. The product ID >>>> of this chip for chipid is 0xe9830000. The pinctrl bank types are the >>>> same as in the Exynos 850 chip. >>>> >>>> Changes in v2: >>>> - Moved bindings from SoC bringup commit >>>> - Moved device tree changes from SoC bringup commit >>>> - Ordered pinctrl nodes by unit address in SoC DT >>>> - Moved the exynos990-wakeup-eint binding to the correct if. >>> >> Moved? That's not what I asked for. Are you sure you have this warning >> free? That's a requirement for Samsung (see maintainer profile). >> >> Ah, I see now what you did - you removed the interrupt. That's >> surprising. I don't understand why. > > Hi Krzysztof, > > Thank you for the review. > The interrupt was actually my oversight. This SoCs pin controller does > not mux interrupts (much like E850 and Tensor). It's still compatible > with the Exynos7 model as a fallback though. OK, if this was conscious decision then looks fine. Mention this shortly in respective commit msg and split the patchset so only pinctrl bits are here. Thanks for the work! Best regards, Krzysztof