From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C49BCA0FFB for ; Tue, 5 Sep 2023 16:24:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350273AbjIEQYf (ORCPT ); Tue, 5 Sep 2023 12:24:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354290AbjIEKgI (ORCPT ); Tue, 5 Sep 2023 06:36:08 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D3B21AB for ; Tue, 5 Sep 2023 03:36:04 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50079d148aeso3896885e87.3 for ; Tue, 05 Sep 2023 03:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693910162; x=1694514962; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/U9siKDyazHDG6r3zqTARi8NY0BAa80rOt591lmpFyA=; b=aJmXjS1jCiGy32CzRTnfQyuYXlBEDVVB5skg8kPQ+KA/i/5aGEHvWGhr9QfcMzHod/ I8BrAViAFIuRAlWgvrC+Dde32wkYsIG1vuIg3ONE+fqZaNAXsb/wv0ebaqguSZk61qEH 0EUuOjRz8VkP/LDjhKwzHzrdkyhZMqs8S2Tn1I/8YQjf7Ef41wKF5qPs+/bdT78Rx+Ow gCSxei3n0dd8maqFRcdUhq5CRC9/qaOgR7EOgP4ihLX4xRAg9RPgQAdXFi/cdIdhupNf 7wX5WJcxLLv1UpkddUXO7Nlj8W+llgLBPmyRCUFL4+XvDKrUFXprnbckJQFKQ+/wUXDW TkmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693910162; x=1694514962; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/U9siKDyazHDG6r3zqTARi8NY0BAa80rOt591lmpFyA=; b=OY4E51vtGyEdpG/W0ttYrIbGuqrjuywPnrOMyxs1ZoG09dgc/zsBzhRNLFKCrPrm+y 1cY8Di1xN243q8qCmadH2e30J01n81HDa9/Rxruq77v6KwgsVPiuc0zYIW8jhds1k4fc Qm2TorQHHMucVil9VeP1KX9TSZ8sLJibOTMpMJa+HI9Ydn9RgCG3AcgpItV2eLapyWdD 62R12N56X+JU4nHkj3DlpHvD70KxE/H8aUZeNxMFX3qRWrRxEoBAl6BPi8LkEcUQfF6x S+ADIdhigqf5LP5Y3NhLc2iF6diKmMAd2/Vs706n+LaxQ5x9jx+qPnmJWpf8LrIZqS2r QkGw== X-Gm-Message-State: AOJu0YwjqGCKL4Yr/B932RMPxIaUEDcw/bGrMwLFL8Q8o40NCbdJ8CXF BajgOdgXRI7suVfkL8RN4hLZFg== X-Google-Smtp-Source: AGHT+IEEwILeUUAxmLD1NfgpOLlzLDQpUZMD+JAAHfLvTOal4CKjljt/zxapSOY7fQ7wrcKXF88iDA== X-Received: by 2002:a05:6512:3087:b0:500:9a45:62f with SMTP id z7-20020a056512308700b005009a45062fmr10157967lfd.8.1693910162221; Tue, 05 Sep 2023 03:36:02 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id f8-20020a1709067f8800b009a1a5a7ebacsm7282198ejr.201.2023.09.05.03.36.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 03:36:01 -0700 (PDT) Message-ID: Date: Tue, 5 Sep 2023 12:36:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 1/2] dt-bindings: arm64: dts: mediatek: Add mt8395-evk board To: Macpaul Lin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , =?UTF-8?Q?Bernhard_Rosenkr=c3=a4nzer?= , Sean Wang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: Bear Wang , Pablo Sun , Macpaul Lin , Chunfeng Yun References: <20230904092043.5157-1-macpaul.lin@mediatek.com> <00f0a1cf-6246-92e9-13b0-cf31bb292a94@mediatek.com> <97b82a16-8710-9430-35c8-673381aaa417@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/09/2023 11:36, Macpaul Lin wrote: > > > On 9/4/23 20:11, Krzysztof Kozlowski wrote: >> >> >> External email : Please do not click links or open attachments until you >> have verified the sender or the content. >> >> On 04/09/2023 11:50, Macpaul Lin wrote: >>> >>> >>> On 9/4/23 17:33, Krzysztof Kozlowski wrote: >>>> >>>> >>>> External email : Please do not click links or open attachments until you >>>> have verified the sender or the content. >>>> >>>> On 04/09/2023 11:20, Macpaul Lin wrote: >>>>> Add bindings for the MediaTek mt8395-evk board. >>>>> The mt8359-evk board is also named as "Genio 1200-EVK". >>>>> MT8195 and MT8395 are the same family series SoC could share >>>> >>>> How can be the same and have different numbers? You sill need dedicated >>>> compatible. >>>> >>> >>> The SoCs mt8195 and mt8395 are designed for different market application >>> and physical characteristics, using different efuse values for >>> distinction. The booting flow and configurations are controllered by the >>> boot loaders, firmware, and TF-A. Therefore, the part numbers and >>> procurement channels are different. The detail information of these >>> efuse values is proprietary, so I cant disclose it futher. Hence the >>> most of peripheral drivers and base address are almost the same. >> >> 1. Drivers? So we talk about compatibility, not the same. >> 2. "almost the same" is not the same. Follow the guidelines for writing >> bindings. >> > > Thanks for the review. > > After internal confirmation and discussion, it can be confirmed that the > MT8195 and MT8395 are identical SoCs from to binding's perspective. I am sorry, but I really do not care what you internally discussed about bindings. I do not think your internal review respect existing guidelines. You talked about drivers, not "bindings perspective", so your internal discussion is clearly discussing something else. > MediaTek hope the mt8395 boards could directly use mt8195.dtsi, without > the need to create a separate mt8395.dtsi to include mt8195.dtsi. > Therefore, we hope to fully adopt the bindings of mt8195. However, I > will submit a revised patch for compatible since they are different boards. You can disagree but then I expect arguments from your side. Best regards, Krzysztof