From: Philipp Zabel <p.zabel@pengutronix.de>
To: Richard Zhu <hongxing.zhu@nxp.com>,
l.stach@pengutronix.de, bhelgaas@google.com,
lorenzo.pieralisi@arm.com, robh@kernel.org, shawnguo@kernel.org,
vkoul@kernel.org, alexander.stein@ew.tq-group.com, marex@denx.de
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-imx@nxp.com
Subject: Re: [PATCH v3 1/6] reset: imx7: Add the iMX8MP PCIe PHY PERST support
Date: Thu, 18 Aug 2022 10:50:53 +0200 [thread overview]
Message-ID: <ddbcd90419e9bb4ce7c5b7b3055ee3227c179321.camel@pengutronix.de> (raw)
In-Reply-To: <1660806153-29001-2-git-send-email-hongxing.zhu@nxp.com>
Hi Richard,
On Do, 2022-08-18 at 15:02 +0800, Richard Zhu wrote:
> On i.MX7/iMX8MM/iMX8MQ, the initialized default value of PERST bit(BIT3)
> of SRC_PCIEPHY_RCR is 1b'1.
> But i.MX8MP has one inversed default value 1b'0 of PERST bit.
>
> And the PERST bit should be kept 1b'1 after power and clocks are stable.
> So add the i.MX8MP PCIe PHY PERST support here.
the description is good now. It would be nice if this could also be
mentioned in the Reference Manual.
Please replace "add" with "fix" in the subject, as I requested earlier:
"reset: imx7: Fix i.MX8MP PCIe PHY PERST support".
And add a fixes line:
Fixes: e08672c03981 ("reset: imx7: Add support for i.MX8MP SoC")
With those two changes,
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
next prev parent reply other threads:[~2022-08-18 8:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 7:02 [PATCH v3 0/6] Add the iMX8MP PCIe support Richard Zhu
2022-08-18 7:02 ` [PATCH v3 1/6] reset: imx7: Add the iMX8MP PCIe PHY PERST support Richard Zhu
2022-08-18 8:50 ` Philipp Zabel [this message]
2022-08-18 10:53 ` Hongxing Zhu
2022-08-29 8:10 ` Lorenzo Pieralisi
2022-08-29 8:14 ` Hongxing Zhu
2022-08-18 7:02 ` [PATCH v3 2/6] dt-binding: phy: Add iMX8MP PCIe PHY binding Richard Zhu
2022-08-22 18:07 ` Rob Herring
2022-08-23 2:11 ` Hongxing Zhu
2022-08-24 9:15 ` Hongxing Zhu
2022-08-18 7:02 ` [PATCH v3 3/6] phy: freescale: imx8m-pcie: Add iMX8MP PCIe PHY support Richard Zhu
2022-08-18 7:02 ` [PATCH v3 4/6] arm64: dts: imx8mp: add the iMX8MP PCIe support Richard Zhu
2022-08-18 7:02 ` [PATCH v3 5/6] arm64: dts: imx8mp-evk: Add " Richard Zhu
2022-08-18 7:02 ` [PATCH v3 6/6] PCI: imx6: Add the iMX8MP " Richard Zhu
2022-08-18 9:20 ` [PATCH v3 0/6] " Marek Vasut
2022-08-18 10:53 ` Hongxing Zhu
2022-08-18 11:49 ` Marek Vasut
2022-08-25 12:23 ` Richard Leitner
2022-08-26 1:29 ` Hongxing Zhu
2022-08-26 6:22 ` Alexander Stein
2022-08-26 6:56 ` Hongxing Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddbcd90419e9bb4ce7c5b7b3055ee3227c179321.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=alexander.stein@ew.tq-group.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marex@denx.de \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).