Devicetree
 help / color / mirror / Atom feed
From: Stefan Wahren <wahrenst@gmx.net>
To: Gregor Herburger <gregor.herburger@linutronix.de>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Peter Robinson <pbrobinson@gmail.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible
Date: Wed, 5 Aug 2026 13:55:50 +0200	[thread overview]
Message-ID: <ddcb0d9a-2dd4-4808-84db-caf6ea64b48e@gmx.net> (raw)
In-Reply-To: <vv6ufnanks27moditlav2ebaub6m5te5tag3m6qv5l65cm25iw@i7m54od3wz4k>

Hi Gregor,

drop Eric and add Peter.

Am 05.08.26 um 09:27 schrieb Gregor Herburger:
> On Tue, Aug 04, 2026 at 04:57:09PM +0200, Stefan Wahren wrote:
>> Hi Gregor,
>>
>> sorry for my late reply.
>>
>> Am 04.08.26 um 15:13 schrieb Gregor Herburger:
>>> The bcm2712 found on the Raspberry Pi 5 is available in the d Stepping
>>> and in a c Stepping. There are two separate dts files. The
>>> bcm2712-rpi-5-b.dts for the c Stepping and the bcm2712-d-rpi-5-b.dts for
>>> the d Stepping. The d stepping does not set its own compatible/model
>>> string but uses "raspberrypi,5-model-b".
>> In case the SoC and not the board has a D stepping, why do just change the
>> board compatible without the SoC compatible like "brcm,bcm2712-d0"?
> You mean changing both compatible strings? Like this:
> 	compatible = "raspberrypi,5-model-b-d0", "brcm,bcm2712-d0";
I just want to mention that your explanation doesn't match to your 
changes. The first compatible represent the whole board (RPi 5) and the 
second one represent only the SoC (BCM2712). Since the SoC is different 
according your explanation, i would expect the SoC compatible needs to 
be changed. And in case the SoC changes, also the board won't be 
compatible anymore, correct?

Usually we try to avoid to model different SoC steppings in the device 
tree, because this introduce a lot of redundancy. But it seems that the 
differences are signifcant here.

In case this suggestion break something, this needs further explanation 
in the patch.

Best regards

  reply	other threads:[~2026-08-05 11:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 13:13 [PATCH v3 0/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible Gregor Herburger
2026-08-04 13:13 ` [PATCH v3 1/2] dt-bindings: arm: bcm2835: Add Raspberry Pi 5 d0 Stepping Gregor Herburger
2026-08-04 13:13 ` [PATCH v3 2/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible Gregor Herburger
2026-08-04 14:57   ` Stefan Wahren
2026-08-05  7:27     ` Gregor Herburger
2026-08-05 11:55       ` Stefan Wahren [this message]
2026-08-05 12:52         ` Gregor Herburger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddcb0d9a-2dd4-4808-84db-caf6ea64b48e@gmx.net \
    --to=wahrenst@gmx.net \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=gregor.herburger@linutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=pbrobinson@gmail.com \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox