From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80773C47088 for ; Thu, 1 Dec 2022 16:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229728AbiLAQwt (ORCPT ); Thu, 1 Dec 2022 11:52:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbiLAQwn (ORCPT ); Thu, 1 Dec 2022 11:52:43 -0500 Received: from gateway32.websitewelcome.com (gateway32.websitewelcome.com [192.185.145.114]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9A8812AC6 for ; Thu, 1 Dec 2022 08:52:41 -0800 (PST) Received: from atl1wswcm04.websitewelcome.com (unknown [50.6.129.165]) by atl3wswob03.websitewelcome.com (Postfix) with ESMTP id 9CDEA5B95 for ; Thu, 1 Dec 2022 16:52:40 +0000 (UTC) Received: from md-in-79.webhostbox.net ([43.225.55.182]) by cmsmtp with ESMTP id 0mndpq8hDgEOM0mnfpqw18; Thu, 01 Dec 2022 16:52:40 +0000 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linumiz.com ; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oQj/HJTvdxrVt+zk2ySQjAT2Bd8kLr9eRU+0wbh0SyY=; b=KfZAL9PccHg35tGQV5H19QvMOp 0mHs2MiMY6EmiEBcaAgtIV79bHtAAitMPipkUwaf77mIG3gaJyWDkrbQIeOof7orF9rEegDuNGYP7 eBaA86RKRTssD0Vjv56GuKiVub8j+0M1JR+ON0BQ1eJ/pyKIM6AGeTnaxgOnOkw4Z00MheCZyBcJF jLSo62221IPO0aSh2eWh+aiWPPaWGEdYpY8x/UoPFpCORKovh8BY0QshN2xbc52ZdLFQfT1F1DYnH c0/TomvO3So5AzQ3LWfWxFvLl3lWTWVO1D9QNfIdzWFm4rPBMcZ1BfqDeWMJvoWtouHHWYZCDgngZ tnusNc0Q==; Received: from [106.197.183.239] (port=44685 helo=[192.168.221.42]) by md-in-79.webhostbox.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p0mnc-003un4-Oq; Thu, 01 Dec 2022 16:52:36 +0000 Message-ID: Date: Thu, 1 Dec 2022 17:52:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 2/4] dt-bindings: hwmon/pmbus: Add mps,mpq7932 power-management IC To: Krzysztof Kozlowski , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marten.lindahl@axis.com, jdelvare@suse.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20221201044643.1150870-1-saravanan@linumiz.com> <20221201044643.1150870-3-saravanan@linumiz.com> <29de4d2b-3e32-809e-6ccd-5e7a4fe548fc@linaro.org> <785e942a-0691-f87e-b6e9-058749a79ec1@linaro.org> <8228db8d-2a32-1d23-74f3-05b9fe529a82@linumiz.com> Content-Language: en-US From: Saravanan Sekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - md-in-79.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - linumiz.com X-BWhitelist: no X-Source-IP: 106.197.183.239 X-Source-L: No X-Exim-ID: 1p0mnc-003un4-Oq X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.221.42]) [106.197.183.239]:44685 X-Source-Auth: saravanan@linumiz.com X-Email-Count: 15 X-Source-Cap: bGludW1jbWM7aG9zdGdhdG9yO21kLWluLTc5LndlYmhvc3Rib3gubmV0 X-Local-Domain: yes X-CMAE-Envelope: MS4xfJ/AQdALUs0Qz4eVbdQjsAAtWuvje9InjuH4s5sJ6vMWCkCtwjs60aXPPczeqhh5OuPap4L5I1OWoXO17tHPnfFaILmQxkxQGj+gi/3dpMbyQ3tOBLKi s16JvkGXqmQ4I6p7cStFIwsSveZjyLy52zEoETlpkqzqUL1UzlMyyCrvQYnkxFYzixY1r93uDm8qwWrJ8/EbcnaAVgm7sP+7J+s= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/12/22 17:43, Krzysztof Kozlowski wrote: > On 01/12/2022 17:38, Saravanan Sekar wrote: >>>>> Plus additional comment for the driver (and related to bindings) was >>>>> that this is not hwmon but a regulator driver. Why putting regulator >>>>> driver in hwmon? >>>>> >>>> >>>> Turns out this is primarily a hardware monitoring driver, like the drivers >>>> for all other PMBus chips. Regulator support is actually optional; the driver >>>> works perfectly well with CONFIG_REGULATOR=n (except that it needs some >>>> #ifdefs to address that situation). >>> >>> OK, this would explain location of the driver. However the bindings are >>> saying: >>> "Monolithic Power System MPQ7932 PMIC" >>> and PMIC is not mainly a hwmon device, even if it has such capabilities. >>> It might be missing description and proper title... or might be misplaced. >>> >> >> Indeed it is PMIC chip. I think this is not the first and not sure title >> has to be changed for hwmon subsystem. >> >> bindings/hwmon/pmbus/ti,lm25066.yaml >> title: National Semiconductor/Texas Instruments LM250x6/LM506x >> power-management ICs > > Then I propose to put it in regulator directory. > Just for clarification, should bindings put in regulator directory? Thanks, Saravanan