From: Krzysztof Kozlowski <krzk@kernel.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Maxim Schwalm <maxim.schwalm@gmail.com>,
Brad Griffis <bgriffis@nvidia.com>,
Dara Stotland <dstotland@nvidia.com>,
David Heidelberg <david@ixit.cz>, Ion Agorria <ion@agorria.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] ARM: tegra: Add device-tree for ASUS Transformer Pad LTE TF300TL
Date: Mon, 17 Mar 2025 16:03:50 +0100 [thread overview]
Message-ID: <dde3fd48-f5ac-4c82-aff3-8dae255d4cd2@kernel.org> (raw)
In-Reply-To: <CAPVz0n3o2=6cXh81CwqzASEcz9AbBmaMeU94V4xAyGdzKcUoVQ@mail.gmail.com>
On 17/03/2025 12:19, Svyatoslav Ryhel wrote:
> пн, 17 бер. 2025 р. о 13:04 Krzysztof Kozlowski <krzk@kernel.org> пише:
>>
>> On Sat, Mar 15, 2025 at 09:44:16AM +0200, Svyatoslav Ryhel wrote:
>>> +#include "tegra30-asus-transformer-common.dtsi"
>>> +#include "tegra30-asus-lvds-display.dtsi"
>>> +
>>> +/ {
>>> + model = "Asus Transformer Pad LTE TF300TL";
>>> + compatible = "asus,tf300tl", "nvidia,tegra30";
>>> +
>>> + gpio@6000d000 {
>>> + tf300tl-init-hog {
>>> + gpio-hog;
>>> + gpios = <TEGRA_GPIO(C, 6) GPIO_ACTIVE_HIGH>;
>>> + output-low;
>>> + };
>>> + };
>>> +
>>> + pinmux@70000868 {
>>> + state_default: pinmux {
>>> + lcd_pwr2_pc6 {
>>
>> No underscores in node names.
>>
>
> These bindings overwrite bindings in the common pinmux configuration
> which has names with underscores, so underscores are needed for
> correct configuration.
Ack, this Tegra coding style will make big even such trivial fixup...
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-17 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-15 7:44 [PATCH v1 0/2] ARM: tegra: Add device-tree for ASUS Transformer Pad LTE TF300TL Svyatoslav Ryhel
2025-03-15 7:44 ` [PATCH v1 1/2] dt-bindings: arm: tegra: Add Asus Transformer Pad TF300TL Svyatoslav Ryhel
2025-03-17 11:03 ` Krzysztof Kozlowski
2025-03-15 7:44 ` [PATCH v1 2/2] ARM: tegra: Add device-tree for ASUS Transformer Pad LTE TF300TL Svyatoslav Ryhel
2025-03-17 11:04 ` Krzysztof Kozlowski
2025-03-17 11:19 ` Svyatoslav Ryhel
2025-03-17 15:03 ` Krzysztof Kozlowski [this message]
2025-03-17 14:18 ` [PATCH v1 0/2] " Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dde3fd48-f5ac-4c82-aff3-8dae255d4cd2@kernel.org \
--to=krzk@kernel.org \
--cc=bgriffis@nvidia.com \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dstotland@nvidia.com \
--cc=ion@agorria.com \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maxim.schwalm@gmail.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).