From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77888C433FE for ; Wed, 13 Apr 2022 09:45:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231493AbiDMJrS (ORCPT ); Wed, 13 Apr 2022 05:47:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234695AbiDMJrE (ORCPT ); Wed, 13 Apr 2022 05:47:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0D0B33BA58 for ; Wed, 13 Apr 2022 02:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649843078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=foBzhikXuCLjtC6Ari8RZkx+1wS4aS+fCUlhb35KDqw=; b=Hf4WPju10aDAb66s2Oc1qy0BqI77Gr5qouUqoorPrI5aXXhkrtXDGRI708J50tG4A4+QK+ IGxbD5H8SrN7pxonv3gCek/y+o4WfshjM837diJx61k5M8ZBrJRX0bHRCpMsoFIQS2l539 okFWW4129fW/TmYILB3ba7K9Izzcids= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-616-MVwXluv9MCWxloTrpw7AIA-1; Wed, 13 Apr 2022 05:44:37 -0400 X-MC-Unique: MVwXluv9MCWxloTrpw7AIA-1 Received: by mail-wm1-f70.google.com with SMTP id q25-20020a1ce919000000b0038ead791083so609141wmc.6 for ; Wed, 13 Apr 2022 02:44:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=foBzhikXuCLjtC6Ari8RZkx+1wS4aS+fCUlhb35KDqw=; b=cKxNG43WxoQcu0BPOEi2HJ3Ot6aDnC3npFbs+LGSiMSlDgWtObS7cb6dvKR/fyD2Ou o/GchEmpEFvehSd8FK9e9bcOq6RhvoggI9gn1Il2Ep9ztWcfrhKCMc7trFqfb7qNHphb t3c1i0BCNiS73MoTuDO+mS7XY6JVBamDAWzyRSKjTBf9w52/9okxIQNCsIVSZhLuiXFN CsvPVd3/5nnkPNVk8x2HC3b4IunQ2XQiiyQVNK1aEr79K/8iNNLigmhJtZAlsYBnysa2 oQmoIy4kBz3Nxh8G5NiGBOj2H+aCE/7v2921+ZRMHA/K7AqfmE4ZauCwrk3jatJhIi+S Cn2Q== X-Gm-Message-State: AOAM532FY1gm5pldvTrQFrNPdd6zfRq8u/ikXTeVa/sKKvb7DgW+wPyW dChHZG1Uo+Gg8FFJoHJvfwX725OKfhfjaCbn/ZABW+Wo6FmX6WNjTWhJLHyiLfrTLsb4H6MPMVN 0n73YZIqfRRnpQkCn7CzcZg== X-Received: by 2002:a05:600c:3ca4:b0:38e:54d0:406d with SMTP id bg36-20020a05600c3ca400b0038e54d0406dmr7706528wmb.199.1649843076507; Wed, 13 Apr 2022 02:44:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0HXRzJbUNXpEFfAtNGvrG9B9JzK/eHK2ZSXSccHuCPbF3oaO1WosnYsBkWkBzF47eXcT4NQ== X-Received: by 2002:a05:600c:3ca4:b0:38e:54d0:406d with SMTP id bg36-20020a05600c3ca400b0038e54d0406dmr7706513wmb.199.1649843076247; Wed, 13 Apr 2022 02:44:36 -0700 (PDT) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id o10-20020a5d47ca000000b00203fb25165esm37150569wrc.6.2022.04.13.02.44.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Apr 2022 02:44:35 -0700 (PDT) Message-ID: Date: Wed, 13 Apr 2022 11:44:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers Content-Language: en-US To: Geert Uytterhoeven Cc: Linux Kernel Mailing List , Neil Armstrong , Rob Herring , Andy Shevchenko , DRI Development , Mark Brown , Chen-Yu Tsai , Geert Uytterhoeven , Daniel Vetter , David Airlie , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20220412162729.184783-1-javierm@redhat.com> <20220412162729.184783-3-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello Geert, On 4/13/22 10:04, Geert Uytterhoeven wrote: > Hi Javier, > > On Tue, Apr 12, 2022 at 6:27 PM Javier Martinez Canillas > wrote: >> The Solomon SSD130x OLED displays can either have an I2C or SPI interface, >> add to the schema the properties and examples for OLED devices under SPI. >> >> Signed-off-by: Javier Martinez Canillas >> Acked-by: Mark Brown >> Reviewed-by: Geert Uytterhoeven >> --- >> >> Changes in v3: >> - Add a comment to the properties required for SPI (Geert Uytterhoeven) > > Thanks for the update! > >> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml >> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml >> @@ -38,9 +38,16 @@ properties: >> reset-gpios: >> maxItems: 1 >> >> + # Only required for SPI >> + dc-gpios: >> + maxItems: 1 > > Actually I meant to also add a description, like for vbat-supply below, > to explain the meaning of "dc". > Ahh, sorry for misunderstanding you! Something like the following looks good ? # Only required for SPI dc-gpios: description: GPIO connected to the controller's D/C# (Data/Command) pin, that is needed for 4-wire SPI to tell the controller if the data sent is for a command register or the display data RAM maxItems: 1 If you agree with that, then can squash before pushing or add it to a v4 if another revision is needed. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat