From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kamel Bouhara <kamel.bouhara@bootlin.com>
Cc: Conor Dooley <conor@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Marco Felsch <m.felsch@pengutronix.de>,
Jeff LaBundy <jeff@labundy.com>,
catalin.popescu@leica-geosystems.com,
mark.satterthwaite@touchnetix.com, bartp@baasheep.co.uk,
hannah.rossiter@touchnetix.com,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Gregory Clement <gregory.clement@bootlin.com>,
bsp-development.geo@leica-geosystems.com
Subject: Re: [PATCH v5 2/3] dt-bindings: input: Add TouchNetix axiom touchscreen
Date: Wed, 13 Dec 2023 10:15:35 +0100 [thread overview]
Message-ID: <de1ee415-31b0-45fd-b376-f7aa83b64c64@linaro.org> (raw)
In-Reply-To: <20231213091417.GC2340704@kb-xps>
On 13/12/2023 10:14, Kamel Bouhara wrote:
> Le Wed, Dec 13, 2023 at 09:46:03AM +0100, Krzysztof Kozlowski a écrit :
>> On 13/12/2023 09:22, Kamel Bouhara wrote:
>>>> It still brings the type of some fields or the constraints. However need
>>>> of specifying "poll-interval" already points to missing
>>>> unevaluatedProperties.
>>>
>>> Ok, this wasn't clear for me wether or not I should pick
>>> unevaluatedProperties
>>
>> Yes
>>
>>> as I still reference "poll-interval" from the
>>> input.yaml schema ?
>>
>> You should drop it from your binding.
>
> The driver use it could you explain why I should drop it ?
Because it comes from input.yaml and you did not add any constraints, so
poll-interval here is redundant.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-13 9:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 12:14 [PATCH v5 0/3] Input: Add TouchNetix axiom touchscreen driver Kamel Bouhara
2023-12-11 12:14 ` [PATCH v5 1/3] dt-bindings: vendor-prefixes: Add TouchNetix AS Kamel Bouhara
2023-12-11 12:14 ` [PATCH v5 2/3] dt-bindings: input: Add TouchNetix axiom touchscreen Kamel Bouhara
2023-12-12 16:57 ` Conor Dooley
2023-12-13 6:44 ` Krzysztof Kozlowski
2023-12-13 8:22 ` Kamel Bouhara
2023-12-13 8:46 ` Krzysztof Kozlowski
2023-12-13 9:14 ` Kamel Bouhara
2023-12-13 9:15 ` Krzysztof Kozlowski [this message]
2023-12-13 9:59 ` Kamel Bouhara
2023-12-13 8:14 ` Kamel Bouhara
2023-12-11 12:14 ` [PATCH v5 3/3] Input: Add TouchNetix axiom i2c touchscreen driver Kamel Bouhara
2023-12-19 19:54 ` Marco Felsch
2023-12-29 3:44 ` Jeff LaBundy
2024-01-25 16:07 ` Kamel Bouhara
2024-01-31 17:14 ` Kamel Bouhara
2024-01-31 19:57 ` Dmitry Torokhov
2024-02-01 5:09 ` Kamel Bouhara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de1ee415-31b0-45fd-b376-f7aa83b64c64@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bartp@baasheep.co.uk \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=catalin.popescu@leica-geosystems.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=hannah.rossiter@touchnetix.com \
--cc=jeff@labundy.com \
--cc=kamel.bouhara@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mark.satterthwaite@touchnetix.com \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).