From: "Trevor Wu (吳文良)" <Trevor.Wu@mediatek.com>
To: "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"lkp@intel.com" <lkp@intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 08/12] ASoC: mediatek: mt8188: add platform driver
Date: Wed, 5 Oct 2022 06:50:53 +0000 [thread overview]
Message-ID: <de20b79da18bde2bbe56784cf4e209894f8235bf.camel@mediatek.com> (raw)
In-Reply-To: <202210011740.ZdLtxKq1-lkp@intel.com>
Hi maintainers,
As I mentioned in the comment, this patch depends on a reviewing
series.
Should I remove the related code from this patch in case of the build
error?
Thanks,
Trevor
On Sat, 2022-10-01 at 17:17 +0800, kernel test robot wrote:
> Hi Trevor,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on broonie-sound/for-next]
> [also build test ERROR on broonie-spi/for-next tiwai-sound/for-next
> linus/master v6.0-rc7 next-20220930]
> [If your patch is applied to the wrong git tree, kindly drop us a
> note.
> And when submitting patch, we suggest to use '--base' as documented
> in
>
https://urldefense.com/v3/__https://git-scm.com/docs/git-format-patch*_base_tree_information__;Iw!!CTRNKA9wMg0ARbw!zH8i2KTwLCuHKyCuVMxGmO2ybS8oDN4t6suHxraLKrmfrn6SFI0bxxEdFfZ77PE7Rg$
> ]
>
> url:
> https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commits/Trevor-Wu/ASoC-mediatek-Add-support-for-MT8188-SoC/20220930-230009__;!!CTRNKA9wMg0ARbw!zH8i2KTwLCuHKyCuVMxGmO2ybS8oDN4t6suHxraLKrmfrn6SFI0bxxEdFfY6vzwyJg$
>
> base:
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git__;!!CTRNKA9wMg0ARbw!zH8i2KTwLCuHKyCuVMxGmO2ybS8oDN4t6suHxraLKrmfrn6SFI0bxxEdFfY9CuKUxg$
> for-next
> config: s390-allyesconfig
> compiler: s390-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
> wget
> https://urldefense.com/v3/__https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross__;!!CTRNKA9wMg0ARbw!zH8i2KTwLCuHKyCuVMxGmO2ybS8oDN4t6suHxraLKrmfrn6SFI0bxxEdFfYvE9N_pg$
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> #
> https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commit/65c941d291852582ccbe6a8196ff3b60fb4d1243__;!!CTRNKA9wMg0ARbw!zH8i2KTwLCuHKyCuVMxGmO2ybS8oDN4t6suHxraLKrmfrn6SFI0bxxEdFfb2BtdE-w$
>
> git remote add linux-review
> https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux__;!!CTRNKA9wMg0ARbw!zH8i2KTwLCuHKyCuVMxGmO2ybS8oDN4t6suHxraLKrmfrn6SFI0bxxEdFfbWjiP_lw$
>
> git fetch --no-tags linux-review Trevor-Wu/ASoC-mediatek-Add-
> support-for-MT8188-SoC/20220930-230009
> git checkout 65c941d291852582ccbe6a8196ff3b60fb4d1243
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0
> make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> sound/soc/mediatek/mt8188/mt8188-afe-pcm.c: In function
> 'bus_protect_enable':
> > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2649:16: error:
> > > 'MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1' undeclared (first use in
> > > this function); did you mean
> > > 'MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1'?
>
> 2649 | mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1;
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1
> sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2649:16: note: each
> undeclared identifier is reported only once for each function it
> appears in
> > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2650:30: error:
> > > 'MT8188_TOP_AXI_PROT_EN_2_SET' undeclared (first use in this
> > > function); did you mean 'MT8186_TOP_AXI_PROT_EN_2_SET'?
>
> 2650 | regmap_write(regmap, MT8188_TOP_AXI_PROT_EN_2_SET,
> mask);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | MT8186_TOP_AXI_PROT_EN_2_SET
> In file included from include/linux/regmap.h:20,
> from sound/soc/mediatek/mt8188/mt8188-afe-
> common.h:15,
> from sound/soc/mediatek/mt8188/mt8188-afe-
> pcm.c:24:
> > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2652:48: error:
> > > 'MT8188_TOP_AXI_PROT_EN_2_STA' undeclared (first use in this
> > > function); did you mean 'MT8186_TOP_AXI_PROT_EN_2_STA'?
>
> 2652 | ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
> | ^~~~~~~~~~~
> ~~~~~~~~~~~~~~~~~
> include/linux/iopoll.h:46:28: note: in definition of macro
> 'read_poll_timeout'
> 46 | (val) = op(args); \
> | ^~~~
> sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2652:15: note: in
> expansion of macro 'regmap_read_poll_timeout'
> 2652 | ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2659:16: error:
> > > 'MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2' undeclared (first use in
> > > this function); did you mean
> > > 'MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1'?
>
> 2659 | mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2;
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1
> sound/soc/mediatek/mt8188/mt8188-afe-pcm.c: In function
> 'bus_protect_disable':
> sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2678:16: error:
> 'MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2' undeclared (first use in this
> function); did you mean 'MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1'?
> 2678 | mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2;
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1
> > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2679:30: error:
> > > 'MT8188_TOP_AXI_PROT_EN_2_CLR' undeclared (first use in this
> > > function); did you mean 'MT8186_TOP_AXI_PROT_EN_2_CLR'?
>
> 2679 | regmap_write(regmap, MT8188_TOP_AXI_PROT_EN_2_CLR,
> mask);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | MT8186_TOP_AXI_PROT_EN_2_CLR
> sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2681:48: error:
> 'MT8188_TOP_AXI_PROT_EN_2_STA' undeclared (first use in this
> function); did you mean 'MT8186_TOP_AXI_PROT_EN_2_STA'?
> 2681 | ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
> | ^~~~~~~~~~~
> ~~~~~~~~~~~~~~~~~
> include/linux/iopoll.h:46:28: note: in definition of macro
> 'read_poll_timeout'
> 46 | (val) = op(args); \
> | ^~~~
> sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2681:15: note: in
> expansion of macro 'regmap_read_poll_timeout'
> 2681 | ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2688:16: error:
> 'MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1' undeclared (first use in this
> function); did you mean 'MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1'?
> 2688 | mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1;
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1
>
>
> vim +2649 sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
>
> 2641
> 2642 static int bus_protect_enable(struct regmap *regmap)
> 2643 {
> 2644 int ret;
> 2645 u32 val;
> 2646 u32 mask;
> 2647
> 2648 val = 0;
> > 2649 mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1;
> > 2650 regmap_write(regmap,
> > MT8188_TOP_AXI_PROT_EN_2_SET, mask);
>
> 2651
> > 2652 ret = regmap_read_poll_timeout(regmap,
> > MT8188_TOP_AXI_PROT_EN_2_STA,
>
> 2653 val, (val &
> mask) == mask,
> 2654 MT8188_DELAY_US,
> MT8188_TIMEOUT_US);
> 2655 if (ret)
> 2656 return ret;
> 2657
> 2658 val = 0;
> > 2659 mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2;
>
> 2660 regmap_write(regmap,
> MT8188_TOP_AXI_PROT_EN_2_SET, mask);
> 2661
> 2662 ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
> 2663 val, (val &
> mask) == mask,
> 2664 MT8188_DELAY_US,
> MT8188_TIMEOUT_US);
> 2665 if (ret)
> 2666 return ret;
> 2667
> 2668 return 0;
> 2669 }
> 2670
> 2671 static int bus_protect_disable(struct regmap *regmap)
> 2672 {
> 2673 int ret;
> 2674 u32 val;
> 2675 u32 mask;
> 2676
> 2677 val = 0;
> 2678 mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2;
> > 2679 regmap_write(regmap,
> > MT8188_TOP_AXI_PROT_EN_2_CLR, mask);
>
> 2680
> 2681 ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
> 2682 val, !(val &
> mask),
> 2683 MT8188_DELAY_US,
> MT8188_TIMEOUT_US);
> 2684 if (ret)
> 2685 return ret;
> 2686
> 2687 val = 0;
> 2688 mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1;
> 2689 regmap_write(regmap,
> MT8188_TOP_AXI_PROT_EN_2_CLR, mask);
> 2690
> 2691 ret = regmap_read_poll_timeout(regmap,
> MT8188_TOP_AXI_PROT_EN_2_STA,
> 2692 val, !(val &
> mask),
> 2693 MT8188_DELAY_US,
> MT8188_TIMEOUT_US);
> 2694 if (ret)
> 2695 return ret;
> 2696
> 2697 return 0;
> 2698 }
> 2699
>
next prev parent reply other threads:[~2022-10-05 6:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 14:56 [PATCH 00/12] ASoC: mediatek: Add support for MT8188 SoC Trevor Wu
2022-09-30 14:56 ` [PATCH 01/12] ASoC: mediatek: common: add SMC ops ID Trevor Wu
2022-09-30 14:56 ` [PATCH 02/12] ASoC: mediatek: mt8188: add common header Trevor Wu
2022-09-30 14:56 ` [PATCH 03/12] ASoC: mediatek: mt8188: support audsys clock Trevor Wu
2022-09-30 14:56 ` [PATCH 04/12] ASoC: mediatek: mt8188: support adda in platform driver Trevor Wu
2022-10-04 9:37 ` AngeloGioacchino Del Regno
2022-10-05 7:14 ` Trevor Wu (吳文良)
2022-09-30 14:56 ` [PATCH 05/12] ASoC: mediatek: mt8188: support etdm " Trevor Wu
2022-09-30 14:56 ` [PATCH 06/12] ASoC: mediatek: mt8188: support pcmif " Trevor Wu
2022-09-30 14:56 ` [PATCH 07/12] ASoC: mediatek: mt8188: support audio clock control Trevor Wu
2022-09-30 14:56 ` [PATCH 08/12] ASoC: mediatek: mt8188: add platform driver Trevor Wu
2022-10-01 9:17 ` kernel test robot
2022-10-05 6:50 ` Trevor Wu (吳文良) [this message]
2022-10-05 10:59 ` Mark Brown
2022-10-06 3:13 ` Trevor Wu (吳文良)
2022-10-04 9:36 ` AngeloGioacchino Del Regno
2022-10-06 2:48 ` Trevor Wu (吳文良)
2022-10-15 2:27 ` Trevor Wu (吳文良)
2022-09-30 14:56 ` [PATCH 09/12] ASoC: mediatek: mt8188: add control for timing select Trevor Wu
2022-09-30 14:56 ` [PATCH 10/12] dt-bindings: mediatek: mt8188: add audio afe document Trevor Wu
2022-09-30 22:05 ` Rob Herring
2022-10-05 3:57 ` Trevor Wu (吳文良)
2022-10-28 23:46 ` Krzysztof Kozlowski
2022-10-03 16:30 ` Rob Herring
2022-10-05 10:12 ` Trevor Wu (吳文良)
2022-09-30 14:57 ` [PATCH 11/12] ASoC: mediatek: mt8188: add machine driver with mt6359 Trevor Wu
2022-09-30 14:57 ` [PATCH 12/12] dt-bindings: mediatek: mt8188: add mt8188-mt6359 document Trevor Wu
2022-10-03 16:38 ` Rob Herring
2022-10-06 2:38 ` Trevor Wu (吳文良)
2022-10-21 8:54 ` Trevor Wu (吳文良)
2022-10-21 8:58 ` Trevor Wu (吳文良)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de20b79da18bde2bbe56784cf4e209894f8235bf.camel@mediatek.com \
--to=trevor.wu@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lkp@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).