From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v4 1/2] dt: snps,designware-i2c: Add clock bindings documentation References: <1550765459-14519-1-git-send-email-gareth.williams.jx@renesas.com> <1550765459-14519-2-git-send-email-gareth.williams.jx@renesas.com> From: Jarkko Nikula Message-ID: Date: Tue, 26 Feb 2019 16:54:27 +0200 MIME-Version: 1.0 In-Reply-To: <1550765459-14519-2-git-send-email-gareth.williams.jx@renesas.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: Gareth Williams , Rob Herring , Mark Rutland , Alexandre Belloni , Wolfram Sang Cc: Phil Edworthy , devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Luis Oliveira List-ID: Hi + Luis from Synopsys. Sorry the delay, I was out of office last week. Comment below. On 2/21/19 6:10 PM, Gareth Williams wrote: > From: Phil Edworthy > > The driver requires an undocumented clock property, so detail it. > Add documentation for a separate, optional, peripheral clock. > > Signed-off-by: Phil Edworthy > Acked-by: Wolfram Sang > --- > v4: > - Updated commit message to reference "peripheral clock" instead of > "bus clock" > - Added Wolfram's Acked-by > v3: > - Changed clocks and clock-names sections to use term "peripheral clock" > (pclk) instead of "bus clock" (busclk). ... > Optional properties : > + > + - clock-names : Contains the names of the clocks: > + "ic_clk", for the core clock used to generate the external I2C clock. > + "pclk", the peripheral clock, required for register accesses. > + Actually it looks there is need to revert back to bus clock (or better) in comments but keep the "pclk" property. The specification I have tells the ic_clk is the peripheral clock which runs the logic and the pclk (exactly pclk) is for bus interface and where registers are. Luis: did I interpret it right? -- Jarkko