* [PATCH v3] arm64: dts: mt8173: Fix elm panel DT node
@ 2022-06-21 9:18 Pin-Yen Lin
2022-07-07 14:50 ` Matthias Brugger
0 siblings, 1 reply; 5+ messages in thread
From: Pin-Yen Lin @ 2022-06-21 9:18 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger
Cc: Hsin-Yi Wang, Eizan Miyamoto, Pin-Yen Lin, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek
Move the panel DT node under `aux-bus` node, so it won't use the buggy
`ps8640_bridge_get_edid` to get the display modes. Also, change the
compatible string from "lg,lp120up1" to "edp-panel", so the panel-edp
driver gets the displays modes from the EDID instead of using the
predefined display mode (`lg_lp129qe_mode`) in the driver, which is
actually not working.
Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
---
Changes in v3:
- Include more details in the commit message.
Changes in v2:
- Remove the Fixes tag because this change is not compatible with the
old kernel versions.
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 26 +++++++++++---------
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index 9c75fbb31f98..1e0802a6f6d2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -90,18 +90,6 @@ volume_up {
};
};
- panel: panel {
- compatible = "lg,lp120up1";
- power-supply = <&panel_fixed_3v3>;
- backlight = <&backlight>;
-
- port {
- panel_in: endpoint {
- remote-endpoint = <&ps8640_out>;
- };
- };
- };
-
panel_fixed_3v3: regulator1 {
compatible = "regulator-fixed";
regulator-name = "PANEL_3V3";
@@ -282,6 +270,20 @@ ps8640_out: endpoint {
};
};
};
+
+ aux-bus {
+ panel {
+ compatible = "edp-panel";
+ power-supply = <&panel_fixed_3v3>;
+ backlight = <&backlight>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&ps8640_out>;
+ };
+ };
+ };
+ };
};
};
--
2.37.0.rc0.104.g0611611a94-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v3] arm64: dts: mt8173: Fix elm panel DT node
2022-06-21 9:18 [PATCH v3] arm64: dts: mt8173: Fix elm panel DT node Pin-Yen Lin
@ 2022-07-07 14:50 ` Matthias Brugger
2022-07-11 3:09 ` Pin-yen Lin
0 siblings, 1 reply; 5+ messages in thread
From: Matthias Brugger @ 2022-07-07 14:50 UTC (permalink / raw)
To: Pin-Yen Lin, Rob Herring, Krzysztof Kozlowski
Cc: Hsin-Yi Wang, Eizan Miyamoto, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek
On 21/06/2022 11:18, Pin-Yen Lin wrote:
> Move the panel DT node under `aux-bus` node, so it won't use the buggy
> `ps8640_bridge_get_edid` to get the display modes. Also, change the
> compatible string from "lg,lp120up1" to "edp-panel", so the panel-edp
> driver gets the displays modes from the EDID instead of using the
> predefined display mode (`lg_lp129qe_mode`) in the driver, which is
> actually not working.
>
Do we need a fixes tag here? I'm not quite sure if we fix an upstream bug here,
to be honest.
Regards,
Matthias
> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> ---
>
> Changes in v3:
> - Include more details in the commit message.
>
> Changes in v2:
> - Remove the Fixes tag because this change is not compatible with the
> old kernel versions.
>
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 26 +++++++++++---------
> 1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 9c75fbb31f98..1e0802a6f6d2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -90,18 +90,6 @@ volume_up {
> };
> };
>
> - panel: panel {
> - compatible = "lg,lp120up1";
> - power-supply = <&panel_fixed_3v3>;
> - backlight = <&backlight>;
> -
> - port {
> - panel_in: endpoint {
> - remote-endpoint = <&ps8640_out>;
> - };
> - };
> - };
> -
> panel_fixed_3v3: regulator1 {
> compatible = "regulator-fixed";
> regulator-name = "PANEL_3V3";
> @@ -282,6 +270,20 @@ ps8640_out: endpoint {
> };
> };
> };
> +
> + aux-bus {
> + panel {
> + compatible = "edp-panel";
> + power-supply = <&panel_fixed_3v3>;
> + backlight = <&backlight>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&ps8640_out>;
> + };
> + };
> + };
> + };
> };
> };
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] arm64: dts: mt8173: Fix elm panel DT node
2022-07-07 14:50 ` Matthias Brugger
@ 2022-07-11 3:09 ` Pin-yen Lin
2022-07-25 8:25 ` Pin-yen Lin
0 siblings, 1 reply; 5+ messages in thread
From: Pin-yen Lin @ 2022-07-11 3:09 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Krzysztof Kozlowski, Hsin-Yi Wang, Eizan Miyamoto,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek
All we know is that the functions mentioned in the commit message were
working in 4.19 kernel, but not in the latest kernel tree.
Unfortunately, we don't know which patch breaks the driver.
Best regards,
Pin-yen
On Thu, Jul 7, 2022 at 10:50 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
>
>
> On 21/06/2022 11:18, Pin-Yen Lin wrote:
> > Move the panel DT node under `aux-bus` node, so it won't use the buggy
> > `ps8640_bridge_get_edid` to get the display modes. Also, change the
> > compatible string from "lg,lp120up1" to "edp-panel", so the panel-edp
> > driver gets the displays modes from the EDID instead of using the
> > predefined display mode (`lg_lp129qe_mode`) in the driver, which is
> > actually not working.
> >
>
> Do we need a fixes tag here? I'm not quite sure if we fix an upstream bug here,
> to be honest.
>
> Regards,
> Matthias
>
> > Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> > ---
> >
> > Changes in v3:
> > - Include more details in the commit message.
> >
> > Changes in v2:
> > - Remove the Fixes tag because this change is not compatible with the
> > old kernel versions.
> >
> > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 26 +++++++++++---------
> > 1 file changed, 14 insertions(+), 12 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > index 9c75fbb31f98..1e0802a6f6d2 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > @@ -90,18 +90,6 @@ volume_up {
> > };
> > };
> >
> > - panel: panel {
> > - compatible = "lg,lp120up1";
> > - power-supply = <&panel_fixed_3v3>;
> > - backlight = <&backlight>;
> > -
> > - port {
> > - panel_in: endpoint {
> > - remote-endpoint = <&ps8640_out>;
> > - };
> > - };
> > - };
> > -
> > panel_fixed_3v3: regulator1 {
> > compatible = "regulator-fixed";
> > regulator-name = "PANEL_3V3";
> > @@ -282,6 +270,20 @@ ps8640_out: endpoint {
> > };
> > };
> > };
> > +
> > + aux-bus {
> > + panel {
> > + compatible = "edp-panel";
> > + power-supply = <&panel_fixed_3v3>;
> > + backlight = <&backlight>;
> > +
> > + port {
> > + panel_in: endpoint {
> > + remote-endpoint = <&ps8640_out>;
> > + };
> > + };
> > + };
> > + };
> > };
> > };
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] arm64: dts: mt8173: Fix elm panel DT node
2022-07-11 3:09 ` Pin-yen Lin
@ 2022-07-25 8:25 ` Pin-yen Lin
2022-10-13 3:35 ` Pin-yen Lin
0 siblings, 1 reply; 5+ messages in thread
From: Pin-yen Lin @ 2022-07-25 8:25 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Krzysztof Kozlowski, Hsin-Yi Wang, Eizan Miyamoto,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek
Hi Matthias.
Gentle ping on this thread. Any feedback or suggestions?
Regards,
Pin-yen
On Mon, Jul 11, 2022 at 11:09 AM Pin-yen Lin <treapking@chromium.org> wrote:
>
> All we know is that the functions mentioned in the commit message were
> working in 4.19 kernel, but not in the latest kernel tree.
>
> Unfortunately, we don't know which patch breaks the driver.
>
> Best regards,
> Pin-yen
>
> On Thu, Jul 7, 2022 at 10:50 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> >
> >
> >
> > On 21/06/2022 11:18, Pin-Yen Lin wrote:
> > > Move the panel DT node under `aux-bus` node, so it won't use the buggy
> > > `ps8640_bridge_get_edid` to get the display modes. Also, change the
> > > compatible string from "lg,lp120up1" to "edp-panel", so the panel-edp
> > > driver gets the displays modes from the EDID instead of using the
> > > predefined display mode (`lg_lp129qe_mode`) in the driver, which is
> > > actually not working.
> > >
> >
> > Do we need a fixes tag here? I'm not quite sure if we fix an upstream bug here,
> > to be honest.
> >
> > Regards,
> > Matthias
> >
> > > Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> > > ---
> > >
> > > Changes in v3:
> > > - Include more details in the commit message.
> > >
> > > Changes in v2:
> > > - Remove the Fixes tag because this change is not compatible with the
> > > old kernel versions.
> > >
> > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 26 +++++++++++---------
> > > 1 file changed, 14 insertions(+), 12 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > > index 9c75fbb31f98..1e0802a6f6d2 100644
> > > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > > @@ -90,18 +90,6 @@ volume_up {
> > > };
> > > };
> > >
> > > - panel: panel {
> > > - compatible = "lg,lp120up1";
> > > - power-supply = <&panel_fixed_3v3>;
> > > - backlight = <&backlight>;
> > > -
> > > - port {
> > > - panel_in: endpoint {
> > > - remote-endpoint = <&ps8640_out>;
> > > - };
> > > - };
> > > - };
> > > -
> > > panel_fixed_3v3: regulator1 {
> > > compatible = "regulator-fixed";
> > > regulator-name = "PANEL_3V3";
> > > @@ -282,6 +270,20 @@ ps8640_out: endpoint {
> > > };
> > > };
> > > };
> > > +
> > > + aux-bus {
> > > + panel {
> > > + compatible = "edp-panel";
> > > + power-supply = <&panel_fixed_3v3>;
> > > + backlight = <&backlight>;
> > > +
> > > + port {
> > > + panel_in: endpoint {
> > > + remote-endpoint = <&ps8640_out>;
> > > + };
> > > + };
> > > + };
> > > + };
> > > };
> > > };
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] arm64: dts: mt8173: Fix elm panel DT node
2022-07-25 8:25 ` Pin-yen Lin
@ 2022-10-13 3:35 ` Pin-yen Lin
0 siblings, 0 replies; 5+ messages in thread
From: Pin-yen Lin @ 2022-10-13 3:35 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Krzysztof Kozlowski, Hsin-Yi Wang, Eizan Miyamoto,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek
Friendly ping again on this thread.
On Mon, Jul 25, 2022 at 4:25 PM Pin-yen Lin <treapking@chromium.org> wrote:
>
> Hi Matthias.
>
> Gentle ping on this thread. Any feedback or suggestions?
>
> Regards,
> Pin-yen
>
> On Mon, Jul 11, 2022 at 11:09 AM Pin-yen Lin <treapking@chromium.org> wrote:
> >
> > All we know is that the functions mentioned in the commit message were
> > working in 4.19 kernel, but not in the latest kernel tree.
> >
> > Unfortunately, we don't know which patch breaks the driver.
> >
> > Best regards,
> > Pin-yen
> >
> > On Thu, Jul 7, 2022 at 10:50 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> > >
> > >
> > >
> > > On 21/06/2022 11:18, Pin-Yen Lin wrote:
> > > > Move the panel DT node under `aux-bus` node, so it won't use the buggy
> > > > `ps8640_bridge_get_edid` to get the display modes. Also, change the
> > > > compatible string from "lg,lp120up1" to "edp-panel", so the panel-edp
> > > > driver gets the displays modes from the EDID instead of using the
> > > > predefined display mode (`lg_lp129qe_mode`) in the driver, which is
> > > > actually not working.
> > > >
> > >
> > > Do we need a fixes tag here? I'm not quite sure if we fix an upstream bug here,
> > > to be honest.
> > >
> > > Regards,
> > > Matthias
> > >
> > > > Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> > > > ---
> > > >
> > > > Changes in v3:
> > > > - Include more details in the commit message.
> > > >
> > > > Changes in v2:
> > > > - Remove the Fixes tag because this change is not compatible with the
> > > > old kernel versions.
> > > >
> > > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 26 +++++++++++---------
> > > > 1 file changed, 14 insertions(+), 12 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > > > index 9c75fbb31f98..1e0802a6f6d2 100644
> > > > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > > > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > > > @@ -90,18 +90,6 @@ volume_up {
> > > > };
> > > > };
> > > >
> > > > - panel: panel {
> > > > - compatible = "lg,lp120up1";
> > > > - power-supply = <&panel_fixed_3v3>;
> > > > - backlight = <&backlight>;
> > > > -
> > > > - port {
> > > > - panel_in: endpoint {
> > > > - remote-endpoint = <&ps8640_out>;
> > > > - };
> > > > - };
> > > > - };
> > > > -
> > > > panel_fixed_3v3: regulator1 {
> > > > compatible = "regulator-fixed";
> > > > regulator-name = "PANEL_3V3";
> > > > @@ -282,6 +270,20 @@ ps8640_out: endpoint {
> > > > };
> > > > };
> > > > };
> > > > +
> > > > + aux-bus {
> > > > + panel {
> > > > + compatible = "edp-panel";
> > > > + power-supply = <&panel_fixed_3v3>;
> > > > + backlight = <&backlight>;
> > > > +
> > > > + port {
> > > > + panel_in: endpoint {
> > > > + remote-endpoint = <&ps8640_out>;
> > > > + };
> > > > + };
> > > > + };
> > > > + };
> > > > };
> > > > };
> > > >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-13 3:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-21 9:18 [PATCH v3] arm64: dts: mt8173: Fix elm panel DT node Pin-Yen Lin
2022-07-07 14:50 ` Matthias Brugger
2022-07-11 3:09 ` Pin-yen Lin
2022-07-25 8:25 ` Pin-yen Lin
2022-10-13 3:35 ` Pin-yen Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).