From: Marek Vasut <marek.vasut@mailbox.org>
To: Conor Dooley <conor@kernel.org>
Cc: linux-clk@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: clk: si522xx: Clock driver for Skyworks Si522xx I2C PCIe clock generators
Date: Tue, 14 Oct 2025 12:56:29 +0200 [thread overview]
Message-ID: <de68a605-8b42-4dba-bd59-4708a5bcf542@mailbox.org> (raw)
In-Reply-To: <20251013-finally-stopped-7f5ebac801b3@spud>
On 10/13/25 10:00 PM, Conor Dooley wrote:
Hello Conor,
>> diff --git a/Documentation/devicetree/bindings/clock/skyworks,si522xx.yaml b/Documentation/devicetree/bindings/clock/skyworks,si522xx.yaml
>> new file mode 100644
>> index 0000000000000..6ad26543f9d21
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/skyworks,si522xx.yaml
>
> Can you just pick one of the compatibles here?
I reused the existing pattern from previous binding document.
Documentation/devicetree/bindings/clock/skyworks,si521xx.yaml
I can use the 52202 for this binding document if that is preferable ?
...
>> +patternProperties:
>> + "^DIFF[0-11]$":
>> + type: object
>> + description:
>> + Description of one of the outputs (DIFF0..DIF11).
>
> typo, DIFF11.
> Does this regex actually work? I don't think it allows anything other
> than DIFF0 and DIFF1, since it evaluates 0-1 as a range and 1 as another
> range.
Fixed both, also fixed rs9 bindings and patch posted.
next prev parent reply other threads:[~2025-10-14 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-11 22:35 [PATCH 1/2] dt-bindings: clk: si522xx: Clock driver for Skyworks Si522xx I2C PCIe clock generators Marek Vasut
2025-10-11 22:36 ` [PATCH 2/2] " Marek Vasut
2025-10-13 20:00 ` [PATCH 1/2] dt-bindings: " Conor Dooley
2025-10-14 10:56 ` Marek Vasut [this message]
2025-10-14 17:29 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de68a605-8b42-4dba-bd59-4708a5bcf542@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).