From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Jander <david@protonic.nl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node
Date: Mon, 25 Jul 2022 22:33:12 +0200 [thread overview]
Message-ID: <de68c1e8-447d-f1e9-7885-6a109af1e971@linaro.org> (raw)
In-Reply-To: <20220725124813.1001032-1-david@protonic.nl>
On 25/07/2022 14:48, David Jander wrote:
> On some older hardware models this is needed. It will do no harm if used
> with newer models though.
>
> Signed-off-by: David Jander <david@protonic.nl>
> ---
> arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> index a1676b5d2980..08d425020088 100644
> --- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> @@ -37,6 +37,16 @@ backlight_led: backlight_led {
> power-supply = <®_3v3>;
> };
>
> + /* only for backwards compatibility with old HW */
> + backlight_isb: backlight_isb {
Node name: backlight-isb
I know that other node had underscore, but these are not correct for names.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-25 20:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 12:48 [PATCH] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node David Jander
2022-07-25 20:33 ` Krzysztof Kozlowski [this message]
2022-07-26 6:30 ` David Jander
2022-07-26 7:01 ` Krzysztof Kozlowski
2022-07-26 12:34 ` David Jander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de68c1e8-447d-f1e9-7885-6a109af1e971@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).