From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A713C433F5 for ; Thu, 12 May 2022 07:01:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350612AbiELHBI (ORCPT ); Thu, 12 May 2022 03:01:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350620AbiELHAx (ORCPT ); Thu, 12 May 2022 03:00:53 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DF6DB31; Thu, 12 May 2022 00:00:45 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 586CE1F91A; Thu, 12 May 2022 07:00:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652338844; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CoCLuGHosTQY/S1Lxq1K4O89X72EsqKKPftzUcmtlKY=; b=TTDGpDaffF83csbm+pVPxEJHDjG5eu95zsmzzCAVscFmeQNsmC0xFWz6hjargNvla4Z7Q/ JjlyJTH//PzTW5aAs/IIPmNcng/hy5ILpykh9m5JWqQ9vOVbMuJyhpB1HiLhgTSnlSRdrf 7UxLFGtIqF+Kv2FeIggYqiB+l2nWYSs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652338844; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CoCLuGHosTQY/S1Lxq1K4O89X72EsqKKPftzUcmtlKY=; b=M2c67dXeFCuF+pmxIFtTRFm4YjZ7yww8b1K9T3r/zGz1/BjWQT7eSCbS3drn0uu53tSIxW JCSblQwa/H5SmRAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1ACD913A97; Thu, 12 May 2022 07:00:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id m9qMBZywfGJCWwAAMHmgww (envelope-from ); Thu, 12 May 2022 07:00:44 +0000 Message-ID: Date: Thu, 12 May 2022 09:00:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 15/23] ata: libahci: Don't read AHCI version twice in the save-config method Content-Language: en-US To: Serge Semin , Damien Le Moal , Hans de Goede , Jens Axboe Cc: Serge Semin , Alexey Malahov , Pavel Parkhomenko , Rob Herring , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220511231810.4928-1-Sergey.Semin@baikalelectronics.ru> <20220511231810.4928-16-Sergey.Semin@baikalelectronics.ru> From: Hannes Reinecke In-Reply-To: <20220511231810.4928-16-Sergey.Semin@baikalelectronics.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 5/12/22 01:18, Serge Semin wrote: > There is no point in reading the AHCI version all over in the tail of the > ahci_save_initial_config() method. That register is RO and doesn't change > its value even after reset. So just reuse the data, which has already been > read from there earlier in the head of the function. > > Signed-off-by: Serge Semin > --- > drivers/ata/libahci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c > index 000a7072614f..1ffaa5f5f21a 100644 > --- a/drivers/ata/libahci.c > +++ b/drivers/ata/libahci.c > @@ -564,7 +564,7 @@ void ahci_save_initial_config(struct device *dev, struct ahci_host_priv *hpriv) > /* record values to use during operation */ > hpriv->cap = cap; > hpriv->cap2 = cap2; > - hpriv->version = readl(mmio + HOST_VERSION); > + hpriv->version = vers; > hpriv->port_map = port_map; > > if (!hpriv->start_engine) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer