devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "J. Neuschäfer" <j.ne@posteo.net>, "Lee Jones" <lee@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: Allow differently named multicolor leds
Date: Tue, 11 Feb 2025 20:10:28 +0100	[thread overview]
Message-ID: <de7fb605-527e-4c62-9b5d-947a1636c54b@kernel.org> (raw)
In-Reply-To: <Z6ucAFNauWkhfYZr@probook>

On 11/02/2025 19:50, J. Neuschäfer wrote:
> On Tue, Feb 11, 2025 at 02:43:00PM +0000, Lee Jones wrote:
>> On Sun, 09 Feb 2025, J. Neuschäfer via B4 Relay wrote:
>>
>>> From: "J. Neuschäfer" <j.ne@posteo.net>
>>>
>>> In some cases, a board may have multiple multi-leds, which can't be
>>> distinguished by unit address. In such cases it should be possible to
>>> name them differently, for example multi-led-a and multi-led-b.
>>> This patch adds another node name pattern to leds-class-multicolor.yaml
>>> to allow such names.
>>
>> Which H/W needs this?  Is it upstream?  Where is the doc / usage?
> 
> I encountered this situation while upstreaming the LANCOM NWAPP2 board,
> which has multiple LED-group-based multicolor LEDs:
> 
>   https://lore.kernel.org/lkml/20250102-mpc83xx-v1-16-86f78ba2a7af@posteo.net/

Which LEDs are these? I don't see multi-led there node name at all.

This patch must come with user. It's fine to send the user separately,
but please provide lore link to exact user.

Otherwise what certainty we have that this change is needed in the first
place?

> 
> Since they are based on leds-group-multicolor, they don't have a unit
> address, but there is more than one on the same level (as direct
> sub-nodes of the DT root node).

Which binding is this?



Best regards,
Krzysztof

  reply	other threads:[~2025-02-11 19:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-09 22:06 [PATCH] dt-bindings: leds: Allow differently named multicolor leds J. Neuschäfer via B4 Relay
2025-02-11 14:43 ` Lee Jones
2025-02-11 18:50   ` J. Neuschäfer
2025-02-11 19:10     ` Krzysztof Kozlowski [this message]
2025-02-16 18:49       ` J. Neuschäfer
2025-02-11 19:11 ` Krzysztof Kozlowski
2025-02-17 10:58 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de7fb605-527e-4c62-9b5d-947a1636c54b@kernel.org \
    --to=krzk@kernel.org \
    --cc=afd@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j.ne@posteo.net \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).