From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E1BAC433FE for ; Fri, 4 Nov 2022 15:05:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232310AbiKDPFR (ORCPT ); Fri, 4 Nov 2022 11:05:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232344AbiKDPFF (ORCPT ); Fri, 4 Nov 2022 11:05:05 -0400 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89509CE11 for ; Fri, 4 Nov 2022 08:05:01 -0700 (PDT) Received: by mail-qt1-x836.google.com with SMTP id s4so3177482qtx.6 for ; Fri, 04 Nov 2022 08:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5kKj2HIKfebU1wqXRbpuIOe2X6eo5mH0qzyrObQvTos=; b=sjt+BRK/izOiDlqyY+3ss4dyirbPPCpyDLpqCrFgopvXlTcrlsrntZXGMBmKVScE1x zy9mAUXXMDlK8pltGBFbfPQOH9L4l05E4zyq/lszhpJwn9RZ/WAR2idTdveim26FEsZw 2AkLzjPo4J/tA8+WgRQAttTnmxd37SWZ4nN5p7yHkm+KvhkP0Ki3Rv+0SsKVj3Ox11CN EVeM1qBpjqjQYHW9VBMjGHMg5OZWzMfn/eRcAcvPVsL6OCyeGHUdJpIwhXMsjeCHha1W XlC7yRI3AN3ftPcCzMp38iraa6G5YToZIEujaqv9Fw8xyAVH1+0AtX+LYORqZ773g3Yy FIkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5kKj2HIKfebU1wqXRbpuIOe2X6eo5mH0qzyrObQvTos=; b=lKviLG+x5tKK9LYorvDKNzUxYfd5qGXEbXhYToeFbecHVkVWGWjhM38S5PoR+loqSI Fg8Mfjzl+jPJN+y9nDNfF+MEgOWGY7dQ4zqmHns29TFOiF0SkYiTW6MkSh0wVRSTr/CM O1xBmmETrO2T+0BViJMLdB5D24QmQ9xnNvF22vsqhcY8bpiKyH9mtJKf3lywbhM5Vo07 Ka5iS5c6+iBqkRGlN6+t33SZoPYn7C43bLQVWQHT1/0x3DgQj13gF6FthjBC2ESHsfxi 2Fsjo17uymqP0anzzzc+Uz3XVC0xsmr2AHQlkv3ZZ8SNPhDhzshHCZfYoQ/9ehAnVsQ7 +CqA== X-Gm-Message-State: ACrzQf1+NIgc0fTP9ek13iM0snWnXVeaWdz/uaDlks0iXPw/HsOtbPnW EUqLPzk58RYc4WJXPs5HbeTe0g== X-Google-Smtp-Source: AMsMyM5xZrX3byWS6ydTqCJhAAcQbZzJsuXLcwER9U389lqI1BK9+b+3daJ0HbJ9ZjWTEnni0viUog== X-Received: by 2002:ac8:5849:0:b0:39a:8e35:1bfa with SMTP id h9-20020ac85849000000b0039a8e351bfamr28751605qth.573.1667574300664; Fri, 04 Nov 2022 08:05:00 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:aad6:acd8:4ed9:299b? ([2601:586:5000:570:aad6:acd8:4ed9:299b]) by smtp.gmail.com with ESMTPSA id 204-20020a3706d5000000b006eed094dcdasm3017414qkg.70.2022.11.04.08.04.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 08:05:00 -0700 (PDT) Message-ID: Date: Fri, 4 Nov 2022 11:04:59 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/3] dt-bindings: pwm: rzg2l-gpt: Document renesas,poegs property Content-Language: en-US To: Biju Das , Thierry Reding , Rob Herring , Krzysztof Kozlowski Cc: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, Geert Uytterhoeven , Chris Paterson , Prabhakar Mahadev Lad , linux-renesas-soc@vger.kernel.org References: <20221104145938.1782464-1-biju.das.jz@bp.renesas.com> <20221104145938.1782464-3-biju.das.jz@bp.renesas.com> From: Krzysztof Kozlowski In-Reply-To: <20221104145938.1782464-3-biju.das.jz@bp.renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/11/2022 10:59, Biju Das wrote: > RZ/G2L GPT IP supports output pin disable function by dead time > error and detecting short-circuits between output pins. > > Add documentation for the optional property renesas,poegs to > link a pair of GPT IOs with POEG. > > Signed-off-by: Biju Das > --- > .../bindings/pwm/renesas,rzg2l-gpt.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml b/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml > index 620d5ae4ae30..32f9deae89e5 100644 > --- a/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml > +++ b/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml > @@ -245,6 +245,24 @@ properties: > resets: > maxItems: 1 > > + renesas,poegs: > + $ref: "/schemas/types.yaml#/definitions/phandle-array" No need for quotes. > + items: You miss here maxItems... but if you have just one item, then below "items" should be " - items" > + items: > + - description: phandle to POEG instance that serves the output disable > + - description: An index identifying pair of GPT channels. > + <0> - GPT channels 0 and 1 > + <1> - GPT channels 2 and 3 > + <2> - GPT channels 4 and 5 > + <3> - GPT channels 6 and 7 > + <4> - GPT channels 8 and 9 > + <5> - GPT channels 10 and 11 > + <6> - GPT channels 12 and 13 > + <7> - GPT channels 14 and 15 then this could bave enum or minimum/maximum. Can you try if these work? > + description: > + A list of phandle and channel index pair tuples to the POEGs that handle the > + output disable for the GPT channels. > + > required: > - compatible > - reg > @@ -375,4 +393,5 @@ examples: > power-domains = <&cpg>; > resets = <&cpg R9A07G044_GPT_RST_C>; > #pwm-cells = <2>; > + renesas,poegs = <&poeggd 4>; > }; Best regards, Krzysztof