devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: haibo.chen@nxp.com, ulf.hansson@linaro.org,
	linux-mmc@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de
Cc: linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com,
	cniedermaier@dh-electronics.com, devicetree@vger.kernel.org,
	kernel@dh-electronics.com
Subject: Re: [PATCH v2 1/4] mmc: sdhci-esdhc-imx: remove unused enum cd_types
Date: Fri, 19 May 2023 13:37:05 +0300	[thread overview]
Message-ID: <deb7bfca-0a5c-a9c9-06bd-c4290f2116f4@intel.com> (raw)
In-Reply-To: <20230506074037.522961-2-haibo.chen@nxp.com>

On 6/05/23 10:40, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
> 
> enum cd_types is no more used, so remove it here.

FWIW it doesn't look like max_bus_width is being used either?

> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>

Nevertheless:

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index eebf94604a7f..c7db742f729c 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -207,25 +207,16 @@ enum wp_types {
>  	ESDHC_WP_GPIO,		/* external gpio pin for WP */
>  };
>  
> -enum cd_types {
> -	ESDHC_CD_NONE,		/* no CD, neither controller nor gpio */
> -	ESDHC_CD_CONTROLLER,	/* mmc controller internal CD */
> -	ESDHC_CD_GPIO,		/* external gpio pin for CD */
> -	ESDHC_CD_PERMANENT,	/* no CD, card permanently wired to host */
> -};
> -
>  /*
>   * struct esdhc_platform_data - platform data for esdhc on i.MX
>   *
>   * ESDHC_WP(CD)_CONTROLLER type is not available on i.MX25/35.
>   *
>   * @wp_type:	type of write_protect method (see wp_types enum above)
> - * @cd_type:	type of card_detect method (see cd_types enum above)
>   */
>  
>  struct esdhc_platform_data {
>  	enum wp_types wp_type;
> -	enum cd_types cd_type;
>  	int max_bus_width;
>  	unsigned int delay_line;
>  	unsigned int tuning_step;       /* The delay cell steps in tuning procedure */


  reply	other threads:[~2023-05-19 10:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-06  7:40 [PATCH v2 0/4] cd/wp code clean up for i.MX USDHC haibo.chen
2023-05-06  7:40 ` [PATCH v2 1/4] mmc: sdhci-esdhc-imx: remove unused enum cd_types haibo.chen
2023-05-19 10:37   ` Adrian Hunter [this message]
2023-05-06  7:40 ` [PATCH v2 2/4] mmc: sdhci-esdhc-imx: remove redundant write protect code haibo.chen
2023-05-19 10:36   ` Adrian Hunter
2023-06-01  7:50     ` Bough Chen
2023-05-06  7:40 ` [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller" haibo.chen
2023-05-06 10:59   ` Krzysztof Kozlowski
2023-05-23  2:03     ` Peng Fan
2023-06-08 17:44       ` Rob Herring
2023-05-06  7:40 ` [PATCH v2 4/4] arm: dts: imx: remove "fsl,wp-controller" since it is dropped haibo.chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=deb7bfca-0a5c-a9c9-06bd-c4290f2116f4@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=cniedermaier@dh-electronics.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=haibo.chen@nxp.com \
    --cc=kernel@dh-electronics.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).