From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EBF8C04AA5 for ; Thu, 25 Aug 2022 12:02:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239754AbiHYMCj (ORCPT ); Thu, 25 Aug 2022 08:02:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240419AbiHYMCi (ORCPT ); Thu, 25 Aug 2022 08:02:38 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32AA6923FC for ; Thu, 25 Aug 2022 05:02:36 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id u24so13627033lji.0 for ; Thu, 25 Aug 2022 05:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=o6731Xg3uO5AI5x1e5LBWQaIC7OQDL55NoHUUcojApI=; b=P/0dLvrSbYllUSKNvLcVaTp/7rEj9xNoOXS9wBI5Pz3SHQCDQECfMJpzwQA2h8/QX8 rndTmAuJxXOT4pF861scjFqx4+O9kfdK6sofBbQSun3MwD/bWYzOhUGqSI6by6n2Khpn HFT44xpkDWe+xGpDMu/Cx8/77trn3yIRZc06MTeaghRZXgzCaMM1RpwMkte53I+fwKYA XuJdMt2PPS0VN1lwevlr3f5eG88M7srNyMO9aZYVoRYLx7fYe2lBbF0cim+jK9hctwYB ZXuDcxJ1oCiJ5sxZFGvuXBoOPVnp5yMGYxgLJ4DEEeWusz3Z6pcFaA2dPatQS1Du19Xg NVtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=o6731Xg3uO5AI5x1e5LBWQaIC7OQDL55NoHUUcojApI=; b=ZUwZLD0z6BhFZKFRF+gq7G8cJEJb6GJtFaQf5Ak/i/K0+0p6oDrX4xFzfML+rb855o keB7X/+POYXCFgn2ox3KnH0dVpNbIOWiRJaxKYCUMYYVVVFPk/qr3j4t1xJtdw38au6O O3HpV8uHxhmfrD6ZchW43AE05zZKTwWCbljRIPx/VyiVbInUXAC9VO9OhGzSBQ9d/oxg bM76OQsjHAsj3K7BcczK/VrLdJI0BuwOpQ1xxmNLJUSpe+biaTHFPgeXzNKN8DPG/Uoc SoNNT0HvhJU7grtYq205c+nAt9joNbzuhxPX5pfCQzN7aUPvRD0lt3xeTP/R1WYCWREz RVCw== X-Gm-Message-State: ACgBeo2knw2q2vRYJno30j/C1vvj01k0GlROjTlgM25T4FpdGIQ1Q2sp TcAd1YbwsuBfU33aKLkA0E2NVN8TEhfBohKhqW4= X-Google-Smtp-Source: AA6agR55GD5od73dv0g9JiBl5UZUqTJtQdGJesoeHaC6tznWWEUcvvev13E7N+dsDBjpXhVKDLAZxw== X-Received: by 2002:a2e:9515:0:b0:261:b705:9909 with SMTP id f21-20020a2e9515000000b00261b7059909mr980260ljh.508.1661428954598; Thu, 25 Aug 2022 05:02:34 -0700 (PDT) Received: from [192.168.0.71] (82.131.98.15.cable.starman.ee. [82.131.98.15]) by smtp.gmail.com with ESMTPSA id g9-20020a19ac09000000b0048aef1abb06sm471094lfc.69.2022.08.25.05.02.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Aug 2022 05:02:33 -0700 (PDT) Message-ID: Date: Thu, 25 Aug 2022 15:02:31 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h Content-Language: en-US To: Huqiang Qin , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, narmstrong@baylibre.com, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220825115154.2150323-1-huqiang.qin@amlogic.com> From: Krzysztof Kozlowski In-Reply-To: <20220825115154.2150323-1-huqiang.qin@amlogic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/08/2022 14:51, Huqiang Qin wrote: > Add the included meson-s4-gpio.h in the meson-s4.dtsi > Why? We can see what you did here, but commit msg should explain why you do it... Best regards, Krzysztof