From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32116C001B0 for ; Wed, 19 Jul 2023 10:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231359AbjGSKYl (ORCPT ); Wed, 19 Jul 2023 06:24:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231285AbjGSKYU (ORCPT ); Wed, 19 Jul 2023 06:24:20 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E57231FC1 for ; Wed, 19 Jul 2023 03:23:56 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-51e344efd75so1388537a12.1 for ; Wed, 19 Jul 2023 03:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689762224; x=1692354224; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h3pJ8/rAhj7NYYJOhmqVYLudMFrx8gs19kteCOdK6ME=; b=REFy3lfHdamB0ISB9cfcvAlnp1ANO8B7PvMomD/R8EWPuyyd7ItQF0bpLv2WocJKA0 9eSA9HSeSW0ct92RmNbzYNzIUVGf0lEnWjuQpnjNBiC4Zp7e7yvTrYJ+qufsynUM960R hWwSRU1x4Iyx+vWdcZqasaQI3A8P7YhwNzRnK96fmugysLKnpebOjf8gitmEbZrKIeZj Q7zQ2BirllI4mIfL7etOOdYz4vm1mNlIuYFwzh8EfbhRIeHrVwwc74Rnvl3fhKmsM+4g 85OtZ/SymqM2yHrl7UNftuRQCfdXPVrcGXOIS4B7aLeQL0/JpzmAsdKNob1MKVq1POlD raFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689762224; x=1692354224; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h3pJ8/rAhj7NYYJOhmqVYLudMFrx8gs19kteCOdK6ME=; b=AVHXyqlQlcJ0Fzw50iM9FLZfpT/iSYri/AyCjrf2a6NE9LmDhsqMt18+3PoAkzkZEf 3KhGZ8Rj6qyQ/CzVXVjtX8HHeL6ZI2VG2XgPYHLiGfGYP3xUIp+QpyWrBsI9wiwOPfIG 6l057JYX5rZHLYoV68vKHlak3O90bI8/Hz0SmoXcS5r/oXYJ6WEUWjF3KHPJJ0eBkExe HeLLqvIUmdcR1EUX0k5/bWY8v5mc9/k9jLm8aV6m7ofxn6t+1Fz+bWc1boQSATthpJEH K6DwUTD07+b2AofAp7ptlSJcE7ZBAp8HnPkpQkZFBLPtEVC4aE3307yDC0sUkfj2v6Aa xIJA== X-Gm-Message-State: ABy/qLZHyRnk/KUnEvD60qMEorCIoYisXzCtUVqtPmHWwlbOCY8b+i+P Z2S2bFpeGMfB5N9WYxvpnicnTemOvWUFmI5gACSyCw== X-Google-Smtp-Source: APBJJlF1wwGr3hspyNb41RaEmnIMSEb8P79fMj+m+4PqePeCSrMa2f89+1bBjbUK73iq2EIjYDHijw== X-Received: by 2002:a05:6402:51c6:b0:51e:5e3d:cb92 with SMTP id r6-20020a05640251c600b0051e5e3dcb92mr1816302edd.16.1689762224570; Wed, 19 Jul 2023 03:23:44 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id y11-20020aa7d50b000000b0051e2a4edfd5sm2484238edq.21.2023.07.19.03.23.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 03:23:44 -0700 (PDT) Message-ID: Date: Wed, 19 Jul 2023 12:23:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/5] arm64: dts: qcom: Add base SM4450 QRD DTS Content-Language: en-US To: Tengfei Fan , andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: quic_tsoni@quicinc.com, quic_shashim@quicinc.com, quic_kaushalk@quicinc.com, quic_tdas@quicinc.com, quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230719100135.21325-1-quic_tengfan@quicinc.com> <20230719100135.21325-3-quic_tengfan@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230719100135.21325-3-quic_tengfan@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/07/2023 12:01, Tengfei Fan wrote: > Add DTS for Qualcomm QRD platform which uses SM4450 SoC. > > Signed-off-by: Tengfei Fan > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 18 ++++++++++++++++++ > 2 files changed, 19 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sm4450-qrd.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 337abc4ceb17..a0cfd37e674b 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -215,3 +215,4 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx223.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx224.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8550-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8550-qrd.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb Messed order. > diff --git a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts > new file mode 100644 > index 000000000000..851a6761a6ea > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts > @@ -0,0 +1,18 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +/dts-v1/; > + > +#include "sm4450.dtsi" > +/ { > + model = "Qualcomm Technologies, Inc. SM4450 QRD"; > + compatible = "qcom,sm4450-qrd", "qcom,sm4450"; Missing bindings. > + > + aliases { }; > + > + chosen { > + bootargs = " "; Drop, useless. OTOH, you miss here several properties. This is not even a basic board - nothing works here, right? Please submit when you have at least serial working. > + }; > +}; Best regards, Krzysztof