From: Javier Martinez Canillas <javierm@redhat.com>
To: Kevin Tang <kevin3.tang@gmail.com>,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch,
robh+dt@kernel.org, mark.rutland@arm.com
Cc: devicetree@vger.kernel.org, zhang.lyra@gmail.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
lukas.bulwahn@gmail.com, orsonzhai@gmail.com, zou_wei@huawei.com,
pony1.wu@gmail.com, dan.carpenter@oracle.com
Subject: Re: [PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig
Date: Tue, 11 Jan 2022 10:11:11 +0100 [thread overview]
Message-ID: <def83410-30fa-ff9a-ac8d-6b652e314a2e@redhat.com> (raw)
In-Reply-To: <20211224141213.27612-2-kevin3.tang@gmail.com>
Hello Kevin,
On 12/24/21 15:12, Kevin Tang wrote:
> On linux-next, commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master") adds the config DRM_SPRD,
> which selects DRM_KMS_CMA_HELPER.
>
According to "The canonical patch format" section in [0], the body of the
explanation has to be line wrapped at 75 columns. But your sentences are
much longer than that.
[0]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
> However, commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") just removed the
> DRM_KMS_CMA_HELPER. So, the select DRM_KMS_CMA_HELPER refers to a non-existing kconfig symbol.
>
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> ---
Other than that, the patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-01-11 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 14:12 [PATCH v1 0/2] sprd drm cover letter Kevin Tang
2021-12-24 14:12 ` [PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig Kevin Tang
2022-01-11 9:11 ` Javier Martinez Canillas [this message]
2022-01-11 9:20 ` Thomas Zimmermann
2022-01-11 9:24 ` Lukas Bulwahn
2021-12-24 14:12 ` [PATCH v1 2/2] drm/sprd: fix potential NULL dereference Kevin Tang
2022-01-11 9:18 ` Javier Martinez Canillas
2022-01-11 9:31 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=def83410-30fa-ff9a-ac8d-6b652e314a2e@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kevin3.tang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=orsonzhai@gmail.com \
--cc=pony1.wu@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=zhang.lyra@gmail.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).