Devicetree
 help / color / mirror / Atom feed
From: Kanak Shilledar <Kanak.Shilledar@axis.com>
To: "joshua.crofts1@gmail.com" <joshua.crofts1@gmail.com>
Cc: "dlechner@baylibre.com" <dlechner@baylibre.com>,
	Henrik Grimler <Henrik.Grimler@axis.com>,
	"nuno.sa@analog.com" <nuno.sa@analog.com>,
	"jean-baptiste.maneyrol@tdk.com" <jean-baptiste.maneyrol@tdk.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"andy@kernel.org" <andy@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	Kernel <Kernel@axis.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: Add InvenSense ICM-42370-p accelerometer
Date: Fri, 7 Aug 2026 13:15:43 +0000	[thread overview]
Message-ID: <deff886f79aeb38674e090e61aa7ff45debebac8.camel@axis.com> (raw)
In-Reply-To: <20260807121619.000078c9@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

Hi,

Thanks for reviewing the code.

On Fri, 2026-08-07 at 12:16 +0200, Joshua Crofts wrote:
> [You don't often get email from joshua.crofts1@gmail.com. Learn why
> this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> On Thu, 6 Aug 2026 14:46:27 +0200
> Kanak Shilledar <kanak.shilledar@axis.com> wrote:
> 
> > +  vdd-supply:
> > +    description: Regulator operating range between 1.71V to 3.6V.
> > +
> > +  vddio-supply:
> > +    description: Regulator operating range between 1.71V to 3.6V.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> 
> vdd-supply and vddio-supply are definitely required.

Will add them in the dt-binding as well as other properties suggested
by sashiko.
> ...
> 
> > +INVENSENSE ICM-42370P ACCELEROMETER
> > +M:   Kanak Shilledar <kanak.shilledar@axis.com>
> > +M:   Henrik Grimler <henrik.grimler@axis.com>
> > +L:   linux-iio@vger.kernel.org
> 
> No need to add the IIO list as get_maintainer will automatically find
> it based on the file path. However I did notice that you have a
> company kernel mailing list, perhaps add that here?

Thanks for pointing that out. We will update it to our company kernel
mailing list (i.e., kernel@axis.com).

> --
> Kind regards,
> Joshua Crofts

Thanks and Regards,
Kanak Shilledar

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-08-07 13:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 12:46 [PATCH 0/3] Add driver for Invensense ICM42370P accelerometer Kanak Shilledar
2026-08-06 12:46 ` [PATCH 1/3] dt-bindings: Add InvenSense ICM-42370-p accelerometer Kanak Shilledar
2026-08-06 12:53   ` sashiko-bot
2026-08-07 10:16   ` Joshua Crofts
2026-08-07 13:15     ` Kanak Shilledar [this message]
2026-08-06 12:46 ` [PATCH 2/3] iio: accel: Add support for ICM42370P Kanak Shilledar
2026-08-06 13:02   ` sashiko-bot
2026-08-07  6:51   ` Uwe Kleine-König
2026-08-07 13:11     ` Kanak Shilledar
2026-08-07 10:09   ` Joshua Crofts
2026-08-07 13:41     ` Kanak Shilledar
2026-08-07 14:13       ` Joshua Crofts
2026-08-06 12:46 ` [PATCH 3/3] iio: accel: icm42370: Add FIFO buffer functionality Kanak Shilledar
2026-08-06 13:03   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=deff886f79aeb38674e090e61aa7ff45debebac8.camel@axis.com \
    --to=kanak.shilledar@axis.com \
    --cc=Henrik.Grimler@axis.com \
    --cc=Kernel@axis.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jean-baptiste.maneyrol@tdk.com \
    --cc=jic23@kernel.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox