devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Rayyan Ansari <rayyan.ansari@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: qcom: pma8084: add pon node
Date: Tue, 23 Jul 2024 13:39:12 +0200	[thread overview]
Message-ID: <df3bb042-1fb6-46ef-ad6f-1cbe0a380dd0@linaro.org> (raw)
In-Reply-To: <umsttn5qdjzg4cmgwya53la2sd57z3kxv5wo2b4nwme3jlthis@4vn3vwnlldkp>

On 23.07.2024 1:35 PM, Dmitry Baryshkov wrote:
> On Mon, Jul 22, 2024 at 12:47:57PM GMT, Rayyan Ansari wrote:
>> Wrap existing pwrkey node inside a pon node, to conform to dt schema.
>>
>> Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
>> ---
>>  arch/arm/boot/dts/qcom/pma8084.dtsi | 14 +++++++++-----
>>  1 file changed, 9 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom/pma8084.dtsi b/arch/arm/boot/dts/qcom/pma8084.dtsi
>> index 2985f4805b93..dbf7afcbfd8b 100644
>> --- a/arch/arm/boot/dts/qcom/pma8084.dtsi
>> +++ b/arch/arm/boot/dts/qcom/pma8084.dtsi
>> @@ -19,12 +19,16 @@ rtc@6000 {
>>  			interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
>>  		};
>>  
>> -		pwrkey@800 {
>> -			compatible = "qcom,pm8941-pwrkey";
>> +		pon@800 {
>> +			compatible = "qcom,pm8941-pon";
>>  			reg = <0x800>;
>> -			interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
>> -			debounce = <15625>;
>> -			bias-pull-up;
>> +
>> +			pwrkey {
>> +				compatible = "qcom,pm8941-pwrkey";
>> +				interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
>> +				debounce = <15625>;
>> +				bias-pull-up;
>> +			};
> 
> It might be worth adding the resin node too, see pm8941.dtsi

This is a cleanup series, adding features is another thing and it
would be nice if somebody could test it

Konrad

  reply	other threads:[~2024-07-23 11:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 11:47 [PATCH 0/3] arm(64): dts: qcom: fix dtbs_check warnings for qcom,spmi-pmic.yaml Rayyan Ansari
2024-07-22 11:47 ` [PATCH 1/3] arm64: dts: qcom: pmi8994: Add label to wled node Rayyan Ansari
2024-07-22 22:44   ` Konrad Dybcio
2024-07-22 11:47 ` [PATCH 2/3] arm64: dts: qcom: pmi8950: Remove address from lpg node Rayyan Ansari
2024-07-22 22:46   ` Konrad Dybcio
2024-07-22 11:47 ` [PATCH 3/3] ARM: dts: qcom: pma8084: add pon node Rayyan Ansari
2024-07-22 22:47   ` Konrad Dybcio
2024-07-23 11:35   ` Dmitry Baryshkov
2024-07-23 11:39     ` Konrad Dybcio [this message]
2024-07-23 11:45       ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df3bb042-1fb6-46ef-ad6f-1cbe0a380dd0@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rayyan.ansari@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).