[PATCH 0/3] arm(64): dts: qcom: fix dtbs_check warnings for qcom,spmi-pmic.yaml

[PATCH 0/3] arm(64): dts: qcom: fix dtbs_check warnings for qcom,spmi-pmic.yaml

[Rayyan Ansari]

Hi,
These patches fix all [1] warnings whilst running
make dtbs_check DT_SCHEMA_FILES=qcom,spmi-pmic.yaml
on both arm and arm64 qcom device trees.

[1]: There is still one warning left that was fixed by an earlier patch
by someone else, which has not been picked up: 
https://lore.kernel.org/all/20240606181027.98537-2-adrian@travitia.xyz/

Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
---
Rayyan Ansari (3):
      arm64: dts: qcom: pmi8994: Add label to wled node
      arm64: dts: qcom: pmi8950: Remove address from lpg node
      ARM: dts: qcom: pma8084: add pon node

 arch/arm/boot/dts/qcom/pma8084.dtsi   | 14 +++++++++-----
 arch/arm64/boot/dts/qcom/pmi8950.dtsi |  3 +--
 arch/arm64/boot/dts/qcom/pmi8994.dtsi |  3 +++
 3 files changed, 13 insertions(+), 7 deletions(-)
---
base-commit: dee7f101b64219f512bb2f842227bd04c14efe30
change-id: 20240722-pmic-bindings-756df58afa15

Best regards,
-- 
Rayyan Ansari <rayyan.ansari@linaro.org>

[PATCH 1/3] arm64: dts: qcom: pmi8994: Add label to wled node

[Rayyan Ansari]

Add a label, which is a required property, to the wled node.

Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
---
 arch/arm64/boot/dts/qcom/pmi8994.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
index 36d6a1fb553a..9ee59e6d2cdb 100644
--- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
@@ -57,8 +57,11 @@ pmi8994_wled: wled@d800 {
 			interrupts = <0x3 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
 				     <0x3 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
 			interrupt-names = "ovp", "short";
+			label = "backlight";
+
 			qcom,cabc;
 			qcom,external-pfet;
+
 			status = "disabled";
 		};
 	};

-- 
2.45.2

Re: [PATCH 1/3] arm64: dts: qcom: pmi8994: Add label to wled node

[Konrad Dybcio]

On 22.07.2024 1:47 PM, Rayyan Ansari wrote:
> Add a label, which is a required property, to the wled node.
> 
> Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
> ---

The driver can still handle it lacking, but let's respect the
bindings

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

[PATCH 2/3] arm64: dts: qcom: pmi8950: Remove address from lpg node

[Rayyan Ansari]

Remove the address in both the reg property and node name, as it is
hardcoded in the driver, meaning it is unneeded.

Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
---
 arch/arm64/boot/dts/qcom/pmi8950.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
index b4822cb17a37..4aff437263a2 100644
--- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
@@ -84,9 +84,8 @@ pmic@3 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		pmi8950_pwm: pwm@b000 {
+		pmi8950_pwm: pwm {
 			compatible = "qcom,pmi8950-pwm";
-			reg = <0xb000 0x100>;
 			#pwm-cells = <2>;
 
 			status = "disabled";

-- 
2.45.2

Re: [PATCH 2/3] arm64: dts: qcom: pmi8950: Remove address from lpg node

[Konrad Dybcio]

On 22.07.2024 1:47 PM, Rayyan Ansari wrote:
> Remove the address in both the reg property and node name, as it is
> hardcoded in the driver, meaning it is unneeded.
> 
> Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
> ---

Well the bindings are opaque to the implementation, and the commit
message could reference adhering to those instead

The contents are fine

[PATCH 3/3] ARM: dts: qcom: pma8084: add pon node

[Rayyan Ansari]

Wrap existing pwrkey node inside a pon node, to conform to dt schema.

Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
---
 arch/arm/boot/dts/qcom/pma8084.dtsi | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/qcom/pma8084.dtsi b/arch/arm/boot/dts/qcom/pma8084.dtsi
index 2985f4805b93..dbf7afcbfd8b 100644
--- a/arch/arm/boot/dts/qcom/pma8084.dtsi
+++ b/arch/arm/boot/dts/qcom/pma8084.dtsi
@@ -19,12 +19,16 @@ rtc@6000 {
 			interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
 		};
 
-		pwrkey@800 {
-			compatible = "qcom,pm8941-pwrkey";
+		pon@800 {
+			compatible = "qcom,pm8941-pon";
 			reg = <0x800>;
-			interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
-			debounce = <15625>;
-			bias-pull-up;
+
+			pwrkey {
+				compatible = "qcom,pm8941-pwrkey";
+				interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
+				debounce = <15625>;
+				bias-pull-up;
+			};
 		};
 
 		pma8084_gpios: gpio@c000 {

-- 
2.45.2

Re: [PATCH 3/3] ARM: dts: qcom: pma8084: add pon node

[Konrad Dybcio]

On 22.07.2024 1:47 PM, Rayyan Ansari wrote:
> Wrap existing pwrkey node inside a pon node, to conform to dt schema.
> 
> Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

might also wanna polish it up so that KEY_POWER is assigned

Konrad

Re: [PATCH 3/3] ARM: dts: qcom: pma8084: add pon node

[Dmitry Baryshkov]

On Mon, Jul 22, 2024 at 12:47:57PM GMT, Rayyan Ansari wrote:
> Wrap existing pwrkey node inside a pon node, to conform to dt schema.
> 
> Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
> ---
>  arch/arm/boot/dts/qcom/pma8084.dtsi | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom/pma8084.dtsi b/arch/arm/boot/dts/qcom/pma8084.dtsi
> index 2985f4805b93..dbf7afcbfd8b 100644
> --- a/arch/arm/boot/dts/qcom/pma8084.dtsi
> +++ b/arch/arm/boot/dts/qcom/pma8084.dtsi
> @@ -19,12 +19,16 @@ rtc@6000 {
>  			interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
>  		};
>  
> -		pwrkey@800 {
> -			compatible = "qcom,pm8941-pwrkey";
> +		pon@800 {
> +			compatible = "qcom,pm8941-pon";
>  			reg = <0x800>;
> -			interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> -			debounce = <15625>;
> -			bias-pull-up;
> +
> +			pwrkey {
> +				compatible = "qcom,pm8941-pwrkey";
> +				interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> +				debounce = <15625>;
> +				bias-pull-up;
> +			};

It might be worth adding the resin node too, see pm8941.dtsi

>  		};
>  
>  		pma8084_gpios: gpio@c000 {
> 
> -- 
> 2.45.2
> 

-- 
With best wishes
Dmitry

Re: [PATCH 3/3] ARM: dts: qcom: pma8084: add pon node

[Konrad Dybcio]

On 23.07.2024 1:35 PM, Dmitry Baryshkov wrote:
> On Mon, Jul 22, 2024 at 12:47:57PM GMT, Rayyan Ansari wrote:
>> Wrap existing pwrkey node inside a pon node, to conform to dt schema.
>>
>> Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
>> ---
>>  arch/arm/boot/dts/qcom/pma8084.dtsi | 14 +++++++++-----
>>  1 file changed, 9 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom/pma8084.dtsi b/arch/arm/boot/dts/qcom/pma8084.dtsi
>> index 2985f4805b93..dbf7afcbfd8b 100644
>> --- a/arch/arm/boot/dts/qcom/pma8084.dtsi
>> +++ b/arch/arm/boot/dts/qcom/pma8084.dtsi
>> @@ -19,12 +19,16 @@ rtc@6000 {
>>  			interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
>>  		};
>>  
>> -		pwrkey@800 {
>> -			compatible = "qcom,pm8941-pwrkey";
>> +		pon@800 {
>> +			compatible = "qcom,pm8941-pon";
>>  			reg = <0x800>;
>> -			interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
>> -			debounce = <15625>;
>> -			bias-pull-up;
>> +
>> +			pwrkey {
>> +				compatible = "qcom,pm8941-pwrkey";
>> +				interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
>> +				debounce = <15625>;
>> +				bias-pull-up;
>> +			};
> 
> It might be worth adding the resin node too, see pm8941.dtsi

This is a cleanup series, adding features is another thing and it
would be nice if somebody could test it

Konrad

Re: [PATCH 3/3] ARM: dts: qcom: pma8084: add pon node

[Dmitry Baryshkov]

On Tue, 23 Jul 2024 at 14:39, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On 23.07.2024 1:35 PM, Dmitry Baryshkov wrote:
> > On Mon, Jul 22, 2024 at 12:47:57PM GMT, Rayyan Ansari wrote:
> >> Wrap existing pwrkey node inside a pon node, to conform to dt schema.
> >>
> >> Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
> >> ---
> >>  arch/arm/boot/dts/qcom/pma8084.dtsi | 14 +++++++++-----
> >>  1 file changed, 9 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/qcom/pma8084.dtsi b/arch/arm/boot/dts/qcom/pma8084.dtsi
> >> index 2985f4805b93..dbf7afcbfd8b 100644
> >> --- a/arch/arm/boot/dts/qcom/pma8084.dtsi
> >> +++ b/arch/arm/boot/dts/qcom/pma8084.dtsi
> >> @@ -19,12 +19,16 @@ rtc@6000 {
> >>                      interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
> >>              };
> >>
> >> -            pwrkey@800 {
> >> -                    compatible = "qcom,pm8941-pwrkey";
> >> +            pon@800 {
> >> +                    compatible = "qcom,pm8941-pon";
> >>                      reg = <0x800>;
> >> -                    interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> >> -                    debounce = <15625>;
> >> -                    bias-pull-up;
> >> +
> >> +                    pwrkey {
> >> +                            compatible = "qcom,pm8941-pwrkey";
> >> +                            interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> >> +                            debounce = <15625>;
> >> +                            bias-pull-up;
> >> +                    };
> >
> > It might be worth adding the resin node too, see pm8941.dtsi
>
> This is a cleanup series, adding features is another thing and it
> would be nice if somebody could test it

Agreed.


-- 
With best wishes
Dmitry