From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C009C77B73 for ; Sun, 16 Apr 2023 15:20:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230433AbjDPPUL (ORCPT ); Sun, 16 Apr 2023 11:20:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229584AbjDPPUK (ORCPT ); Sun, 16 Apr 2023 11:20:10 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 131272134 for ; Sun, 16 Apr 2023 08:20:08 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id ud9so57669915ejc.7 for ; Sun, 16 Apr 2023 08:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681658406; x=1684250406; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rbAN5WU56B4VEiB1VFsqC9Gu1Swjc+C/BnQGH/MXxU8=; b=vFZZkIacIl8160Edsrq6FQgdswWD0NbURlNL8AaHAfXEcNIcP6KSIWDgMY4FSOloem XT/l6aZi+ZuEmbaliOaA/5H0K+gifvsizmgsSc0BW60VXrVuvNCvf6ojgqPq7NJx9muA Dsr9+aIDlAqdhe9X7ca1vD4gfVi2qIFSR4x1HreKcoyuZETpLrczwLOD1DpP/ecie4mS 7strxWiKY+PzJbXnsZ+xGK3pckrJZNbSvKSyG+R6U+cQhM8WOdBDLK418/n0Adr90jIq Q7rxJGhyHH1R+uwWq60OzhS4BYwlgEkWDPNTdZ4AL/sGQUYIu3N0caiv3B3Ft1FSkoCa DBZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681658406; x=1684250406; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rbAN5WU56B4VEiB1VFsqC9Gu1Swjc+C/BnQGH/MXxU8=; b=JChBq/7q3IzRMLEmFCMuPJHvfXkxZgvwoD7NZ/jrgu3Qo/98kzWe5cBNkYTJvEKm8j SAhYVMQh49BQwlwPIek35ivuVlFCUXplQ+M5VeSw78GfEBP7digPsQNNrWyo6vD2bWzf MBKS75748X6NhoJ4Lr1oJWZ+ioqKSW0tbEWKQP2hNVNpDpWA5J1YGkQcrULY2eTr1BcI o/Irf4DHUz7Hv61+6hML4hrTXf05K2Sx5k5VH3Np7qqtZKHYE+tqwWJnvBq4WyMb7MHb Zkle/f9b66Yj3146u9cLnlWxeQo6K1Iq8OKho5dOm6P82NfpP0QlUO21T+MdC3pds3iA PqfA== X-Gm-Message-State: AAQBX9fnkWzki++ZgcHsaI+Rwzeat3P1cUV1TulTAXmK+5u0lLsW/XMo uslvFyL5Q3ap9YZHP1Lv9CzliQ== X-Google-Smtp-Source: AKy350ajHtRg1Jzq0HB8HI0deyaXSVS4/EcdAvXZXdc0qq6IDelZKY32JGmq5Y7NUAuRGGimi3ZFBQ== X-Received: by 2002:a17:906:bc42:b0:94f:5e17:e80d with SMTP id s2-20020a170906bc4200b0094f5e17e80dmr1786236ejv.45.1681658406502; Sun, 16 Apr 2023 08:20:06 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:ba4d:301c:484d:5c9? ([2a02:810d:15c0:828:ba4d:301c:484d:5c9]) by smtp.gmail.com with ESMTPSA id d9-20020a17090648c900b0094f4f2db7e0sm1049358ejt.143.2023.04.16.08.20.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Apr 2023 08:20:06 -0700 (PDT) Message-ID: Date: Sun, 16 Apr 2023 17:20:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 3/4] dt-bindings: power: reset: convert nvmem-reboot-mode bindings to YAML Content-Language: en-US To: Bartosz Golaszewski , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Catalin Marinas , Will Deacon , Arnd Bergmann Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski References: <20230413131705.3073911-1-brgl@bgdev.pl> <20230413131705.3073911-4-brgl@bgdev.pl> From: Krzysztof Kozlowski In-Reply-To: <20230413131705.3073911-4-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/04/2023 15:17, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Convert the DT binding document for nvmem-reboot-mode from .txt to YAML. Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml > new file mode 100644 > index 000000000000..64a7d224c7dd > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/reset/nvmem-reboot-mode.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic NVMEM reboot mode driver Drop "driver". > + > +maintainers: > + - Bartosz Golaszewski > + > +description: | Do not need '|' unless you need to preserve formatting. > + This driver gets the reboot mode magic value from the reboot-mode driver > + and stores it in the NVMEM cell named "reboot-mode". The bootloader can > + then read it and take different action according to the value. > + > +properties: > + compatible: > + const: nvmem-reboot-mode > + > + nvmem-cells: > + description: | Do not need '|' unless you need to preserve formatting. > + A phandle pointing to the nvmem-cells node where the vendor-specific > + magic value representing the reboot mode is stored. > + maxItems: 1 > + > + nvmem-cell-names: > + items: > + - const: reboot-mode > + > +patternProperties: > + "^mode-.+": > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Vendor-specific mode value written to the mode register > + > +additionalProperties: false > + > +required: > + - compatible > + - nvmem-cells > + - nvmem-cell-names put required: before additionalProperties Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof