* [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema
@ 2022-12-24 15:42 Krzysztof Kozlowski
2022-12-24 15:42 ` [PATCH 2/5] arm64: dts: qcom: sm6125: re-order USB2 phy clocks Krzysztof Kozlowski
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-24 15:42 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The node names should be generic and the bindings expect "bus" for
simple-bus nodes:
msm8996-mtp.dtb: agnoc@0: $nodename:0: 'agnoc@0' does not match '^bus(@[0-9a-f]+)?$'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index c53018ca81d7..cf2f5b74a4c2 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -1814,7 +1814,7 @@ spmi_bus: spmi@400f000 {
#interrupt-cells = <4>;
};
- agnoc@0 {
+ bus@0 {
power-domains = <&gcc AGGRE0_NOC_GDSC>;
compatible = "simple-pm-bus";
#address-cells = <1>;
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/5] arm64: dts: qcom: sm6125: re-order USB2 phy clocks
2022-12-24 15:42 [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Krzysztof Kozlowski
@ 2022-12-24 15:42 ` Krzysztof Kozlowski
2022-12-25 22:16 ` Marijn Suijten
2022-12-24 15:42 ` [PATCH 3/5] arm64: dts: qcom: sm8250: drop unused clock-frequency from va-macro Krzysztof Kozlowski
` (4 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-24 15:42 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings expect USB2 phy clocks in other order:
sm6125-sony-xperia-seine-pdx201.dtb: phy@1613000: clock-names:1: 'ref' was expected
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6125.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
index 7e25a4f85594..bf9e8d45ee44 100644
--- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
@@ -442,9 +442,9 @@ hsusb_phy1: phy@1613000 {
reg = <0x01613000 0x180>;
#phy-cells = <0>;
- clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>,
- <&gcc GCC_AHB2PHY_USB_CLK>;
- clock-names = "ref", "cfg_ahb";
+ clocks = <&gcc GCC_AHB2PHY_USB_CLK>,
+ <&rpmcc RPM_SMD_XO_CLK_SRC>;
+ clock-names = "cfg_ahb", "ref";
resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>;
status = "disabled";
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/5] arm64: dts: qcom: sm8250: drop unused clock-frequency from va-macro
2022-12-24 15:42 [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Krzysztof Kozlowski
2022-12-24 15:42 ` [PATCH 2/5] arm64: dts: qcom: sm6125: re-order USB2 phy clocks Krzysztof Kozlowski
@ 2022-12-24 15:42 ` Krzysztof Kozlowski
2022-12-27 11:21 ` Konrad Dybcio
2022-12-24 15:42 ` [PATCH 4/5] arm64: dts: qcom: sm8450: re-order GCC clocks Krzysztof Kozlowski
` (3 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-24 15:42 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Neither qcom,sm8250-lpass-va-macro bindings nor the driver use
"clock-frequency" property.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index b5c51203672e..b5920d8a89af 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2263,7 +2263,6 @@ vamacro: codec@3370000 {
clock-names = "mclk", "macro", "dcodec";
#clock-cells = <0>;
- clock-frequency = <9600000>;
clock-output-names = "fsgen";
#sound-dai-cells = <1>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/5] arm64: dts: qcom: sm8450: re-order GCC clocks
2022-12-24 15:42 [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Krzysztof Kozlowski
2022-12-24 15:42 ` [PATCH 2/5] arm64: dts: qcom: sm6125: re-order USB2 phy clocks Krzysztof Kozlowski
2022-12-24 15:42 ` [PATCH 3/5] arm64: dts: qcom: sm8250: drop unused clock-frequency from va-macro Krzysztof Kozlowski
@ 2022-12-24 15:42 ` Krzysztof Kozlowski
2022-12-27 11:21 ` Konrad Dybcio
2022-12-24 15:42 ` [PATCH 5/5] arm64: dts: qcom: use generic node name for CS35L41 speaker Krzysztof Kozlowski
` (2 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-24 15:42 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings expect GCC clocks in other order:
sm8450-hdk.dtb: clock-controller@100000: clock-names:1: 'sleep_clk' was expected
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index e1df3dad70fb..bb84bf3899b5 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -731,13 +731,13 @@ gcc: clock-controller@100000 {
#reset-cells = <1>;
#power-domain-cells = <1>;
clocks = <&rpmhcc RPMH_CXO_CLK>,
+ <&sleep_clk>,
<&pcie0_lane>,
- <&pcie1_lane>,
- <&sleep_clk>;
+ <&pcie1_lane>;
clock-names = "bi_tcxo",
+ "sleep_clk",
"pcie_0_pipe_clk",
- "pcie_1_pipe_clk",
- "sleep_clk";
+ "pcie_1_pipe_clk";
};
gpi_dma2: dma-controller@800000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 5/5] arm64: dts: qcom: use generic node name for CS35L41 speaker
2022-12-24 15:42 [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-12-24 15:42 ` [PATCH 4/5] arm64: dts: qcom: sm8450: re-order GCC clocks Krzysztof Kozlowski
@ 2022-12-24 15:42 ` Krzysztof Kozlowski
2022-12-27 11:22 ` Konrad Dybcio
2022-12-27 11:22 ` [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Konrad Dybcio
2022-12-29 17:23 ` (subset) " Bjorn Andersson
5 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-24 15:42 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Node names should be generic so use consistently speaker-amp for CS35L41
speaker amplifier.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 4 ++--
arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
index 09a31f707639..25c3e02f224b 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
@@ -454,7 +454,7 @@ &i2c2 {
status = "okay";
clock-frequency = <1000000>;
- cs35l41_l: cs35l41@40 {
+ cs35l41_l: speaker-amp@40 {
compatible = "cirrus,cs35l41";
reg = <0x40>;
interrupt-parent = <&tlmm>;
@@ -469,7 +469,7 @@ cs35l41_l: cs35l41@40 {
#sound-dai-cells = <1>;
};
- cs35l41_r: cs35l41@41 {
+ cs35l41_r: speaker-amp@41 {
compatible = "cirrus,cs35l41";
reg = <0x41>;
interrupt-parent = <&tlmm>;
diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
index 1f2d660f8f86..4862fd69413e 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
@@ -461,7 +461,7 @@ &i2c11 {
status = "okay";
clock-frequency = <1000000>;
- cs35l41_l: cs35l41@40 {
+ cs35l41_l: speaker-amp@40 {
compatible = "cirrus,cs35l41";
reg = <0x40>;
interrupt-parent = <&tlmm>;
@@ -476,7 +476,7 @@ cs35l41_l: cs35l41@40 {
#sound-dai-cells = <1>;
};
- cs35l41_r: cs35l41@41 {
+ cs35l41_r: speaker-amp@41 {
compatible = "cirrus,cs35l41";
reg = <0x41>;
interrupt-parent = <&tlmm>;
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 2/5] arm64: dts: qcom: sm6125: re-order USB2 phy clocks
2022-12-24 15:42 ` [PATCH 2/5] arm64: dts: qcom: sm6125: re-order USB2 phy clocks Krzysztof Kozlowski
@ 2022-12-25 22:16 ` Marijn Suijten
0 siblings, 0 replies; 11+ messages in thread
From: Marijn Suijten @ 2022-12-25 22:16 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On 2022-12-24 16:42:52, Krzysztof Kozlowski wrote:
> Bindings expect USB2 phy clocks in other order:
>
> sm6125-sony-xperia-seine-pdx201.dtb: phy@1613000: clock-names:1: 'ref' was expected
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This was already sent last week as:
https://lore.kernel.org/linux-arm-msm/20221216213343.1140143-1-marijn.suijten@somainline.org/
- Marijn
> ---
> arch/arm64/boot/dts/qcom/sm6125.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> index 7e25a4f85594..bf9e8d45ee44 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> @@ -442,9 +442,9 @@ hsusb_phy1: phy@1613000 {
> reg = <0x01613000 0x180>;
> #phy-cells = <0>;
>
> - clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>,
> - <&gcc GCC_AHB2PHY_USB_CLK>;
> - clock-names = "ref", "cfg_ahb";
> + clocks = <&gcc GCC_AHB2PHY_USB_CLK>,
> + <&rpmcc RPM_SMD_XO_CLK_SRC>;
> + clock-names = "cfg_ahb", "ref";
>
> resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>;
> status = "disabled";
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/5] arm64: dts: qcom: sm8250: drop unused clock-frequency from va-macro
2022-12-24 15:42 ` [PATCH 3/5] arm64: dts: qcom: sm8250: drop unused clock-frequency from va-macro Krzysztof Kozlowski
@ 2022-12-27 11:21 ` Konrad Dybcio
0 siblings, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2022-12-27 11:21 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On 24.12.2022 16:42, Krzysztof Kozlowski wrote:
> Neither qcom,sm8250-lpass-va-macro bindings nor the driver use
> "clock-frequency" property.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index b5c51203672e..b5920d8a89af 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2263,7 +2263,6 @@ vamacro: codec@3370000 {
> clock-names = "mclk", "macro", "dcodec";
>
> #clock-cells = <0>;
> - clock-frequency = <9600000>;
> clock-output-names = "fsgen";
> #sound-dai-cells = <1>;
> };
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/5] arm64: dts: qcom: sm8450: re-order GCC clocks
2022-12-24 15:42 ` [PATCH 4/5] arm64: dts: qcom: sm8450: re-order GCC clocks Krzysztof Kozlowski
@ 2022-12-27 11:21 ` Konrad Dybcio
0 siblings, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2022-12-27 11:21 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On 24.12.2022 16:42, Krzysztof Kozlowski wrote:
> Bindings expect GCC clocks in other order:
>
> sm8450-hdk.dtb: clock-controller@100000: clock-names:1: 'sleep_clk' was expected
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index e1df3dad70fb..bb84bf3899b5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -731,13 +731,13 @@ gcc: clock-controller@100000 {
> #reset-cells = <1>;
> #power-domain-cells = <1>;
> clocks = <&rpmhcc RPMH_CXO_CLK>,
> + <&sleep_clk>,
> <&pcie0_lane>,
> - <&pcie1_lane>,
> - <&sleep_clk>;
> + <&pcie1_lane>;
> clock-names = "bi_tcxo",
> + "sleep_clk",
> "pcie_0_pipe_clk",
> - "pcie_1_pipe_clk",
> - "sleep_clk";
> + "pcie_1_pipe_clk";
> };
>
> gpi_dma2: dma-controller@800000 {
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 5/5] arm64: dts: qcom: use generic node name for CS35L41 speaker
2022-12-24 15:42 ` [PATCH 5/5] arm64: dts: qcom: use generic node name for CS35L41 speaker Krzysztof Kozlowski
@ 2022-12-27 11:22 ` Konrad Dybcio
0 siblings, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2022-12-27 11:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On 24.12.2022 16:42, Krzysztof Kozlowski wrote:
> Node names should be generic so use consistently speaker-amp for CS35L41
> speaker amplifier.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> index 09a31f707639..25c3e02f224b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> @@ -454,7 +454,7 @@ &i2c2 {
> status = "okay";
> clock-frequency = <1000000>;
>
> - cs35l41_l: cs35l41@40 {
> + cs35l41_l: speaker-amp@40 {
> compatible = "cirrus,cs35l41";
> reg = <0x40>;
> interrupt-parent = <&tlmm>;
> @@ -469,7 +469,7 @@ cs35l41_l: cs35l41@40 {
> #sound-dai-cells = <1>;
> };
>
> - cs35l41_r: cs35l41@41 {
> + cs35l41_r: speaker-amp@41 {
> compatible = "cirrus,cs35l41";
> reg = <0x41>;
> interrupt-parent = <&tlmm>;
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> index 1f2d660f8f86..4862fd69413e 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> @@ -461,7 +461,7 @@ &i2c11 {
> status = "okay";
> clock-frequency = <1000000>;
>
> - cs35l41_l: cs35l41@40 {
> + cs35l41_l: speaker-amp@40 {
> compatible = "cirrus,cs35l41";
> reg = <0x40>;
> interrupt-parent = <&tlmm>;
> @@ -476,7 +476,7 @@ cs35l41_l: cs35l41@40 {
> #sound-dai-cells = <1>;
> };
>
> - cs35l41_r: cs35l41@41 {
> + cs35l41_r: speaker-amp@41 {
> compatible = "cirrus,cs35l41";
> reg = <0x41>;
> interrupt-parent = <&tlmm>;
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema
2022-12-24 15:42 [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Krzysztof Kozlowski
` (3 preceding siblings ...)
2022-12-24 15:42 ` [PATCH 5/5] arm64: dts: qcom: use generic node name for CS35L41 speaker Krzysztof Kozlowski
@ 2022-12-27 11:22 ` Konrad Dybcio
2022-12-29 17:23 ` (subset) " Bjorn Andersson
5 siblings, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2022-12-27 11:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On 24.12.2022 16:42, Krzysztof Kozlowski wrote:
> The node names should be generic and the bindings expect "bus" for
> simple-bus nodes:
>
> msm8996-mtp.dtb: agnoc@0: $nodename:0: 'agnoc@0' does not match '^bus(@[0-9a-f]+)?$'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index c53018ca81d7..cf2f5b74a4c2 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1814,7 +1814,7 @@ spmi_bus: spmi@400f000 {
> #interrupt-cells = <4>;
> };
>
> - agnoc@0 {
> + bus@0 {
> power-domains = <&gcc AGGRE0_NOC_GDSC>;
> compatible = "simple-pm-bus";
Mind sending a separate patch to move compatible up on this one?
Konrad
> #address-cells = <1>;
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: (subset) [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema
2022-12-24 15:42 [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Krzysztof Kozlowski
` (4 preceding siblings ...)
2022-12-27 11:22 ` [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Konrad Dybcio
@ 2022-12-29 17:23 ` Bjorn Andersson
5 siblings, 0 replies; 11+ messages in thread
From: Bjorn Andersson @ 2022-12-29 17:23 UTC (permalink / raw)
To: agross, Krzysztof Kozlowski, linux-arm-msm, robh+dt,
krzysztof.kozlowski+dt, linux-kernel, konrad.dybcio, devicetree
On Sat, 24 Dec 2022 16:42:51 +0100, Krzysztof Kozlowski wrote:
> The node names should be generic and the bindings expect "bus" for
> simple-bus nodes:
>
> msm8996-mtp.dtb: agnoc@0: $nodename:0: 'agnoc@0' does not match '^bus(@[0-9a-f]+)?$'
>
>
Applied, thanks!
[1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema
commit: 496b308f0988f3fb610073e125da8ef8065b334f
[3/5] arm64: dts: qcom: sm8250: drop unused clock-frequency from va-macro
commit: 42db0f72f7a8c33501a55537ac90557a665a56f8
[4/5] arm64: dts: qcom: sm8450: re-order GCC clocks
commit: 539a9923683c79e6925dd69a2e2534ec197361c7
[5/5] arm64: dts: qcom: use generic node name for CS35L41 speaker
commit: 9e8e9be6c499d3dfa408b7306004c4b981622ff1
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-12-29 17:24 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-24 15:42 [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Krzysztof Kozlowski
2022-12-24 15:42 ` [PATCH 2/5] arm64: dts: qcom: sm6125: re-order USB2 phy clocks Krzysztof Kozlowski
2022-12-25 22:16 ` Marijn Suijten
2022-12-24 15:42 ` [PATCH 3/5] arm64: dts: qcom: sm8250: drop unused clock-frequency from va-macro Krzysztof Kozlowski
2022-12-27 11:21 ` Konrad Dybcio
2022-12-24 15:42 ` [PATCH 4/5] arm64: dts: qcom: sm8450: re-order GCC clocks Krzysztof Kozlowski
2022-12-27 11:21 ` Konrad Dybcio
2022-12-24 15:42 ` [PATCH 5/5] arm64: dts: qcom: use generic node name for CS35L41 speaker Krzysztof Kozlowski
2022-12-27 11:22 ` Konrad Dybcio
2022-12-27 11:22 ` [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Konrad Dybcio
2022-12-29 17:23 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).