From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Adam Ford <aford173@gmail.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: imx8mn: Use single port for ISI
Date: Thu, 29 Feb 2024 19:15:34 +0100 [thread overview]
Message-ID: <df7f2b66-fd16-433a-b55b-ea8dc807fd96@linaro.org> (raw)
In-Reply-To: <CAHCN7xJ7uGXL6BF7CCvtqVQHy8X+x5nxJc+HS2_Mkd=EBT2g5Q@mail.gmail.com>
On 23/02/2024 16:29, Adam Ford wrote:
> On Fri, Feb 23, 2024 at 8:09 AM Alexander Stein <
> alexander.stein@ew.tq-group.com> wrote:
>
>> The ISI on i.MX8M Nano only has one port/channel, so use the single port
>> node. Fixes the DTBS_CHECK warning:
>> /soc@0/bus@32c00000/isi@32e20000/ports: graph node has single child node
>> 'port@0', #address-cells/#size-cells are not necessary
>>
>>
> Should we add fixes tags to both the bindings and the dts?
>
> adam
No, because original code is correct and we are just choosing here one
style over another. "style" fixes should not be backported.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-02-29 18:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 14:04 [PATCH 0/3] i.MX8M Nano ISI single port support Alexander Stein
2024-02-23 14:04 ` [PATCH 1/3] media: dt-bindings: nxp,imx8-isi: Refuse port@1 for single pipeline models Alexander Stein
2024-02-29 18:05 ` Krzysztof Kozlowski
2024-02-23 14:04 ` [PATCH 2/3] media: dt-bindings: nxp,imx8-isi: Allow single port " Alexander Stein
2024-02-23 14:16 ` Laurent Pinchart
2024-02-23 14:17 ` Laurent Pinchart
2024-02-29 18:14 ` Krzysztof Kozlowski
2024-02-29 18:18 ` Krzysztof Kozlowski
2024-03-01 8:32 ` [PATCH 2/3] media: dt-bindings: nxp, imx8-isi: " Alexander Stein
2024-03-01 8:49 ` Krzysztof Kozlowski
2024-03-01 21:11 ` [PATCH 2/3] media: dt-bindings: nxp,imx8-isi: " Rob Herring
2024-02-23 14:04 ` [PATCH 3/3] arm64: dts: imx8mn: Use single port for ISI Alexander Stein
[not found] ` <CAHCN7xJ7uGXL6BF7CCvtqVQHy8X+x5nxJc+HS2_Mkd=EBT2g5Q@mail.gmail.com>
2024-02-29 18:15 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df7f2b66-fd16-433a-b55b-ea8dc807fd96@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aford173@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).