From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MLFYi+yd" Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83BEC126 for ; Thu, 14 Dec 2023 08:07:31 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-55202565d48so2015070a12.0 for ; Thu, 14 Dec 2023 08:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702570050; x=1703174850; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wCm7hm2Q32RWzxlkJWAENcxDAOzqYtnHB2jwyu8n2FI=; b=MLFYi+yd2EMzqrBTvc+mjyHDyl3M4xvm5L5lrBaeYGkD0XWYMPx61eeRvunSxTpQCb cNzpQ+4u7nVqgM2P9eFGFvm/NNmNQnH8c65wPM5GvHrUV/PypJbCctuAflcu8tMo81yo SbAZAEyTebGLvyz0ilyk92ghxNav3AF2i2pQySqdQc2OmoSzj4GvNJ79eqZv5zxuPHVG Mr2c84QxlPyvlFLscMvCQkzN88uQb3FpW0ERUnOnYFZTbbnGpMktMCrqDFTjWSjdFdRR vHq2l1jCgm8WD/fkRQsRbxwfEwT/4yJokKzFjy9KC1YoWS+8ioZhDlcdkx9lTFYdnt5D HIzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702570050; x=1703174850; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wCm7hm2Q32RWzxlkJWAENcxDAOzqYtnHB2jwyu8n2FI=; b=CyGbmKsshHOS7NtljtdRMI7h0tIlhUTkijPzzdBJAqIFY4BIomj05cU8GuqBCNzXOV bSGxiIbzzpt903Vt2/Fp17du7AFv/ky6cKkLvLyuOWSNP6YAtZVZzyfr3/CQzWx/q2bA B4eRxDRVJQxznGrzsjb2QB+YXvlmkONxV/iZzdeveiJTOkmPQFzioYRy2OXy5KsWg+Nr 0ahhMuDLDy5CrTHM9rOMWe2WrMcXTMEneaG5uC/SKY/V3Gqhw2+W+KnG1/5z+2QZ5pGg mx3/Cb8csjWafvHS6Sw4beRMBoQvDmvYQ2W4AB5OaSzKiqfCx/EXtFLLyPRzIEQNe2rP aCMA== X-Gm-Message-State: AOJu0Yw/GdRMcTjFR9YDXRL7LtUZil3jXj745Eib+nkiq/m4E8ZNFRbJ kQ62HiW00vJIamMeme5IzdvKze3MsL6L3gx21iA= X-Google-Smtp-Source: AGHT+IFIV8hHhs6BCYx/j/vneSUxeIC9+OrWm+pf+Q9EE92p6Ls2acv5BezkB8jCS4UoaeEobNeifQ== X-Received: by 2002:a50:d785:0:b0:551:49af:b362 with SMTP id w5-20020a50d785000000b0055149afb362mr2636354edi.78.1702570049932; Thu, 14 Dec 2023 08:07:29 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id a4-20020a509e84000000b0054ccc3b2109sm7126498edf.57.2023.12.14.08.07.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Dec 2023 08:07:29 -0800 (PST) Message-ID: Date: Thu, 14 Dec 2023 17:07:27 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/11] dt-bindings: display: rockchip,inno-hdmi: Document RK3128 compatible Content-Language: en-US To: Alex Bee , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: David Airlie , Daniel Vetter , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231213195125.212923-1-knaerzche@gmail.com> <20231213195125.212923-2-knaerzche@gmail.com> <288857ab-bebd-4f80-9cdc-9b04fa6c7386@gmail.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <288857ab-bebd-4f80-9cdc-9b04fa6c7386@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 14/12/2023 16:22, Alex Bee wrote: > > Am 14.12.23 um 08:53 schrieb Krzysztof Kozlowski: >> On 13/12/2023 20:51, Alex Bee wrote: >>> Document the compatible for RK3128's HDMI controller block. >>> The integration for this SoC is somewhat different here: It needs the PHY's >> Please wrap commit message according to Linux coding style / submission >> process (neither too early nor over the limit): >> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > OK. Not sure why checkpatch --strict  didn't tell me that I'm over the > limit here. >> >>> reference clock rate to calculate the ddc bus frequency correctly. This >>> clock is part of a power-domain (PD_VIO), so this gets added as an optional >>> property too. >> If clock is part of power domain, then the power domain must be in the >> clock controller, not here. So either you put power domain in wrong >> place or you used incorrect reason for a change. >  Rockchip defines it's powerdomains per clock and I was little to much > in that world when writing this. Actually the controller itself is part > of the powerdomain. Will rephrase. Does it mean you have like 200 different power domains in one SoC? Then how are they different than clock if there is one-to-one mapping? >>> Signed-off-by: Alex Bee >>> --- >>> .../display/rockchip/rockchip,inno-hdmi.yaml | 30 +++++++++++++++++-- >>> 1 file changed, 28 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,inno-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,inno-hdmi.yaml >>> index 96889c86849a..9f00abcbfb38 100644 >>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,inno-hdmi.yaml >>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,inno-hdmi.yaml >>> @@ -14,6 +14,7 @@ properties: >>> compatible: >>> enum: >>> - rockchip,rk3036-inno-hdmi >>> + - rockchip,rk3128-inno-hdmi >>> >>> reg: >>> maxItems: 1 >>> @@ -22,10 +23,21 @@ properties: >>> maxItems: 1 >>> >>> clocks: >>> - maxItems: 1 >>> + minItems: 1 >>> + items: >>> + - description: The HDMI controller main clock >>> + - description: The HDMI PHY reference clock >>> >>> clock-names: >>> - const: pclk >>> + minItems: 1 >>> + items: >>> + - const: pclk >>> + - enum: >>> + - pclk >>> + - ref >> That's way overcomplicated. Just items listing the names and minItems: >> 1. See other bindings how this is done. > OK. >>> + >>> + power-domains: >>> + maxItems: 1 >> Is it relevant to existing device? > > Will move to new variant only. > Definition should be here, but in if:then: it should be disallowed (:false) for other variants. Best regards, Krzysztof