From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F677C77B7D for ; Mon, 15 May 2023 11:29:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240784AbjEOL3i (ORCPT ); Mon, 15 May 2023 07:29:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238998AbjEOL3g (ORCPT ); Mon, 15 May 2023 07:29:36 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07043F1; Mon, 15 May 2023 04:29:34 -0700 (PDT) Received: from [IPV6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab] (unknown [IPv6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3FEC866031D7; Mon, 15 May 2023 12:29:32 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1684150173; bh=LalSUny/QCaFULSY0Y9gSNVhlJDeYPhrQGuFROWyytw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KpKmsN5/9J1wHY56LlCOFpCD6W3pBeBcdtaRkSb9eI40rreAuKsiJ7tbFXfrxRJUI hQMDZaKki177BFrFuCu88KKfHZHTe70Ef/AqqGDw/18eHlpes2ouOx1TmrFxoHN6eB NLL6ceySSM01MGsPrpR4iFJThyppcY1rLJmZSPa8/AvXu3GKSIKlkn5iPfBmIYn6R9 DsI0IdM6go9YBf8XhbWr4L1rSkeVPMAHvOJjpbFMOr8b1QjvnYvxKbKY4QRrUUcSZl 8Wn+k9Nrs0KrmZItbJ52hS7gFZLD2g2AJ/ceM1clu9XmOmed2nQj6RwGZBBS4K9R20 sRiPG+/cHtXOg== Message-ID: Date: Mon, 15 May 2023 13:29:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 3/6] arm64: dts: mediatek: mt8183: Add mediatek,gicr-save-quirk Content-Language: en-US To: Douglas Anderson , Marc Zyngier , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, Eddie Huang , Allen-KH Cheng , Ben Ho , Weiyi Lu , linux-arm-kernel@lists.infradead.org, Tinghan Shen , jwerner@chromium.org, Hsin-Hsiung Wang , yidilin@chromium.org, Seiya Wang , Conor Dooley , linux-kernel@vger.kernel.org References: <20230511150539.6.Ia0b6ebbaa351e3cd67e201355b9ae67783c7d718@changeid> <20230511150539.3.I525a2ed4260046d43c885ee1275e91707743df1c@changeid> From: AngeloGioacchino Del Regno In-Reply-To: <20230511150539.3.I525a2ed4260046d43c885ee1275e91707743df1c@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 12/05/23 00:05, Douglas Anderson ha scritto: > Firmware shipped on mt8183 Chromebooks is affected by the GICR > save/restore issue as described by the patch ("dt-bindings: > interrupt-controller: arm,gic-v3: Add quirk for Mediatek SoCs w/ > broken FW"). Add the quirk property. > > Fixes: e526c9bc11f8 ("arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile") > Signed-off-by: Douglas Anderson > --- > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 5169779d01df..39545172fce5 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -709,6 +709,7 @@ gic: interrupt-controller@c000000 { > <0 0x0c400000 0 0x2000>, /* GICC */ > <0 0x0c410000 0 0x1000>, /* GICH */ > <0 0x0c420000 0 0x2000>; /* GICV */ > + mediatek,gicr-save-quirk; Nit: Can you please move this after interrupts? Thanks, Angelo > > interrupts = ; > ppi-partitions {