From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ming Qian <ming.qian@nxp.com>,
"Mirela Rabulea (OSS)" <mirela.rabulea@oss.nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"X.H. Bao" <xiahong.bao@nxp.com>, Eagle Zhou <eagle.zhou@nxp.com>,
Tao Jiang <tao.jiang_2@nxp.com>, dl-linux-imx <linux-imx@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot for imx jpeg encoder/decoder
Date: Mon, 25 Sep 2023 10:33:26 +0200 [thread overview]
Message-ID: <df86ea4b-d389-4060-bd3b-830bacabde1c@linaro.org> (raw)
In-Reply-To: <AM6PR04MB6341C8E7553F66695467C398E7FCA@AM6PR04MB6341.eurprd04.prod.outlook.com>
On 25/09/2023 10:20, Ming Qian wrote:
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: 2023年9月25日 16:14
>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS)
>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org
>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de;
>> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao
>> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang
>> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>;
>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux-
>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot
>> for imx jpeg encoder/decoder
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On 25/09/2023 10:13, Ming Qian wrote:
>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> Sent: 2023年9月25日 16:10
>>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS)
>>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org;
>> shawnguo@kernel.org
>>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
>>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de;
>>>> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao
>>>> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang
>>>> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>;
>>>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux-
>>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
>>>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg:
>>>> Assign slot for imx jpeg encoder/decoder
>>>>
>>>> Caution: This is an external email. Please take care when clicking
>>>> links or opening attachments. When in doubt, report the message using
>>>> the 'Report this email' button
>>>>
>>>>
>>>> On 25/09/2023 10:07, Ming Qian wrote:
>>>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>>> Sent: 2023年9月25日 16:02
>>>>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS)
>>>>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org;
>>>> shawnguo@kernel.org
>>>>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
>>>>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl;
>>>>>> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
>>>>>> X.H. Bao <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>;
>>>>>> Tao Jiang <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>;
>>>>>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux-
>>>>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
>>>>>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg:
>>>>>> Assign slot for imx jpeg encoder/decoder
>>>>>>
>>>>>> Caution: This is an external email. Please take care when clicking
>>>>>> links or opening attachments. When in doubt, report the message
>>>>>> using the 'Report this email' button
>>>>>>
>>>>>>
>>>>>> On 25/09/2023 09:41, Ming Qian wrote:
>>>>>>> There are total 4 slots available in the IP, and we only need to
>>>>>>> use one slot in one os, assign a single slot, configure interrupt
>>>>>>> and power domain only for 1 slot, not for the all 4 slots.
>>>>>>
>>>>>> No changelog and I do not see much of improvements. Do not ignore
>>>>>> the feedback but respond to it or fix the patch. Really, what happened
>> here?
>>>>>>
>>>>>
>>>>> Hi Krzysztof,
>>>>> What do you mean wrap commit message? Do you mean line wrapped
>> at
>>>> 75 columns?
>>>>>
>>>>> - The body of the explanation, line wrapped at 75 columns, which will
>>>>> be copied to the permanent changelog to describe this patch.
>>>>
>>>> I gave you clear link to the doc explaining this. What is unclear there?
>>>>
>>>> And you decide to ignore all the rest of the comments here as well?
>>
>> So this is still ignored? Can you respond to all my comments?
>>
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>> The link content is as below:
>>>
>>> - The body of the explanation, line wrapped at 75 columns, which will
>>> be copied to the permanent changelog to describe this patch.
>>>
>>> I'm sorry that I didn’t get your point.
>>
>> Wrap
>> your
>> commit
>> according
>> to
>> coding
>> style.
>>
>> Best regards,
>> Krzysztof
>
> Hi Krzysztof,
> I opened your link about the Linux coding style / submission process, but I only find the following message:
>
> - The body of the explanation, line wrapped at 75 columns, which will
> be copied to the permanent changelog to describe this patch.
>
> So I don't know what do you mean the coding style.
Linked document explains what is a patch, how it is formatted. Just read
entire doc, not one sentence.
You keep ignoring my other comments all the time, so I will stop asking
you to respond to them. Instead I will be NAK-ing your patches till you
decide to respond.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-25 8:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 7:41 [PATCH v3 1/2] arm64: dts: imx8-ss-img: Assign slot for imx jpeg encoder/decoder Ming Qian
2023-09-25 7:41 ` [PATCH v3 2/2] dt-bindings: media: imx-jpeg: " Ming Qian
2023-09-25 8:01 ` Krzysztof Kozlowski
2023-09-25 8:07 ` [EXT] " Ming Qian
2023-09-25 8:09 ` Krzysztof Kozlowski
2023-09-25 8:13 ` Ming Qian
2023-09-25 8:14 ` Krzysztof Kozlowski
2023-09-25 8:20 ` Ming Qian
2023-09-25 8:33 ` Krzysztof Kozlowski [this message]
2023-09-25 8:48 ` Ming Qian
2023-09-25 9:02 ` Krzysztof Kozlowski
2023-09-25 16:32 ` Rob Herring
2023-09-25 7:59 ` [PATCH v3 1/2] arm64: dts: imx8-ss-img: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df86ea4b-d389-4060-bd3b-830bacabde1c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eagle.zhou@nxp.com \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ming.qian@nxp.com \
--cc=mirela.rabulea@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tao.jiang_2@nxp.com \
--cc=xiahong.bao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).