From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mark Brown <broonie@kernel.org>, David Heidelberg <david@ixit.cz>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] dt-bindings: sound: tegra-audio-rt5677: Correct example
Date: Thu, 16 Dec 2021 19:07:19 +0300 [thread overview]
Message-ID: <df97dc4f-175f-738b-1670-303113dd58c7@gmail.com> (raw)
In-Reply-To: <20211216160229.17049-1-digetx@gmail.com>
16.12.2021 19:02, Dmitry Osipenko пишет:
> Remove non-existent properties from the example of the binding. These
> properties were borrower from the old txt binding, but they were never
> used in practice and aren't documented in the new binding. They aren't
> reported by the binding checker because dtschema needs extra patch that
> hasn't been upstreamed yet to make unevaluatedProperties work properly.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> .../devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml
> index 03ff691c26c8..a49997d6028b 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml
> @@ -92,9 +92,6 @@ examples:
> nvidia,audio-codec = <&rt5677>;
>
> nvidia,hp-det-gpios = <&gpio 143 0>;
> - nvidia,mic-present-gpios = <&gpio 132 1>;
> - nvidia,hp-en-gpios = <&rt5677 1 0>;
> - nvidia,dmic-clk-en-gpios = <&rt5677 2 1>;
>
> clocks = <&clk 216>,
> <&clk 217>,
>
Interestingly, I can't find any Tegra device-tree that uses this rt5677
binding. Maybe we should remove it?
next prev parent reply other threads:[~2021-12-16 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 16:02 [PATCH v1] dt-bindings: sound: tegra-audio-rt5677: Correct example Dmitry Osipenko
2021-12-16 16:07 ` Dmitry Osipenko [this message]
2021-12-21 15:19 ` Rob Herring
2021-12-21 16:41 ` Mark Brown
2021-12-21 17:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df97dc4f-175f-738b-1670-303113dd58c7@gmail.com \
--to=digetx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).