From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB3A6C433F5 for ; Fri, 18 Mar 2022 11:56:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235995AbiCRL53 (ORCPT ); Fri, 18 Mar 2022 07:57:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232427AbiCRL53 (ORCPT ); Fri, 18 Mar 2022 07:57:29 -0400 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D48CE10429C; Fri, 18 Mar 2022 04:56:06 -0700 (PDT) Received: by mail-lj1-f179.google.com with SMTP id bx44so4480890ljb.13; Fri, 18 Mar 2022 04:56:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LpBDuSYRfhCjN2rL91mRm+RnyEuqAx1X5cQe2gIQXvU=; b=pRUCnvYyE/VQbf9w/9SrFBLsuH43ScruqwEGCJZXCXUEoTGqYTh+T7wC2xOkbRUcX4 BRRGlOOI8uWZJAvZbYVg3lAIjwQeViCKVkwd9w6UzBIRG+wsDBW6WqUXqObc5XB0p0Jl yKs2hXLEaG9JMHVkZBGa4azqyHDDG+Gd2KTwl07rpO/+4mZkI7+VWMAFXAb+eucVq3Ef QN+SWrne0vNHWG+9ZAu0xWuktdLL58fznepB/SrwTLvOy+IOSFJCH35c/QrosVoWWdju mGz2/MBH+UKFZ7gMbFIvSxUKvnCIX59SiSiYPjl7N3xsVS9OUnFKK5581W093gZQ47KD R43Q== X-Gm-Message-State: AOAM530RPArbQ4aTXBB7/kqm+qiszeQRYI0wSZQYYmXvsgLDuZMtEjEm GpFDBmdLVmWk57jIzDt/0UM= X-Google-Smtp-Source: ABdhPJwXxt19VE3E+LR/+1rHtFn/71OmpD0icPdohgbhWWTOiDk8Ulkt/mFgVGq4Zi2NlGCvJlo+Uw== X-Received: by 2002:a2e:9bd7:0:b0:248:ca3:ecf1 with SMTP id w23-20020a2e9bd7000000b002480ca3ecf1mr6179171ljj.66.1647604564930; Fri, 18 Mar 2022 04:56:04 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id a11-20020a194f4b000000b004482e94a3b1sm819762lfk.19.2022.03.18.04.56.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Mar 2022 04:56:04 -0700 (PDT) Message-ID: Date: Fri, 18 Mar 2022 12:56:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] arm64: dts: imx8mp: add ddr controller node to support EDAC on imx8mp Content-Language: en-US To: Sherry Sun , robh+dt@kernel.org, krzk+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, Dinh Nguyen References: <20220318113526.15986-1-sherry.sun@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220318113526.15986-1-sherry.sun@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/03/2022 12:35, Sherry Sun wrote: > i.MX8MP use synopsys V3.70a ddr controller IP, so add edac support > for i.MX8MP based on "snps,ddrc-3.80a" synopsys edac driver. > > Signed-off-by: Sherry Sun > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 794d75173cf5..a6124a11d6ee 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -902,6 +902,12 @@ > interrupt-parent = <&gic>; > }; > > + edacmc: memory-controller@3d400000 { > + compatible = "snps,ddrc-3.80a"; > + reg = <0x3d400000 0x400000>; > + interrupts = ; This is not correct according to the bindings. Dinh's commit adding the compatible might not be correct, so please first fix bindings. While fixing bindings, order the compatibles by name (s goes before x). Best regards, Krzysztof