From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A3EA1B5821; Wed, 7 Aug 2024 06:39:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723012742; cv=none; b=jBW7ABWs3TDIA3r6URwFoT9D6BUsR7ENG/TGISlsyXwKwCkJ8kMkqE8Dv7iOrrUStXB/5OWf6MkIMf5ipJvk7D/7Ej7ywDyclbm9cvfC1JSaaosiKPggo4/SxEzyY+rv8K5SEPrYAXd3i9ShIejB0Hb8fzRWCl1IKu6P2mw59d0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723012742; c=relaxed/simple; bh=Z3qL+4stWbooKXhjTDgHt0vXzTcP3HX87o8OWfzLIhc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kFY1NgbVbTBX/2tYZq7VgHdzUUwMGRfRtja23meSnqrgmG969K0zDMpurR6GNP+78uL15kgU67Xk53zSCxLG49DwvENN5JMLbvjSzigFHUmxsCq7J1RI9tYT08adGhDwOrs3tmgT3mk8e7J9AyGF297RgvHxh5KVh9VhV56ddd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X/CWlRJV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X/CWlRJV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4485C32782; Wed, 7 Aug 2024 06:38:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723012741; bh=Z3qL+4stWbooKXhjTDgHt0vXzTcP3HX87o8OWfzLIhc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=X/CWlRJVZ5CoZkzjHljrrZOTSDD7tJFDjpAm+Vo9RktUUFUBD0ZUgbuMFq/QYwDPn 1koTJ9SS8EshjEE+xPMaGUx0YY1VAAu4mAGZsQTt6Ey59i1pqn4ioc4GAHq2jcDxAb kzN3HGJMA1nz2hajJk923+2Eyd5sEk8qM3UVK/9tVyiLBQisxU8jUbGLbyjX2RDPdp VkBEKxFLr1eHNWSlYb0TEJ/LzbFSMpqpCCqIIlJgacSjjqtMh/7/N8Qv0EJn8r0Ewf UbtAme5qm/fMIwZWO4PaobjeYbMXc9f8L0pX3y2ns6H0Nb+gamGDlXYPqJnxdzPcyM dGzlaXKgq/+Bg== Message-ID: Date: Wed, 7 Aug 2024 08:38:54 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] arm64: dts: amlogic: add some device nodes for C3 To: Xianwei Zhao , Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chuan Liu , Kevin Hilman , Martin Blumenstingl Cc: Krzysztof Kozlowski , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240806-c3_add_node-v1-0-c0de41341632@amlogic.com> <20240806-c3_add_node-v1-2-c0de41341632@amlogic.com> <49b41346-a98a-470b-9572-0f81557eea29@amlogic.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <49b41346-a98a-470b-9572-0f81557eea29@amlogic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/08/2024 07:54, Xianwei Zhao wrote: > Hi Krzysztof, > Thanks for your reply. > > On 2024/8/6 21:13, Krzysztof Kozlowski wrote: >> [ EXTERNAL EMAIL ] >> >> On 06/08/2024 12:27, Xianwei Zhao via B4 Relay wrote: >>> From: Xianwei Zhao >>> >>> Add some device nodes for SoC C3, including periphs clock controller >>> node, PLL clock controller node, SPICC node, regulator node, NAND >>> controller node, sdcard node, Ethernet MAC and PHY node. >>> >>> Signed-off-by: Xianwei Zhao >>> --- >>> .../boot/dts/amlogic/amlogic-c3-c302x-aw409.dts | 249 +++++++++++ >>> arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 487 ++++++++++++++++++++- >>> 2 files changed, 735 insertions(+), 1 deletion(-) >>> >> >> >> ... >> >> >>> + >>> + sd: mmc@8a000 { >>> + compatible = "amlogic,meson-axg-mmc"; >>> + reg = <0x0 0x8a000 0x0 0x800>; >>> + interrupts = ; >>> + power-domains = <&pwrc PWRC_C3_SDCARD_ID>; >>> + clocks = <&clkc_periphs CLKID_SYS_SD_EMMC_B>, >>> + <&clkc_periphs CLKID_SD_EMMC_B>, >>> + <&clkc_pll CLKID_FCLK_DIV2>; >>> + clock-names = "core", "clkin0", "clkin1"; >>> + no-mmc; >>> + no-sdio; >> >> Hm? Why are these blocks incomplete that they do not handle SDIO? Aren't >> you putting board properties into SoC? >> The sdacrd (mmc@8a000) depends on regulator and pinctrl(select), So some > property fields are placed at the board level. The SDIO is connect with > the firmware (wifi&bt). Now I'll remove SDIO implementation and wait > until later to submit it with the firmware. My comment applied to all your nodes. Best regards, Krzysztof