From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D20EC1CD02 for ; Tue, 16 Jan 2024 16:03:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MT+Qx51u" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a293f2280c7so1173933866b.1 for ; Tue, 16 Jan 2024 08:03:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705420989; x=1706025789; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6aXd3Lf2Nq+ETEJoEKdNpd1BvF73kz93m50Vn51D54U=; b=MT+Qx51uR2y6bOFxDN9W98Wi8IhlgGrTf7VTB0v4K+Yug9MRN6f3CUFJeaZCgi6uP3 rCVPf8x2sQPppYDHzK76iuzR+Ex2fwFoRehUhufI8bQTug31XKrIbNHdizha6HeFpFS4 LJ9PflG1MwyblX8RXBbdool/9ElVH5kzc30KkDGn/mNwjUbXhcHgxY4QA+YHidSwOnnQ Dpy6pdswNRiHOKXWkvt78Io+v+EvXZEYsr3AQXqZHtiuqEPLvi2QFhWC7D+O2/nmnZ9v zOD9Uet2XAQpwVK5VQABUFH0/ljh7lSoIeh9UZgD9xX5w7yC6gp3S4SjzQkNL8CO+z5f 7gyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705420989; x=1706025789; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6aXd3Lf2Nq+ETEJoEKdNpd1BvF73kz93m50Vn51D54U=; b=n9OtdICCaY7LTnh2uQb/pOZmHFMh9hKbt8+NZ6fNQ3kFrsKt6wjguHWh+O7XFWieDN dhDFY2rcNEEVQoGue6nMoNody7Jj4yeG4bfIYiUWdjGIkpep9ZQpbiCrj22ib5YkwmE4 4IA89ETIqksrB7CgmpYNgzROuVOm7TiOUxCUM55vIEoXVKr/xO1j7ZabeCPasFA43Esa JzHMuzlQfQ0BaDgzrTFsD1B0nMUMtT4CA/zZuesH1YzzAWXYbAyu4SflJJT3RFWq69uN mypf/+czWfQFQYvTNihQdozLsLD+CksnNJzqvQV+aKmGbdcro6E1JQbxIxX2CKijr5/5 NmSg== X-Gm-Message-State: AOJu0Yw/EjqKtTL5qil420sBhJA8DnwdZ/U9FR3S3jzpXfT0vinqETf0 q9RealYapdMwXNUB02CyxwLEZuibOktLPw== X-Google-Smtp-Source: AGHT+IHN1Vm4jENUzlvih/9rW5+ozQzLxArpf7tkbPHqgLc+G8AGe5AuCZC7zmU8r9hkv9ukEMaWTQ== X-Received: by 2002:a17:907:86a0:b0:a2c:4a3d:731d with SMTP id qa32-20020a17090786a000b00a2c4a3d731dmr2282009ejc.257.1705420989120; Tue, 16 Jan 2024 08:03:09 -0800 (PST) Received: from [192.168.1.20] ([178.197.215.66]) by smtp.gmail.com with ESMTPSA id d14-20020a170906c20e00b00a298e2f6b3csm6610282ejz.213.2024.01.16.08.03.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jan 2024 08:03:08 -0800 (PST) Message-ID: Date: Tue, 16 Jan 2024 17:03:06 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/3] riscv: dts: sophgo: add rtc dt node for CV1800 Content-Language: en-US To: Jingbao Qiu Cc: alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, chao.wei@sophgo.com, unicorn_wang@outlook.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, dlan@gentoo.org, inochiama@outlook.com References: <20240115160600.5444-1-qiujingbao.dlmu@gmail.com> <20240115160600.5444-4-qiujingbao.dlmu@gmail.com> <007e8c14-13eb-4917-b9da-8d47d6c965c7@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/01/2024 16:51, Jingbao Qiu wrote: >>> CV1800 is a RISCV based SOC that includes an RTC module. The RTC >>> module has an OSC oscillator >> >> >> I am not going to read pages of description. Please write concise replies. > > Thanks, What I mean is that this hardware includes two functions, RTC > and POR. How should I describe their relationship? Your POR does not need to take any resources, so no need to describe any relationship. ... >>> Your suggestion is, firstly, the por submodule does not have any >>> resources, so it should be deleted. >> >> So where did you delete it? I still see it in this patch. > > Should I completely delete him? How can a por driver obtain device information? Delete completely. Device information? What is this? We already agreed you don't have any resources for POR. .... >> Device is only one thing, not two. >> >>> reg = <0x5025000 0x2000>; >>> interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; >>> clocks = <&osc>; >>> }; >>> However, in reality, the POR submodule does not use IRQ and CLK. >>> Please do not hesitate to teach. Thanks. >> >> I expect one device node. How many drivers you have does not matter: you >> can instantiate 100 Linux devices in 100 Linux device drivers. > > I understand what you mean. A device node corresponds to multiple drivers. > Should I completely delete the POR device tree node and add it when > submitting the POR driver? ? I wrote it in previous messages and twice in this thread. Completely delete. You do not add it back! Because if you ever intended to add it back, it should be added since beginning. I don't understand what submitting later would solve. > If that's the case, how can I explain that the rtc device tree node > uses the syscon tag? > How can I describe a POR device in DTS? POR is a submodule of RTC, and > it also has corresponding drivers. I said, there is no need for POR in DTS, because you have nothing there. Why do you insist on putting it on DTS? > It's just that his resources are only shared with RTC's Reg. What resources? Reg? That's not a separate resource. To summarize: Drop POR from DTS and never bring it back, unless you come with some different arguments, which you did not say already. Best regards, Krzysztof