devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "André Draszik" <andre.draszik@linaro.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Thomas Antoine <t.antoine@uclouvain.be>,
	Conor Dooley <conor@kernel.org>,  Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Peter Griffin <peter.griffin@linaro.org>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
		devicetree@vger.kernel.org
Subject: Re: [PATCH v6 2/2] dt-bindings: power: supply: add support for MAX77759 fuel gauge
Date: Fri, 19 Sep 2025 14:17:26 +0100	[thread overview]
Message-ID: <dfde0a91359b87d4eff88815b4112ad17cca9935.camel@linaro.org> (raw)
In-Reply-To: <65xrumpt7ug5mqd7mkcknwyqmljrn4sofrqymg46bwvcmjoarr@wmt5fhsj3viz>

Hi,

On Fri, 2025-09-19 at 00:32 +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Thu, Sep 18, 2025 at 02:02:55PM +0100, André Draszik wrote:
> > 
> > Additionally, the FG block can also measure temperature and battery ID. For
> > those, a combination of (top-level) PMIC and FG registers are needed
> > unfortunately. Which means that the FG should probably be an MFD child
> > device, even though the FG itself doesn't depend on the top-level. Otherwise
> > it'd be hard to access the top-level PMIC register.
> 
> My understanding is, that the FG has a dedicated I2C device address

Yes, that is correct. It also has its own dedicated interrupt output.

> and thus cannot be a simple MFD child of the PMIC.

The core can still create child devices if a child uses a different
i2c address, as already done by the max77759 core driver for the charger
(which e.g. doesn't have its own interrupt). Some MFD other core drivers
also use such an approach.


[...]

> Assuming I understood things correctly, I think I suggest to model
> things like this for the battery temperature/ID:

Nice, yes, that should work - didn't think of that...

Cheers,
Andre'

      reply	other threads:[~2025-09-19 13:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-15 10:14 [PATCH v6 0/2] MAX77759 Fuel Gauge driver support Thomas Antoine via B4 Relay
2025-09-15 10:14 ` [PATCH v6 1/2] power: supply: add support for MAX77759 fuel gauge Thomas Antoine via B4 Relay
2025-09-16 16:51   ` Sebastian Reichel
2025-09-15 10:14 ` [PATCH v6 2/2] dt-bindings: " Thomas Antoine via B4 Relay
2025-09-15 17:31   ` Conor Dooley
2025-09-18 12:36     ` Thomas Antoine
2025-09-18 13:02       ` André Draszik
2025-09-18 14:51         ` Conor Dooley
2025-09-18 22:32         ` Sebastian Reichel
2025-09-19 13:17           ` André Draszik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfde0a91359b87d4eff88815b4112ad17cca9935.camel@linaro.org \
    --to=andre.draszik@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=t.antoine@uclouvain.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).