From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43672C4332F for ; Fri, 18 Nov 2022 10:46:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241766AbiKRKqe (ORCPT ); Fri, 18 Nov 2022 05:46:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241855AbiKRKqF (ORCPT ); Fri, 18 Nov 2022 05:46:05 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B31FB9B3B5 for ; Fri, 18 Nov 2022 02:45:37 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id j16so7544690lfe.12 for ; Fri, 18 Nov 2022 02:45:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EDQMv2x+NfeIg4hepEP6f1FTphfl0o9/8AhuUMjcc+I=; b=sDy8EIdAnoCUVGOoAcV7a1Xz+JDtSiutjXCMQ9DacYCE85IA7POPH2g46V2/ASaX8+ 0H+UuTNobIW6VnIA0Y+jMhQF9OvEFJ579KwI4my7rti5tneyBCPJWV/sjyxi0Nf8JC0G Yh5Fz7aPbnSg4xqWRgY6TM+xwtqMNlMj2tWyzCtmaUZps05NP+PYP/UoJS1JnJ4Xh6ng R/cIuopHomP5BrSgr+NyeHJA1PRElc58svbC3pqyFmaOLQ5cEXh2v0GK1ZK3ztOGldHY dMWDR4FCYxKI15PcBZPhn/AA1acLScP7xz+qr61Gmy8/F6y2/fQZQxftIw4H6Vo1vLFy E1ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EDQMv2x+NfeIg4hepEP6f1FTphfl0o9/8AhuUMjcc+I=; b=mDyc9IG9lEQIAjRmWkk6g/Pl/WWqmAl+KXQWCYgdYVCnd1Zy6ZHQipRhdhYa0MfmIl C7IpFdtBtHc1bpl6FWyEgz30yPOX5L4yaAj8SQ8HgQTAF1Zc872q4cK+/rWndxd/BKQq pgJyWL4Mp2rRablEJ7to8x7bT0JRnKSTaF4cuFyFWLMQlR2nOfk3Dm9oZ/mPWDR/SO4k fxLjOtKfvqsbsHCrJFyNwqqB2rWCjyNx/5UWdw1vqjRyM4fqFGYWqaVRdhnUquA0ILbD z44xswbvQmiYG53iMFtz5I8Ar4hZ/kZDSJkxrCF83uRZvleTXIl+ojASUcNhtRJqbliB 4sMw== X-Gm-Message-State: ANoB5pm+k+g5duqRV8WGecgvKSTj/WhJWRSaN7xBcXf8x6yPp9qTZo1e gS+A8dPcyA5uvfl1f3IZy6S7WQ== X-Google-Smtp-Source: AA0mqf7vV2tdGnpiXwtC5D6ZTxDgazbRllYin5VA7YoKbD6XgEbHhhwH389oMxgifnqkjCGApx/E+Q== X-Received: by 2002:a05:6512:16a1:b0:4b1:4933:d0de with SMTP id bu33-20020a05651216a100b004b14933d0demr2096379lfb.10.1668768336006; Fri, 18 Nov 2022 02:45:36 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id m7-20020a0565120a8700b004b497035243sm608798lfu.184.2022.11.18.02.45.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 02:45:35 -0800 (PST) Message-ID: Date: Fri, 18 Nov 2022 11:45:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/2] dt-bindings: reserved-memory: document Qualcomm MPSS DSM memory Content-Language: en-US To: neil.armstrong@linaro.org, Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , Andy Gross , Frank Rowand Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20221114-narmstrong-sm8550-upstream-mpss_dsm-v1-0-158dc2bb6e96@linaro.org> <20221114-narmstrong-sm8550-upstream-mpss_dsm-v1-1-158dc2bb6e96@linaro.org> <38fff21b-3e75-13f9-664e-a115bc527b67@linaro.org> <9aa23650-6ae1-3844-7cf3-6812dc023c11@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <9aa23650-6ae1-3844-7cf3-6812dc023c11@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/11/2022 10:47, Neil Armstrong wrote: >> >>> + >>> +properties: >>> + compatible: >>> + const: qcom,mpss-dsm-mem >> >> Why do we need dedicated binding and compatible for it instead of using >> memory-region phandle in the device? > > So like rmtfs, this memory zone is shared between APPS and the MPSS subsystem. > > Like rmtfs it makes no sense to link it to the MPSS PAS, since it's only a launcher, > it doesn't represent the MPSS subsystem. This also does not represent a device. Memory region is not a device, so this is as well not correct representation of hardware. > > In the PAS startup process, the resources are released from APPS once the MPSS subsystem > is running, which is not the case with the MPSS DSM where it must be shared during the whole > lifetime of the system. I don't think that PAS releases the region. I checked the qcom_q6v5_pas.c and there is only ioremap. The device stays loaded thus the memory stays mapped. We have already three of such "memory region devices" and we keep growing it. It's not scalable. Best regards, Krzysztof