From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 009BFC07E9D for ; Mon, 26 Sep 2022 06:40:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232814AbiIZGkL (ORCPT ); Mon, 26 Sep 2022 02:40:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233630AbiIZGkH (ORCPT ); Mon, 26 Sep 2022 02:40:07 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2100713F97 for ; Sun, 25 Sep 2022 23:40:05 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id a2so9282130lfb.6 for ; Sun, 25 Sep 2022 23:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=sXIGFcRCuTgNUsqejS6T5DqVxD8HCiD5K8J1uAPMJIo=; b=nwBM67q3EX80XM9XWIW0Ljw7hbiDYynI9pgqLJBALtpOzv4PTW24pbmP9MgP2YhYPX aAvR+mSqHjSq4eFnrTUXocOUzEm1E9XswjPn9Iz5Z/VZxaAIOPRGYMkTxCnVwD2g8BSo upplLUf5gDwx/GyK8S++6iIT4IO/Xp3cTtnYZ3X5TSqDvATpfyztCyaGHDjt/4hv+w1C RL3xS/39XrZ6IJU/l+nVv6VwLjM1FLUacJKQLRLxpRTUZgt5WmVVwlfrNqDibOHa76+p zej2WHAhqtvgwoP9zIH5peX2m83EV7zX8jebCQuVaUSgN39THB96KNwBCbvmnCoXoX3w gatg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=sXIGFcRCuTgNUsqejS6T5DqVxD8HCiD5K8J1uAPMJIo=; b=U8fMmk3NxXZsxx5dqONXBzx7+5cs73Zqd9dyb6t1WW1K5xFPGeRXaB10wAH1GGsyxa AOu4Mga6Q/2+SYu2vs/p+g72sXr4UsYDRVXgLsMFI6ey983SHf5WaedPToaoHRzLev/D so5HoAz9twkfQHH2swTjBB04R2uYB+UTDzBSbXgby/xIaaBp+bntY+CmDdSLc1CMPsYI sp2H7jmovAc7SwuqdDcD6f3LD2vbUHRjHr4ScI6Z/X0Ibl5SJyzKqzoLaVJvtXnvNvN7 BEHF/lQfxUHJxp1dNeSooGKIXx8nnFUgnq0F5xIvajYTatVdOcUMmya/TFbaadiGptIl keTw== X-Gm-Message-State: ACrzQf0Mxdmk+oQKRtekiNxFQ4FSPnq8+6oibIUi+vOtGwrsthxG723A O+fe/4+x4xOBp571O2o+Vut0Cw== X-Google-Smtp-Source: AMsMyM506Yk1gyxeS7N+5MkEJGRPPEUV9XweJfzI2MiylPEYaq5CwNqHxOALEQB5EioPL4lP54nK7g== X-Received: by 2002:a05:6512:3b8d:b0:499:b113:865f with SMTP id g13-20020a0565123b8d00b00499b113865fmr7856964lfv.505.1664174403481; Sun, 25 Sep 2022 23:40:03 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id c11-20020a056512074b00b0049aa7a56715sm2445120lfs.267.2022.09.25.23.40.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Sep 2022 23:40:02 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 08:40:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v4 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195 Content-Language: en-US To: =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "matthias.bgg@gmail.com" , "chunkuang.hu@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "angelogioacchino.delregno@collabora.com" Cc: "linux-mediatek@lists.infradead.org" , =?UTF-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "dri-devel@lists.freedesktop.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" , =?UTF-8?B?UmV4LUJDIENoZW4gKOmZs+afj+i+sCk=?= References: <20220924080058.20566-1-jason-jh.lin@mediatek.com> <20220924080058.20566-2-jason-jh.lin@mediatek.com> <6bbe9527-ae48-30e0-fb45-519223a744d7@linaro.org> <23fd466265eec1effd83de6e8ad4ff64eadf5cae.camel@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <23fd466265eec1effd83de6e8ad4ff64eadf5cae.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/09/2022 03:19, Jason-JH Lin (林睿祥) wrote: > Hi Krzysztof, > > Thanks for the reviews. > > On Sun, 2022-09-25 at 09:52 +0200, Krzysztof Kozlowski wrote: >> On 24/09/2022 10:00, Jason-JH.Lin wrote: >>> For previous MediaTek SoCs, such as MT8173, there are 2 display HW >>> pipelines binding to 1 mmsys with the same power domain, the same >>> clock driver and the same mediatek-drm driver. >>> >>> For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding >>> to >>> 2 different power domains, different clock drivers and different >>> mediatek-drm drivers. >>> >>> Moreover, Hardware pipeline of VDOSYS0 has these components: COLOR, >>> CCORR, AAL, GAMMA, DITHER. They are related to the PQ (Picture >>> Quality) >>> and they makes VDOSYS0 supports PQ function while they are not >>> including in VDOSYS1. >>> >>> Hardware pipeline of VDOSYS1 has the component ETHDR (HDR related >>> component). It makes VDOSYS1 supports the HDR function while it's >>> not >>> including in VDOSYS0. >>> >>> To summarize0: >>> Only VDOSYS0 can support PQ adjustment. >>> Only VDOSYS1 can support HDR adjustment. >>> >>> Therefore, we need to separate these two different mmsys hardwares >>> to >>> 2 different compatibles for MT8195. >>> >>> Fixes: 81c5a41d10b9 ("dt-bindings: arm: mediatek: mmsys: add mt8195 >>> SoC binding") >>> Signed-off-by: Jason-JH.Lin >>> Signed-off-by: Bo-Chen Chen >>> --- >>> .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 5 >>> ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam >>> l >>> b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam >>> l >>> index 6ad023eec193..4f90ea03c596 100644 >>> --- >>> a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam >>> l >>> +++ >>> b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam >>> l >>> @@ -31,13 +31,16 @@ properties: >>> - mediatek,mt8183-mmsys >>> - mediatek,mt8186-mmsys >>> - mediatek,mt8192-mmsys >>> - - mediatek,mt8195-mmsys >> >> We keep making circles... > > I didn't find the sample of "deprecated" in the example-schema.yaml, > so I keep misunderstand what you mean. > I'm sorry about that... > >> >> I asked "and why mediatek,mt8195-mmsys is kept as non-deprecated?" >> > Yes, it should be deprecated. I shouldn't remove it... > >> and your response is to remove it... Eh, okay, that's fine but now >> your >> change causes now warnings in existing DTS. Either you keep old entry >> as >> deprecated (just git grep for deprecated, you will find examples how >> to >> do it) or fix the DTS. >> > Thanks for the advice. > > Now I found an example in other yaml, so I just added the "deprecated" > tag like this, right? > > - items: > - enum: > - mediatek,mt2701-mmsys > - mediatek,mt2712-mmsys > - mediatek,mt6765-mmsys > - mediatek,mt6779-mmsys > - mediatek,mt6797-mmsys > - mediatek,mt8167-mmsys > - mediatek,mt8173-mmsys > - mediatek,mt8183-mmsys > - mediatek,mt8186-mmsys > - mediatek,mt8192-mmsys > - mediatek,mt8195-mmsys > deprecated: true No, you need oneOf. You used git grep, good. Now use second command - git log -p - to see how it was exactly added... Best regards, Krzysztof