Re: [PATCH 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: Enable touchscreen

[David Heidelberg <david@ixit.cz>]

On 21/08/2026 09:12, Luca Weiss wrote:
> Add a node and pinctrl for the Himax HX83112A touchscreen found on this
> phone.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>   arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 21 ++++++++++++++++++++-
>   1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> index 23f950067a08..ff609f7e1796 100644
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> @@ -626,7 +626,19 @@ &i2c8 {
>   	clock-frequency = <400000>;
>   	status = "okay";
>   
> -	/* HX83112A touchscreen @ 48 */
> +	touchscreen@48 {
> +		compatible = "himax,hx83112a";
> +		reg = <0x48>;
> +
> +		interrupts-extended = <&tlmm 22 IRQ_TYPE_EDGE_FALLING>;
> +		reset-gpios = <&tlmm 21 GPIO_ACTIVE_LOW>;
> +
> +		touchscreen-size-x = <1080>;
> +		touchscreen-size-y = <2340>;
> +
> +		pinctrl-0 = <&touchscreen_default>;
> +		pinctrl-names = "default";
> +	};
>   };
>   
>   &i2c10 {
> @@ -1117,6 +1129,13 @@ platform {
>   &tlmm {
>   	gpio-reserved-ranges = <13 4>, <56 2>;
>   
> +	touchscreen_default: touchscreen-default-state {
> +		pins = "gpio21", "gpio22";

I guess you could use here irq-pins {}, reset-pins {},

but with or without change,

Reviewed-by: David Heidelberg <david@ixit.cz>

> +		function = "gpio";
> +		drive-strength = <8>;
> +		bias-pull-up;
> +	};
> +
>   	qup_uart1_sleep_cts: qup-uart1-sleep-cts-state {
>   		pins = "gpio61";
>   		function = "gpio";
>